Re: glob_.h glibc

2005-09-12 Thread Derek Price
Paul Eggert wrote: OK, but in that case shouldn't the AC_REQUIRE([AC_GNU_SOURCE]) be in gl_GLOB rather than gl_PREREQ_GLOB? I don't think so. gl_GLOB tests for the _GNU_GLOB_INTERFACE_VERSION macro from gnu-versions.h a known bug in GNU glob's POSIX support. Neither requires the GNU

Re: glob_.h glibc

2005-09-12 Thread Derek Price
Okay, I've committed the glob-min-glibc-h-changes2.diff patch. The glob.h-glibc-to-gnulib2.diff should be the new minimal patch for submission to glibc. 2005-09-12 Derek Price [EMAIL PROTECTED] Paul Eggert [EMAIL PROTECTED] * modules/glob (Files): Add glob-libc.h.

Re: glob_.h glibc

2005-09-09 Thread Paul Eggert
Derek Price [EMAIL PROTECTED] writes: It's late, I'm tired. Patches actually attached now. Thanks. A few comments. First, that SYS_CDEFS_H thing is really confusing. Also, I worry that the GLOB_PREFIX thing doesn't respect the POSIX name space rules. How about if we use a new symbol

Re: glob_.h glibc

2005-09-09 Thread Paul Eggert
Derek Price [EMAIL PROTECTED] writes: Fourth, we can AC_REQUIRE AC_GNU_SOURCE, so that we needn't worry about __USE_GNU. We ran into this problem the first time we went through this: http://lists.gnu.org/archive/html/bug-gnulib/2005-05/msg00144.html. Ouch. Sorry I forgot that. I assume you

Re: glob_.h glibc

2005-09-08 Thread Paul Eggert
Derek Price [EMAIL PROTECTED] writes: Re: http://sourceware.org/bugzilla/show_bug.cgi?id=1060, glibc objected to the extent of our changes to an installed header (glob.h) to bring the file into sync with GNULIB. (They did accept the glob.c changes, though they have yet to apply them.) Hmm,

Re: glob_.h glibc

2005-09-08 Thread Derek Price
It's late, I'm tired. Patches actually attached now. 2005-09-08 Derek Price [EMAIL PROTECTED] * m4/glob.m4 (gl_GLOB_SUBSTITUTE): AC_LIBSOURCE C files. * lib/glob_.h: Move most code forked from glibc here, then include... * lib/glob-glibc.h: ...this new file, which is the original