-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 8/8/2006 3:59 PM:
2006-08-08 Eric Blake ebb9 at byu.net
* modules/verror: New module.
* MODULES.html.sh: Document it.
And another followup, since configure is now outputting:
checking for vasprintf... yes
Hello Eric,
* Eric Blake wrote on Thu, Aug 10, 2006 at 03:08:38PM CEST:
* gnulib-tool (func_import): Check for unexpanded gl_ macros.
This looks like a very good idea to me, in general; minor issues:
- gl_ES is a valid locale name,
- `LC_ALL=C grep gl_[abd-z] gnulib/m4/*' shows many
Ralf Wildenhues Ralf.Wildenhues at gmx.de writes:
So, better would be
m4_pattern_forbid([^gl_[A-Z]])
m4_pattern_allow([^gl_ES])
the first of which is similarly used in coreutils/m4/prereq.m4
already (which in turn was part of Gnulib for a while).
Agreed. Checking in as follows:
Eric Blake wrote:
Checking in as follows:
2006-08-10 Eric Blake [EMAIL PROTECTED]
and Ralf Wildenhues [EMAIL PROTECTED]
* gnulib-tool (func_import): Detect unexpanded macros in gnulib
namespace.
Hmm, this may make a gnulib-tool --import fail while the corresponding
Bruno Haible bruno at clisp.org writes:
Eric Blake wrote:
a useful va_list error variant for use in m4, I propose this new module.
Any objections to installing this?
It looks alright, except for the Ben's comment and this:
+ AC_LIBSOURCES([verror.c, verror.h])
+
Bruno Haible bruno at clisp.org writes:
Yes; it does not make sense for a library to call a function that may call
xalloc_die(). Using xvasprintf results in small and maintainable code.
You could also do it without xvasprintf: perform similar code as in
error.c, really calling vfprintf.
But
Eric Blake ebb9 at byu.net writes:
2006-08-08 Eric Blake ebb9 at byu.net
* modules/verror: New module.
* MODULES.html.sh: Document it.
I am installing this followup, so that users of verror_at_line with a NULL file
still comply with GNU Coding Standards by outputting program:
