configmake module and automake 1.9.6

2010-12-14 Thread Eric Blake
I just ran into an issue where libvirt failed to compile when autotooled with automake 1.9.6, because automake failed to define $(localedir) and therefore gnulib's configmake module did not define LOCALEDIR. Any suggestions on how to make gnulib guarantee $(localedir) will be defined even when

Re: configmake module and automake 1.9.6

2010-12-14 Thread Bruno Haible
Eric Blake wrote: I just ran into an issue where libvirt failed to compile when autotooled with automake 1.9.6, because automake failed to define $(localedir) and therefore gnulib's configmake module did not define LOCALEDIR. Any suggestions on how to make gnulib guarantee $(localedir) will

Re: configmake module and automake 1.9.6

2010-12-14 Thread Eric Blake
On 12/14/2010 02:10 PM, Bruno Haible wrote: Eric Blake wrote: I just ran into an issue where libvirt failed to compile when autotooled with automake 1.9.6, because automake failed to define $(localedir) and therefore gnulib's configmake module did not define LOCALEDIR. Any suggestions on how

Re: configmake module and automake 1.9.6

2010-12-14 Thread Ralf Wildenhues
Hello, * Eric Blake wrote on Tue, Dec 14, 2010 at 10:14:11PM CET: + configmake: support more values with older automake + * modules/configmake (Makefile.am): Provide fallbacks for older + automake. FWIW this looks safer to me because it won't regress 2.60+ setups. Cheers, Ralf

Re: configmake module and automake 1.9.6

2010-12-14 Thread Bruno Haible
Hi Eric, In Makefile.am add: localedir = @localedir@ This is probably not needed at all; the AC_SUBST invocation causes this line to be added to every Makefile.in generated from a Makefile.am automatically. In configure.ac add: dnl Installation directories. dnl Remove this

Re: configmake module and automake 1.9.6

2010-12-14 Thread Eric Blake
On 12/14/2010 02:33 PM, Bruno Haible wrote: In configure.ac add: dnl Installation directories. dnl Remove this when you can assume autoconf = 2.60. AC_SUBST([localedir], ['${datadir}/locale']) This is the essential change. It's also the change that is most likely to cause conflicts