Hello,
taking a tree from
gnulib-tool --with-tests --test
and running distcheck on it ends with
[...]
| rm -f Makefile
| ERROR: files left in build directory after distclean:
| ./gltests/out
| make[1]: *** [distcleancheck] Error 1
| make[1]: Leaving directory `/tmp/build/dummy-0/_build'
|
Ralf Wildenhues wrote:
taking a tree from
gnulib-tool --with-tests --test
Hi Ralf,
Thanks for the report.
and running distcheck on it ends with
[...]
| rm -f Makefile
| ERROR: files left in build directory after distclean:
| ./gltests/out
| make[1]: *** [distcleancheck] Error 1
|
Jim Meyering wrote:
tests/test-pwrite.c appears to be the culprit:
char const *file = out;
...
fd = open (file, O_CREAT | O_WRONLY, 0600);
Looking at fixing that, I found that pwrite-tests already lists init.sh.
Hmm. But it does not use it.
Then I saw commit
Hi Jim,
* Jim Meyering wrote on Sun, May 23, 2010 at 10:14:30AM CEST:
That is one of the key points of init.sh: automatically
isolate tests, so that using generic (not obfuscated out-$$)
names like 'out' and 'err' works safely, as expected.
Ah, good. I really didn't read the script carefully
* Jim Meyering wrote on Sun, May 23, 2010 at 10:22:03AM CEST:
Looking at fixing that, I found that pwrite-tests already lists init.sh.
Hmm. But it does not use it.
Then I saw commit d8fa18472a54c1cb2674c296b3d82443f234d5f7,
which did this:
Remove useless test-pwrite.sh file.
Ralf Wildenhues wrote:
* Jim Meyering wrote on Sun, May 23, 2010 at 10:22:03AM CEST:
Looking at fixing that, I found that pwrite-tests already lists init.sh.
Hmm. But it does not use it.
Then I saw commit d8fa18472a54c1cb2674c296b3d82443f234d5f7,
which did this:
Remove useless
Ralf Wildenhues wrote:
* Jim Meyering wrote on Sun, May 23, 2010 at 10:14:30AM CEST:
That is one of the key points of init.sh: automatically
isolate tests, so that using generic (not obfuscated out-$$)
names like 'out' and 'err' works safely, as expected.
Ah, good. I really didn't read the
