-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Ralf Wildenhues on 7/6/2006 1:48 AM:
Hello Paul,
Some nits below.
* Paul Eggert wrote on Thu, Jul 06, 2006 at 01:44:03AM CEST:
Index: lib/getusershell.c
===
RCS
* Bruno Haible wrote on Tue, Jul 04, 2006 at 06:55:08PM CEST:
Eric Blake wrote:
Meanwhile, is it worth patching autoconf/lib/autoheader.m4 to complain when
$2 of AH_VERBATIM is empty, so this mistake is less likely to occur in the
future?
This would be welcome. Something like this
* Bruno Haible wrote on Thu, Jul 06, 2006 at 02:51:10PM CEST:
Paul Eggert wrote:
* m4/getusershell.m4 (gl_PREREQ_GETUSERSHELL): Remove; no longer needed.
All uses removed.
* m4/strtol.m4 (gl_PREREQ_STRTOL): Likewise.
* m4/strtoul.m4 (gl_PREREQ_STRTOUL): Likewise.
I
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Ralf Wildenhues [EMAIL PROTECTED] writes:
* Paul Eggert wrote on Tue, Jul 04, 2006 at 09:43:44AM CEST:
Mark D. Baushke [EMAIL PROTECTED] writes:
-lib_SOURCES += cycle-check.c cycle-check.h dev-ino.h
+lib_SOURCES += cycle-check.c
Ralf Wildenhues [EMAIL PROTECTED] writes:
But I wonder a bit whether some code makes use of this
feature that
AH_VERBATIM([key], [some code])
dnl ...
AH_VERBATIM([key], []) # no code
happens to not output the code. Thoughts?
It might, but can't you use $# to distinguish that
* quoting myself:
* modules/same-inode: New module, comprising same-inode.h.
* modules/cycle-check: Depend on it, don't list same-inode.h.
* modules/mkdir-p, modules/same: Likewise.
Never mind this patch. It needs either a bunch of m4/ updates to list
same-inode.h in
Ralf Wildenhues [EMAIL PROTECTED] wrote:
* quoting myself:
* modules/same-inode: New module, comprising same-inode.h.
* modules/cycle-check: Depend on it, don't list same-inode.h.
* modules/mkdir-p, modules/same: Likewise.
Never mind this patch. It needs either a bunch of m4/
Bruno Haible [EMAIL PROTECTED] writes:
On a system where 'unsigned char' and 'int' have the same number of
bits, the getc() and fgetc() result EOF would be ambiguous: it could
be EOF or it could be a casted 'unsigned char' value. It sounds very
improbable that such a system exists, now or in
One of the cheapest (ahem) ways to catch a number of gnulib bugs is to
create one tree with all modules and all tests in it. If it works, that
is. So I started doing this manually, again. Here's some fallout on
the way to make
path/to/gnulib-tool --with-tests $l --dir=foo --megatest
work.
I found a few other glitches related to the AC_HEADER_STDC changes
while propagating them into coreutils, and installed the following
further patches. Some of the problems predate the recent changes.
For example, the code wasn't portable to (theoretical?) C99
implementations that have an isblank
Ralf Wildenhues [EMAIL PROTECTED] writes:
4) Documentation should not be copied into the source tree (bug in
getdate module; I'm inferring from other modules here) or the
gnulib-tool should 'mkdir doc' to avoid a cp failure. OK?
My kneejerk reaction is I'd rather that gnulib-tool
Derek R. Price [EMAIL PROTECTED] writes:
Thanks, Bruno. I've attached a patch that replaces all the references
to AC_HEADER_DIRENT with calls to AC_CHECK_HEADERS_ONCE([dirent.h
ndir.h]) and makes the accompanying changes in lib/*. This patch does
simplify, though not quite as much as I was
Paul Eggert [EMAIL PROTECTED] writes:
Ralf Wildenhues [EMAIL PROTECTED] writes:
4) Documentation should not be copied into the source tree (bug in
getdate module; I'm inferring from other modules here) or the
gnulib-tool should 'mkdir doc' to avoid a cp failure. OK?
My kneejerk
Simon Josefsson [EMAIL PROTECTED] writes:
I'll see if I can fix the crc module, it is probably the same 64-bit
problem as in the md4 or md5 module a while ago.
Nope, I think the self-test was created with an old buggy crc.c
implementation. I've changed the test vector to be what the current
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Ralf Wildenhues on 7/6/2006 2:51 PM:
1) $destdir may not contain slashes: gnulib-tool does `mkdir $destdir'
to create it, and `cd $destdir; $cmds; cd ..' to enter/exit.
That also could run into problems if CDPATH is defined and
Paul Eggert [EMAIL PROTECTED] writes:
Ben Pfaff [EMAIL PROTECTED] writes:
The issue at hand, as I understand it, is not even the general
behavior of signals. It is the behavior of fatal signals. That
is, a the program terminates without ever returning from the
signal handler. This is
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Jim Hyslop reported needing the attached patch to compile getaddrinfo.c
in MSVC6.
2006-07-06 Jim Hyslop [EMAIL PROTECTED]
* lib/getaddrinfo.c: Changes to compile under MSVC6: changed
'#if WIN32_NATIVE' to '#ifdef' moved WSAAPI
17 matches
Mail list logo
