Re: bugs in dirname module

2005-11-17 Thread Eric Blake
Actually, I think that calling base_name should strip the trailing slashes, similar to POSIX basename(). But if you do that, you violate this basic rule: If you have a valid file name F, then accessing F is the same as chdir(dir_name(F)) followed by accessing base_name(F).

style question - const char *

2005-11-17 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Is there a preference for 'const char *' over 'char const *'? A quick grep of my locally-modified gnulib repository shows 208 char const * vs. 793 const char * in the .c and .h files. The GNU Coding Standards offer no help -

Re: style question - const char *

2005-11-17 Thread Paul Eggert
Eric Blake [EMAIL PROTECTED] writes: Is there a preference for 'const char *' over 'char const *'? I prefer putting type qualifiers like const after the types they modify, as that's more consistent. For example, char * const * puts the const after the char *, where it belongs. Similarly, char