Re: $(EXEEXT) in TESTS required?

2006-01-24 Thread Ralf Wildenhues
Hi Bruno, * Bruno Haible wrote on Mon, Jan 23, 2006 at 09:51:57PM CET: ... noinst_PROGRAMS = check_PROGRAMS = test-lock$(EXEEXT) TESTS = test-lock check-am: all-am $(MAKE) $(AM_MAKEFLAGS) $(check_PROGRAMS) $(MAKE) $(AM_MAKEFLAGS) check-TESTS check-TESTS: $(TESTS)

Re: socket.h

2006-01-24 Thread Simon Josefsson
Bruno Haible [EMAIL PROTECTED] writes: Simon Josefsson wrote: +#if !defined(SHUT_WR) defined (SD_SEND) +# define SHUT_WR 1 +#endif +#if !defined(SHUT_RDWR) defined (SD_BOTH) +# define SHUT_RDWR 2 +#endif Is SD_SEND == 1 and SD_BOTH == 2 ? Yes, although it is a mistake to hard code

Re: socket.h

2006-01-24 Thread Simon Josefsson
Jim Meyering [EMAIL PROTECTED] writes: Simon Josefsson [EMAIL PROTECTED] wrote: For some reason, mingw32 uses non-POSIX names for shutdown's ... --- socket_.h09 Jan 2006 17:13:09 +0100 1.1 +++ socket_.h19 Jan 2006 14:39:07 +0100 @@ -34,4 +34,15 @@ # include ws2tcpip.h

Re: $(EXEEXT) in TESTS required?

2006-01-24 Thread Simon Josefsson
Ralf Corsepius [EMAIL PROTECTED] writes: On Mon, 2006-01-23 at 21:51 +0100, Bruno Haible wrote: [For the automake people: The problem is that a Makefile.am snippet like TESTS = test-lock check_PROGRAMS = test-lock test_LOCK_LDFLAGS = -lmyspeciallib when cross-compiling to

Re: socket.h

2006-01-24 Thread Jim Meyering
Simon Josefsson [EMAIL PROTECTED] wrote: Any objection to removing [useless parentheses]? No, please install them. Ok. I've checked that in. I agree. I wish 'indent' could fix this too. Maybe it can? Even if I agree many code writing ideas given here, I forget them all the time. I

Re: socket.h

2006-01-24 Thread Bruno Haible
Paul Eggert wrote: I don't see any technical reason to prefer the parentheses. While I agree that there are no technical reason to put the parentheses, I wouldn't be religious on the issue, because the majority of the C programmers does it the other way. The same argument as for const char *:

Re: $(EXEEXT) in TESTS required?

2006-01-24 Thread Bruno Haible
Ralf Wildenhues wrote: check_PROGRAMS = test-lock$(EXEEXT) TESTS = test-lock ... What about @substituted@ values? TESTS = @substituted@ You could treat it like @substituted@ in check_PROGRAMS, namely - assume that $(EXEEXT) is contained in the substituted value, - warn if

Re: $(EXEEXT) in TESTS required?

2006-01-24 Thread Bruno Haible
Ralf Corsepius wrote: Due to lack of a mingw toolchain, I can't tell you exactly what goes wrong for you. 3 likely candidates: * The cross gcc doesn't produce *.exe's (This would be a gcc bug). * You are not correctly invoking configure. * Makefile bug somewhere. Is there need to

Re: $(EXEEXT) in TESTS required?

2006-01-24 Thread Ralf Corsepius
On Tue, 2006-01-24 at 13:15 +0100, Simon Josefsson wrote: Ralf Corsepius [EMAIL PROTECTED] writes: On Mon, 2006-01-23 at 21:51 +0100, Bruno Haible wrote: [For the automake people: The problem is that a Makefile.am snippet like TESTS = test-lock check_PROGRAMS = test-lock

Re: openat-priv.h needs intprops.h

2006-01-24 Thread Jim Meyering
Mark D. Baushke [EMAIL PROTECTED] wrote: Hi Jim, The openat provided file openat-priv.h tries to include intprops.h but that file is not listed in the modules/openat file as a dependency. The following patch seems to fix this problem for me. There is probably a better way to do it, but I

openat-priv.h needs intprops.h

2006-01-24 Thread Mark D. Baushke
Hi Jim, The openat provided file openat-priv.h tries to include intprops.h but that file is not listed in the modules/openat file as a dependency. The following patch seems to fix this problem for me. There is probably a better way to do it, but I will leave that to you. Thanks!

Re: [bug-gnulib] lib/stdbool_.h doesn't honor HAVE__BOOL

2006-01-24 Thread Bruno Haible
Albert Chin wrote: The HP-UX 11.23/IA aCC6 compiler has bool and _Bool. This generates an error building something that includes gnulib's auto-generated stdbool.h: ../include/stdbool.h, line 84: error #2084: invalid combination of type specifiers typedef bool _Bool;

Re: removing unnecessary parentheses in #if defined (FOO)

2006-01-24 Thread Bruno Haible
Jim Meyering wrote: you must admit the parentheses in `#if defined (SYM)' add next to nothing in readability, and actually detract as soon as you end up adding another layer of parentheses: #if (defined (S1) || defined (S2)) defined (S3) I agree with this. If this were the only piece of

Re: [bug-gnulib] gnulib/gnulib-tool shell quoting problem for Solaris /bin/sh

2006-01-24 Thread Bruno Haible
Mark D. Baushke wrote: on a Solaris 9 system I have run into problems when /bin/sh is used. ... I am getting these two errors: sed: -e expression #1, char 2: unterminated `s' command ../gnulib/gnulib-tool: .*^I,,: not found sed: -e expression #1, char 2: unterminated `s' command

Re: [bug-gnulib] Re: lib/stdbool_.h doesn't honor HAVE__BOOL

2006-01-24 Thread Bruno Haible
Paul Eggert wrote on 2005-11-26: Unfortunately that isn't enough to fix the stdbool module problems we've been running into recently with coreutils. They include: Some HP-UX C compilers mishandle _Bool (internal compiler error), independently of whether stdbool.h works. E.g.,

Re: [bug-gnulib] proposed stdbool fixes for AIX, HP-UX, and now IRIX

2006-01-24 Thread Bruno Haible
Paul Eggert wrote: While looking into an old Bison bug report for IRIX Where can I find the report, please? Bruno ___ bug-gnulib mailing list bug-gnulib@gnu.org http://lists.gnu.org/mailman/listinfo/bug-gnulib

Re: [bug-gnulib] Re: getaddrinfo: finding gethostbyname in mingw32

2006-01-24 Thread Bruno Haible
Simon Josefsson wrote: Unless there is a simple concrete solution to this, I'm inclined to install the patch below and document that people using this module will have to call WSAStartup manually, I don't know the simple concrete solution either :-), so I would do like you say. +#define

Re: [bug-gnulib] Re: portability fix for bison-1.75

2006-01-24 Thread Bruno Haible
Paul Eggert wrote: (__strndup): Revert to KR-style function dfns, the glibc style. Huh? We know the problems of KR-style function definitions: arguments of type 'float', 'short' and 'char' are implicitly promoted, leading to a clash with the function prototype. Empty argument lists allow

Re: [bug-gnulib] Re: portability fix for bison-1.75

2006-01-24 Thread Paul Eggert
Bruno Haible [EMAIL PROTECTED] writes: How about this additional patch? Thanks. I installed the patch to modules/strnlen, but omitted the changes to comments in config/srclist.txt, since that part of srclist.txt catalogs code that is not taken from glibc.

Re: [bug-gnulib] Re: portability fix for bison-1.75

2006-01-24 Thread Paul Eggert
Bruno Haible [EMAIL PROTECTED] writes: Wouldn't it be better to move the glibc source code to ANSI C? I think so, yes. I don't know why Roland and Ulrich prefer KR style function definitions in some cases. They do have a reason, but I didn't understand it when Roland briefly tried to explain