Re: stdint vs cycle-check.h

2006-06-21 Thread Paul Eggert
[EMAIL PROTECTED] (Larry Jones) writes: # if HAVE_INTTYPES_H # include inttypes.h # endif # if HAVE_STDINT_H # include stdint.h # endif I don't understand that recommendation. Since inttypes.h is supposed to #include stdint.h, why isn't the recommendation: As I recall, it's for some

Re: read-file

2006-06-21 Thread Simon Josefsson
Paul Eggert [EMAIL PROTECTED] writes: Simon Josefsson [EMAIL PROTECTED] writes: --- read-file.c 16 Jun 2006 21:26:36 +0200 1.1 +++ read-file.c 17 Jun 2006 18:22:29 +0200 @@ -43,6 +43,9 @@ if (!buf) return NULL; + if (ferror (stream)) +return NULL; +

getaddrinfo windows fixes

2006-06-21 Thread Simon Josefsson
I've noticed that getaddrinfo didn't exist in ws2_32.dll on Windows 2000. The hack in the getaddrinfo module to define WINVER to 0x0501 seems like an incorrect approach. Ideally, the replacement code should, during runtime, open ws2_32.dll and check for the getaddrinfo symbol and use it if

Re: sys_socket fix to remove WINVER

2006-06-21 Thread Ralf Wildenhues
Hi Simon, A couple of nits: * Simon Josefsson wrote on Wed, Jun 21, 2006 at 07:39:42PM CEST: + Currently only MinGW is supported. See the gnulib manual regarding + Windows sockets. MinGW have the header files winsock2.h and s/have/has/ + ws2tcpip.h that declare the sys/socket.h

Misleading cast in glob.c

2006-06-21 Thread Larry Jones
There are casts in glob.c that contain ineffective const's that some compilers warn about: Index: glob.c === RCS file: /cvsroot/cvs/ccvs/lib/glob.c,v retrieving revision 1.18 diff -u -r1.18 glob.c --- glob.c 20 Mar 2006 02:21:56

stdint module on SGI

2006-06-21 Thread Mark D. Baushke
Hi Bruno, The following two patches take a closer step toward making things work under the default c89 compiler on SGI boxes. All files that #include stdint.h still get warnings like this one: cc-1035 cc: WARNING File = /usr/include/stdint.h, Line = 5 #error directive: This header file is to

Re: stdint vs cycle-check.h

2006-06-21 Thread Larry Jones
Paul Eggert writes: [EMAIL PROTECTED] (Larry Jones) writes: I don't understand that recommendation. Since inttypes.h is supposed to #include stdint.h, why isn't the recommendation: As I recall, it's for some older hosts where inttypes.h does not include stdint.h. Sorry, I don't

Re: sys_socket fix to remove WINVER

2006-06-21 Thread Simon Josefsson
Ralf Wildenhues [EMAIL PROTECTED] writes: Hi Simon, A couple of nits: * Simon Josefsson wrote on Wed, Jun 21, 2006 at 07:39:42PM CEST: + Currently only MinGW is supported. See the gnulib manual regarding + Windows sockets. MinGW have the header files winsock2.h and s/have/has/