Re: Update HACKING

2024-04-23 Thread Paul Eggert
On 2024-04-23 12:41, Bruno Haible wrote: ?? That's not a difference between how I and how you work. Oh, right, I got my directions confused. Sorry about the noise.

Re: memset_explicit: Fix compilation error on some OpenSolaris derivatives

2024-04-23 Thread Collin Funk
Hi Bruno, On 4/19/24 3:12 PM, Bruno Haible wrote: > The reason is that on this system, the function 'memset_s' exists in libc, > but is only declared (in /usr/include/iso/string_iso.h) if __EXT1_VISIBLE > is set. __EXT1_VISIBLE is defined by if > __STDC_WANT_LIB_EXT1__ is defined to non-zero at

Re: Gnulib in Debian

2024-04-23 Thread Bruno Haible
Reuben Thomas wrote: > (not yet in Debian, sadly, as they don't like me "vendoring gnulib", as FTP > Master calls it, or "using gnulib as other packages like Enchant do, and as > designed", as I call it). I assume you are alluding to the mail thread that starts at

Re: 'relocatable' project built without --enable-relocatable

2024-04-23 Thread Bruno Haible
Reuben Thomas wrote: > For a library. For example, from the libpaper commit referenced below, > using #ifdefs: > > /* Set the prefix directory for relocation. */ > void papersetprefixdir(const char *new_prefix) > { > #ifdef ENABLE_RELOCATABLE > set_relocation_prefix (INSTALLPREFIX,

Re: new committer questions

2024-04-23 Thread Sam James
Bruno Haible writes: > Our new committer, Collin Funk, asks: >> Since I am not a GNU maintainer and have not >> used Savannah, please send any other rules, documentation, etc. that >> you think would be beneficial to read. > [...] Forgive the noise, but congratulations Collin! > [...] > >

Re: Update HACKING

2024-04-23 Thread Collin Funk
On 4/23/24 10:03 AM, Paul Eggert wrote: > I use 'git format-patch' and then read the patch; this works > reasonably well for me. gitk is nice, but can be a hassle if I'm in > Emacs or logged in remotely. I do the same, but also regenerate the patch before submitting because I am paranoid of

Re: 'relocatable' project built without --enable-relocatable

2024-04-23 Thread Reuben Thomas
On Tue, 23 Apr 2024 at 21:46, Bruno Haible wrote: > How does or would the code you are talking about look like, with #ifs? > And would it be code for a library, or for a program? > For a library. For example, from the libpaper commit referenced below, using #ifdefs: /* Set the prefix directory

Re: new committer questions

2024-04-23 Thread Collin Funk
Hi Bruno, On 4/23/24 8:34 AM, Bruno Haible wrote: > Regarding the git repository: When it appears to not respond, you can > - see whether it's a planned maintenance, at > https://hostux.social/@fsfstatus > - or ask the savannah admins on IRC (host libera.chat, channel #savannah). Thanks!

Re: 'relocatable' project built without --enable-relocatable

2024-04-23 Thread Bruno Haible
Reuben Thomas wrote: > Could macros be similarly added for the other relocatable.h > APIs, namely set_relocation_prefix and compute_curr_prefix? This would > allow relocate-using code to be entirely #ifdef free. How does or would the code you are talking about look like, with #ifs? And would it

Re: Update HACKING

2024-04-23 Thread Bruno Haible
Paul Eggert wrote: > > +* Before pushing a commit, it is highly recommended that you review it in > > + its entirety. The easiest way to do so is to run > > +$ gitk > > I use 'git format-patch' and then read the patch; this works reasonably > well for me. gitk is nice, but can be a hassle

Re: gnulib-tool.py: Use absolute imports consistently.

2024-04-23 Thread Collin Funk
Hi Bruno, On 4/23/24 8:37 AM, Bruno Haible wrote: > I also checked the effect on the warnings in Eclipse: No new warnings, > and 1 existing "unused import" warning is fixed. > > The patch is OK to push. Done. Thanks! Collin

Re: Update HACKING

2024-04-23 Thread Paul Eggert
On 2024-04-23 08:03, Bruno Haible wrote: +* We use a linear git history — no merges. To work in this setting, it's + recommended that you configure git with 'git config pull.rebase = true'. I don't follow this recommendation: instead, I make sure that my master branch matches upstream

Re: gnulib-tool.py: Use absolute imports consistently.

2024-04-23 Thread Bruno Haible
Hi Collin, > > OK, patch welcome. I assume that when Dmitry used this style of assignments, > > the Python 2.7 / 3.0 imports were not so well developed as they are today. > > Here is a patch that removes all the module-specific variables and > imports the functions directly. The patch looks

new committer questions

2024-04-23 Thread Bruno Haible
Our new committer, Collin Funk, asks: > Since I am not a GNU maintainer and have not > used Savannah, please send any other rules, documentation, etc. that > you think would be beneficial to read. For Gnulib, we use Savannah only for the git repository and the news announcements. Regarding the

Update HACKING

2024-04-23 Thread Bruno Haible
Let me add a bit more advice to the HACKING file. 2024-04-23 Bruno Haible Update HACKING. * HACKING: Mention the linear git history, how to work with ChangeLog, how to run a testdir, where to find the gnulib-tool tests, and where are the continuous

'relocatable' project built without --enable-relocatable

2024-04-23 Thread Reuben Thomas
relocatable.h has partial support for building without --enable-relocatable: it #defines relocate and relocate2 to empty macros. This is great! Could macros be similarly added for the other relocatable.h APIs, namely set_relocation_prefix and compute_curr_prefix? This would allow relocate-using