time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkqOiqAACgkQ84KuGfSFAYAClgCgkcv
(name, flags | O_CLOEXEC);
^
Not sure how that 8-bit character got there.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key
file with:
enable_silent_rules=yes
This change affects many modules/ files, not all mine, so I'll
wait for feedback before pushing.
OK for all of my modules in the list.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE
to make
test-exclude.c use the binary-io module to ensure binary output, so that
no \r are generated in the first place?
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key
-posix.h, test-snprintf-posix.c, test-vsnprintf-posix.c for
an example of this coding pattern.
Likewise for test-open.c and fcntl--.h.
Likewise for test-popen.c and stdio--.h.
Done.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP
(int fd, int flags);
int dup2_ex (int oldfd, int newfd, int flags);
What's the difference between dup2_ex and dup3, other than the set of
valid flags accepted?
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version
, using setmode()? (On Linux, O_BINARY and O_TEXT are both 0, so we
have implicitly already done so).
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net
F_SETFL - you must compare against explicit -1.
Otherwise, looks sane to me. Do you have a test case in mind?
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key
-specific O_* values, are blindly passed
through. Do we really want that?
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment
(but not those inherited from a parent process). I don't know if that is
helpful, or worse because we would then be inconsistent.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key
to support it. Or are you saying that it is
possible to compile on a newer glibc, then run with the same libc.so but
against an older kernel, where the result of a configure-time test is no
longer accurate?
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
/_open_osfhandle on both control paths.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http
whether pipe2
exists, so that we aren't wasting time on a guaranteed ENOSYS on all
subsequent invocations?
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net
, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkqR
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 8/23/2009 8:37 PM:
For that matter, proposing an
O_SAFER to the glibc folks might be worthwhile.
With kernel support for O_SAFER, our *_safer paradigms could even be more
efficient (no fd_safer after the fact, so fewer
issues (for example, you can't specify O_TEXT or
O_BINARY with creat; you can't specify O_NOCTTY to protect yourself from
obtaining a controlling terminal, ...); portable code already uses open()
rather than creat().
- --
Don't work too hard, make some time for fun as well!
Eric Blake
with EINVAL is beyond me).
The following patch clears up this issue, and a related compilation warning in
pipe2.c.
From: Eric Blake e...@byu.net
Date: Mon, 24 Aug 2009 16:00:44 -0600
Subject: [PATCH] dup2, pipe2: fix some recent test failures on cygwin 1.5.x
* lib/pipe2.c (includes): Add binary
is on this
machine? I suspect that the dup2.m4 test needs to be enhanced.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG
hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkqWj
open_safer...
open - 2
fcntl(2,F_DUPFD,3)
fputc(stderr)
fflush(stderr) - clobbers thread 1's file
close(2)
open_safer - 3
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Florian Weimer on 8/27/2009 8:35 AM:
* Eric Blake:
int open_safer (const char *name, int flags, int mode)
{
int fd = open (name, flags | O_CLOEXEC, mode);
if (0 = fd fd = 2)
{
int dup = fcntl (fd, ((flags
.
I really don't see a way around that. You can't pick a descriptor and
hope that it's unused.
fcntl(,F_DUPFD,3) is NOT like dup2. It picks the next available
descriptor that is at least 3.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Florian Weimer on 8/28/2009 6:52 AM:
* Eric Blake:
Your version fails to clear the cloexec bit of the final fd if the
original caller didn't request O_CLOEXEC.
Okay, but you can fix that in a race-free manner (but I thought
.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
, and
the query fails because the read fails, so no further actions
are attempted.
I didn't try finding a case in tar, although I suspect it may
be possible to find one.
--
Eric Blake
--
View this message in context:
http://www.nabble.com/need-opendir_safer%2C-dirent--.h-tp25190069p25193082.html
Sent
in
the wild of someone that generates it where we can work around it; and the
set of errors to ignore is highly context-dependent, so a generic function
will never be useful to me.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE
would have to decide whether it was better to always open an fd up front in
opendir or just delay until the first dirfd (if any) for tying an fd to a DIR
created by opendir.
So, here's the two patches I plan to apply soon...
From: Eric Blake e...@byu.net
Date: Mon, 31 Aug 2009 06:09:08 -0600
Eric Blake ebb9 at byu.net writes:
One improvement possible for fdopendir is that
if fchdir is being emulated by gnulib, we can do a query into the fchdir
metadata table to retrieve the directory name associated with an fd, rather
than having to go through save_cwd/fchdir/opendir
.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 8/31/2009 5:38 PM:
Notice that this changes the status of fdopendir - whereas it was previously
non-multithread safe and could call _exit, the mingw version of fdopendir is
now threadsafe and avoids _exit.
Well
, and allows me to run gnulib
testsuites
under cygwin while cross-compiling to mingw:
The above looks fine.
However, there are two missing $ signs below:
Pushed, with that typo corrected.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 8/31/2009 3:35 PM:
One of the main reasons the fchdir module was added was so that the openat
module (and friends) would compile on mingw. Well, it turns out that mingw
has
the (documented) limitation that open(dir
by the autoconf manual.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
Eric Blake ebb9 at byu.net writes:
+/* Return stat information about FD in STATBUF. Needed when
+ rpl_open() used a dummy file to work around an open() that can't
+ normally visit directories. */
+#if REPLACE_OPEN_DIRECTORY
+int
+rpl_fstat (int fd, struct stat *statbuf)
+{
+ if (0
Eric Blake ebb9 at byu.net writes:
I think we need to implement opendir_safer, alongside all the other
*_safer modules. Otherwise, opendir can end up placing an open directory
fd in one of the standard slots, and end up interfering with the intent of
all the other *_safer wrappers
fdsavedir are also candidates, but there weren't any
within gnulib.
From: Eric Blake e...@byu.net
Date: Tue, 1 Sep 2009 14:06:37 -0600
Subject: [PATCH] fts: make directory fds more robust
* lib/fts.c (opendirat): Specify O_DIRECTORY.
Signed-off-by: Eric Blake e...@byu.net
---
ChangeLog |3
with a more useful errno value than fdopendir.
So blindly adding O_NOFOLLOW for opendirat is wrong.
Here's the latest draft of my patch.
From 0145db62dc0f4fc77ed98119e40d256d95aa21cb Mon Sep 17 00:00:00 2001
From: Eric Blake e...@byu.net
Date: Tue, 1 Sep 2009 14:06:37 -0600
Subject: [PATCH] fts: make
of the suite of CLOEXEC improvements.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http
Eric Blake ebb9 at byu.net writes:
Here's the latest draft of my patch.
While we're at it, I noticed via findutils that fts leaks fds into child
processes. This plugs the fts leak (but completely fixing find also requires a
patch to findutils).
Hmm - POSIX states that fdopendir can
the list
of lib/*.c files is longer than the list of modules/* edits.
From: Eric Blake e...@byu.net
Date: Wed, 2 Sep 2009 17:06:43 -0600
Subject: [PATCH] errno: use consistently
* lib/c-stack.c (ENOTSUP): errno.h guarantees a definition.
* lib/canonicalize-lgpl.c (ENAMETOOLONG): Likewise.
* lib
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Jim, what do you think of this patch, making it possible to avoid
including openat.h if you only use the POSIX 2008 interfaces?
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE
for /proc/self/fd and save_cwd/fchdir/func/restore_cwd magic.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG
cygwin 1.7.1 is a formal release).
http://cygwin.com/ml/cygwin/2009-09/msg00109.html
That brings up the lack of an faccessat replacement in gnulib.
I'll post a module for this shortly.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP
Eric Blake ebb9 at byu.net writes:
That brings up the lack of an faccessat replacement in gnulib.
I'll post a module for this shortly.
It is feasible for a system to have faccessat but not euidaccess (if they are
complying strictly with POSIX 2008), so we might as well add that to our
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 9/2/2009 1:00 PM:
And here's openat-safer, plus a rework of making fts safer.
Well, if I wouldn't create compilation errors in the process.
+ * lib/chdir-long.c (includes): Use fcntl--.h, since openat
(and hoping not to hit ENAMETOOLONG errors).
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla
run more testing there first).
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http
BH4AoMwaMEkZX1Vr2IpVcQkzRlZq3yWU
=0dhK
-END PGP SIGNATURE-
From c46ae39631773a7fdae7d171cc4ef0bf2123efff Mon Sep 17 00:00:00 2001
From: Eric Blake e...@byu.net
Date: Fri, 4 Sep 2009 21:22:21 -0600
Subject: [PATCH] openat: fail with ENOENT on empty name
* lib/openat-proc.c (openat_proc_name): Special-case
privileges), at least symlinkat does. It passes on
at least mingw (no symlink), cygwin 1.5 (symlink but no symlinkat,
/proc/self unreliable), cygwin 1.7 (native symlinkat), and older Linux (no
symlinkat, but /proc/self works).
- --
Don't work too hard, make some time for fun as well!
Eric Blake
, but gnulib provides a readlink replacement, so is it
better to use HAVE_SYMLINK or HAVE_READLINK as the witness that symlinks work?
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Bruno Haible on 9/6/2009 2:22 PM:
Eric Blake wrote:
configure.ac:
gl_FUNC_OPENAT
+gl_MODULE_INDICATOR([openat])
This is not needed for gnulib: There is no use of GNULIB_OPENAT as a C
preprocessor macro anywhere in lib/, nor
in
unistd.in.h and sys_stat.in.h, for legibility.
And it will make it easier to support rpl_openat to support workarounds
like O_CLOEXEC support.
OK to apply?
Yes, please.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE
GNULIB_OPENAT would have
the value 0 instead of 1.
faccessat and symlinkat had the same bug. Pushing this followup, along
with some doc fixes.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin
() = faccessat(,AT_EACCESS)
statat() = fstatat(,0)
lstatat() = fstatat(,AT_SYMLINK_NOFOLLOW)
to match the existing shortcuts of chownat, lchownat, etc.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9
that there is no lchmod ability, and
the user has to fall back to chmodat themselves if they know they aren't
working on a symlink. Patch withdrawn (unless anyone else can speak up
for a reason of why to include it).
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
that indicates
whether link will hard-link a symlink or follow it).
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment
.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
with EINVAL),
b) modernize the rename module to use stdio.in.h instead of #define
rpl_rename directly in config.h
c) implement the renameat module on top of rename
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 9/7/2009 10:30 AM:
Any objections to deleting the rename-dest-slash module? It performs a
subset of the rename module,
Correction. As currently written, rename.m4 checks whether:
rm -rf d1 d2
mkdir d1
rename(d1/,d2
bugs.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 9/7/2009 11:12 AM:
According to Eric Blake on 9/7/2009 10:30 AM:
Any objections to deleting the rename-dest-slash module? It performs a
subset of the rename module,
Correction. As currently written, rename.m4 checks
the gnulib submodule.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http
that issue. But
I'm not too worried about those unless someone actually reports that they
encountered it in practice.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Bruno Haible on 9/8/2009 1:50 AM:
Eric Blake wrote:
--- a/modules/sys_stat
+++ b/modules/sys_stat
...
+ -e 's|@''GNULIB_OPENAT''@|$(GNULIB_OPENAT)|g' \
Why this? The @GNULIB_OPENAT@ token is used only in fcntl.in.h
you think about relaxing it?
Done.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http
on Linux to work around kernel bugs.
But I will probably complete the suite this week.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
, ...
Done. And this time, tested with gnulib-tool --lgpl.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG
euidaccess (const char *file, int mode)
{
#if HAVE_FACCESSAT
return faccessat (AT_FDCWD, file, mode, AT_EACCESS);
#elif defined EFF_ONLY_OK
Nope; that would be reverting the intent of commit bc366ae.
--
Eric Blake
(0x) works as expected.
--
Eric Blake
Eric Blake ebb9 at byu.net writes:
Part of the problem on mingw is that the fchdir module relies on
canonicalize doing the right thing, but mingw's paths (with drive letters
and \, rather than leading / for absolute) throws canonicalize for a loop;
and cross-compilation tries to replace
too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
, the
semantics of HAVE_STRNDUP were confusing - AIX 5 has it, but it needs
replacing, so the variable is better named REPLACE_STRNDUP. Cleaned up as
follows:
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG
their optimization. OK to
commit?
I plan on porting the testsuite changes to test-canonicalize.c, and fixing any
fallout there as a separate commit.
From: Eric Blake e...@byu.net
Date: Thu, 10 Sep 2009 12:12:16 -0600
Subject: [PATCH] canonicalize-lgpl: reject non-directory with trailing slash
* tests/test
Eric Blake ebb9 at byu.net writes:
I noticed that glibc has applied some fixes to canonicalize.c that we were
missing; and sure enough, was able to enhance the testsuite to trip these
bugs. They also applied some assert's proving that their optimization to
avoid
strcpy are safe; I left
canonicalize_filename_mode(,CAN_EXISTING) (perhaps via a #define in system.h).
Eric Blake (6):
canonicalize-lgpl: reject non-directory with trailing slash
stdlib: sort witness names
canonicalize: leave canonicalize_file_name to canonicalize-lgpl
canonicalize-lgpl: use native realpath if it works
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 9/10/2009 12:21 PM:
Hmm, on thinking about this more, there are probably existing Linux machines
where glibc canonicalize_file_name is broken (fails to detect ENOTDIR
on file/), and therefore we need to replace it.
I
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 9/11/2009 4:35 PM:
[3/11] canonicalize: don't lose errno
glibc still has a bug in realpath/c_f_n where errno could be inadvertently
changed by a call to free() during an error return, but canonicalize-lgpl
work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
directory
was passed in).
From: Eric Blake e...@byu.net
Date: Mon, 14 Sep 2009 16:57:55 -0600
Subject: [PATCH] remove: new module
* modules/remove: New file.
* lib/remove.c: Likewise.
* m4/remove.m4 (gl_FUNC_REMOVE): Likewise.
* m4/stdio_h.m4 (gl_STDIO_H_DEFAULTS): Add witnesses.
* modules/stdio
enhance remove.m4 to work around
that bug too.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 9/1/2009 10:55 AM:
Eric Blake (5):
fchdir: fix off-by-one bug in previous patch
fchdir: simplify error handling, and support dup3
fchdir: use more consistent macro convention
This particular patch
, and test tomorrow.
I'll try and rebase my series before then.
BTW, I appreciate these commentaries.
Have you considered adding something like that to each commit log?
Will do as part of my rebase.
--
Eric Blake
Eric Blake ebb9 at byu.net writes:
I'm arguing that the second program should also report No such
file or directory.
Ah, so for 'foo/', the code should distinguish between ENOENT and ENOTDIR,
based on whether 'foo' exists. I'll update the patch and test accordingly.
I'm taking a step
, I added a test of unlinkat, to make sure
that rmdir bugs don't reappear. Path [1/2] of the previous mail is unchanged,
but here's what replaces [2/2] and a new [3/2]:
From: Eric Blake e...@byu.net
Date: Wed, 16 Sep 2009 13:31:05 -0600
Subject: [PATCH 2/2] rmdir-errno: mark obsolete
. This works
around it:
From: Eric Blake e...@byu.net
Date: Wed, 16 Sep 2009 17:18:28 -0600
Subject: [PATCH] unlinkdir: port to mingw
* m4/unlinkdir.m4 (gl_UNLINKDIR): Add mingw to list of platforms
that refuse anyone to unlink a directory.
Signed-off-by: Eric Blake e...@byu.net
---
ChangeLog
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 9/16/2009 9:11 AM:
I've reached this point in reading the patches.
So far they look fine.
I will read the remainder, and test tomorrow.
I'll try and rebase my series before then.
Now rebased:
git pull git
as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkqyHSMACgkQ84KuGfSFAYAVBACeMwqJDImtaf6ZY7XU5+L6baS
According to Eric Blake on 9/16/2009 10:10 PM:
According to Eric Blake on 9/16/2009 9:11 AM:
I've reached this point in reading the patches.
So far they look fine.
I will read the remainder, and test tomorrow.
I'll try and rebase my series before then.
Now rebased:
git pull git
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Some modules have:
Include:
#include file.h
but most just have:
Include:
file.h
Any objections to a patch that normalizes the outliers to drop #include?
- --
Don't work too hard, make some time for fun as well!
Eric Blake e
Foundation
gives unlimited permission to copy and/or distribute it,
with or without modifications, as long as this notice is preserved.
Yes; this refers to files like *.m4.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE
Eric Blake ebb9 at byu.net writes:
Any objections to a patch that normalizes the outliers to drop #include?
As in the following?
From 2655892372305598ee062e56f30b01c7d90ea178 Mon Sep 17 00:00:00 2001
From: Eric Blake e...@byu.net
Date: Thu, 17 Sep 2009 11:49:36 -0600
Subject: [PATCH] maint
time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkqy2lkACgkQ84KuGfSFAYAcogCeN4PtfHMIK+X
change for consistency.
Once we make that decision, we either need to patch coreutils' NEWS or I
need to fix the regression in gnulib canonicalize.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9
change the
semantics.
It looks like all the other fail=1 listings in the log are variants of the
above two scenarios (missing/ is an intentional change, and dangling/ is a
questionable one).
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP
hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkqzs
of canonicalize/canonicalize-lgpl earlier
this week.
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla
out, gcc's private wchar.h uses va_list before including
stdarg.h.
Can/should we work around this gcc bug, by ensuring that stdarg.h is
always included prior to wchar.h in all configure tests?
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 9/2/2009 1:00 PM:
And here's openat-safer, plus a rework of making fts safer.
Subject: [PATCH 2/2] backupfile, chdir-long, fts, savedir: make safer
* lib/backupfile.c (includes): Use dirent--.h, since
numbered_backup
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 9/19/2009 8:17 AM:
I've tested that, with this patch, './gnulib-tool --with-tests --test
openat' no longer drags in fcntl-safer, but './gnulib-tool --with-tests
--test openat-safer' still passes the new test-openat
for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkq1C98ACgkQ84KuGfSFAYAPyACffCZDHYd93Q9
701 - 800 of 3907 matches
Mail list logo
