Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-25 Thread H. Langos
On Sun, May 24, 2009 at 10:22:17PM +0200, Richard van den Berg wrote: On 5/24/09 2:33 AM, H. Langos wrote: One thing to keep in mind is that the --min-vol-adj and --max-vol-adj now only affect the RVA/RVAD tag information instead of something extracted from RVA2 tags. (I need to update the

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-12 Thread H. Langos
On Sat, May 09, 2009 at 08:34:57PM +0200, H. Langos wrote: Yes. We would leave volume alone and go for soundcheck instead. We would stop using that crude one byte and start using that 32bit dBm value. At least thats what it is supposed to encode. I just greped through my mp3s and I have

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-11 Thread H. Langos
Hi Richard, On Sun, May 10, 2009 at 10:53:42PM +0200, H. Langos wrote: On Sun, May 10, 2009 at 10:35:57AM +0200, Richard van den Berg wrote: Do you want to wait until we have a all of the above working before you commit my current ReplayGain patches to CVS? I hope I get around to

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread Richard van den Berg
On 5/9/09 9:14 AM, Frank Blendinger wrote: I'll talk to the mpd developers to see if they are willing to support RVA2/RGAD and/or APE tags. I used mpd before switching to a Squeezebox. IIRC it is written in perl. If they are using MP3::Info adding APE support is easy; just add an extra

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread Richard van den Berg
On 5/9/09 9:14 AM, Frank Blendinger wrote: [...] gnupod_convert_OGG.pl uses Ogg::Vorbis::Header which may or may not support the RG tags. If you send me an ogg file (privately) that contains RG info I can check (and patch gnupod_convert_OGG.pl). I've sent you a private mail on this,

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread H. Langos
On Fri, May 08, 2009 at 04:16:45PM +0200, Richard van den Berg wrote: On 5/8/09 2:26 PM, H. Langos wrote: Yeap. And if mp3gain can't be changed to do write RVA2 tags by itself, maybe there is a way to make mp3gain only do the analysis and pass its result to a programm that can write those

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread H. Langos
Sorry about that. It's fixed now. cheers -henrik On Sat, May 09, 2009 at 01:04:15PM +0200, Richard van den Berg wrote: On 5/8/09 2:26 PM, H. Langos wrote: BTW: I just added XRVA support as it is a too simple to let it pass. Always test before commit. ;-) Global symbol %hs requires

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread Richard van den Berg
On 5/9/09 4:41 PM, H. Langos wrote: Well, the gain is given in dB relative to a reference level that most times is 83dB (But sometimes might be 89dB. The nasty details are here: http://www.mars.org/mailman/public/mad-dev/2004-February/000993.html ) I assume that mp3gain uses 83dB. But it

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread H. Langos
Hi Frank, On Fri, May 08, 2009 at 12:14:53PM +0200, Frank Blendinger wrote: On Thu 2009-05-07 21:16, Richard van den Berg rich...@vdberg.org proclaimed: On 5/7/09 5:06 PM, H. Langos wrote: What's important is the fact that there seems to be a standard that defines how volume adjustment

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread H. Langos
On Sat, May 09, 2009 at 12:13:01PM +0200, Richard van den Berg wrote: On 5/9/09 9:14 AM, Frank Blendinger wrote: I'll talk to the mpd developers to see if they are willing to support RVA2/RGAD and/or APE tags. I used mpd before switching to a Squeezebox. IIRC it is written in perl. If they

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-08 Thread Richard van den Berg
On 5/8/09 12:14 PM, Frank Blendinger wrote: You might want to take a look at this python script: http://mpd.wikia.com/wiki/Hack:ape2id3.py It will read the ReplayGain settings from APE tags and add it to ID3v2 tags. It has worked without any problems for me so far. That script seems to

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-04-20 Thread H. Langos
Hi Richard, On Fri, Apr 17, 2009 at 11:02:22PM +0200, Richard van den Berg wrote: I'm successfully using gnupod on my iPod video 30GB. Thanks to everyone who contributed to this great tool! I have all my mp3s tagged for ReplayGain volume leveling using mp3gain. This tool adds ReplayGain

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-04-20 Thread Richard van den Berg
Hi Henrik, On Mon, April 20, 2009 15:32, H. Langos wrote: But in the end they both produce one integer number that is applied as a simple scaling factor, right? So the superiority of the the ReplayGain algorithm is something that depends on the software used to produces those tags. Therefore