Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-04-20 Thread Richard van den Berg
Hi Henrik, On Mon, April 20, 2009 15:32, H. Langos wrote: But in the end they both produce one integer number that is applied as a simple scaling factor, right? So the superiority of the the ReplayGain algorithm is something that depends on the software used to produces those tags. Therefore

Re: [Bug-gnupod] DESC field in iTunesDB

2009-05-07 Thread Richard van den Berg
On 5/7/09 1:50 PM, H. Langos wrote: I wasn't aware of a limitation to 40 characters. This seems a rather arbitrary limit imposed on the user by itunes. It doesn't even resemble the original id3v1 comment tag limit as that was 30 characters. ( http://www.id3.org/ID3v1 ) My bad. I took the

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-08 Thread Richard van den Berg
On 5/8/09 12:14 PM, Frank Blendinger wrote: You might want to take a look at this python script: http://mpd.wikia.com/wiki/Hack:ape2id3.py It will read the ReplayGain settings from APE tags and add it to ID3v2 tags. It has worked without any problems for me so far. That script seems to

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread Richard van den Berg
On 5/9/09 9:14 AM, Frank Blendinger wrote: I'll talk to the mpd developers to see if they are willing to support RVA2/RGAD and/or APE tags. I used mpd before switching to a Squeezebox. IIRC it is written in perl. If they are using MP3::Info adding APE support is easy; just add an extra

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread Richard van den Berg
On 5/9/09 9:14 AM, Frank Blendinger wrote: [...] gnupod_convert_OGG.pl uses Ogg::Vorbis::Header which may or may not support the RG tags. If you send me an ogg file (privately) that contains RG info I can check (and patch gnupod_convert_OGG.pl). I've sent you a private mail on this,

Re: [Bug-gnupod] DESC field in iTunesDB

2009-05-09 Thread Richard van den Berg
On 5/9/09 3:52 PM, H. Langos wrote: I forced the lyrics_flag to 1 in mk_mhit() but I still don't see the description. Pressing the center button I still cycle through: volume - position - artwork - rating strange. which generation ipod is that? http://support.apple.com/kb/HT1353

Re: [Bug-gnupod] Patch to support ReplayGain / mp3gain

2009-05-09 Thread Richard van den Berg
On 5/9/09 4:41 PM, H. Langos wrote: Well, the gain is given in dB relative to a reference level that most times is 83dB (But sometimes might be 89dB. The nasty details are here: http://www.mars.org/mailman/public/mad-dev/2004-February/000993.html ) I assume that mp3gain uses 83dB. But it

Re: [Bug-gnupod] DESC field in iTunesDB / lyrics display

2009-05-10 Thread Richard van den Berg
On 5/9/09 5:04 PM, H. Langos wrote: Thats pretty close to what I use (iPod nano (3rd generation)) but since artwork is displayed all the time, there is no separate cycle position for it. What do you mean by all the time? My iPod shows the artwork during the volume and position display, but

Re: [Bug-gnupod] DESC field in iTunesDB / lyrics display

2009-05-10 Thread Richard van den Berg
On 5/10/09 6:00 PM, Richard van den Berg wrote: What do you mean by all the time? My iPod shows the artwork during the volume and position display, but not during the rating one. I just checked, and the artwork is also showing during the rating view. The artwork view on my iPod shows

Re: [Bug-gnupod] gnupod_addsong.pl --artwork without ImageMagick

2009-05-11 Thread Richard van den Berg
On Mon, May 11, 2009 13:21, H. Langos wrote: Artwork handling on the iPod is still kind of dark voodoo to me. I only made a couple of patches to it. You are welcome to improve the error hendling whereever pnupod calls some ImageMagic tools. Probably calling convert somewhere in ArtworkDB.pm

[Bug-gnupod] 4th generation iPod Nano

2009-05-26 Thread Richard van den Berg
I temporarily have access to a 4th generation iPod Nano. During the gnupod_INIT I see a bunch of: /usr/bin/tunes2pod: skipping unknown entry of type '32' Should I see where these warnings come from, or is that harmless? One thing I will look into is the artwork. Setting the model to nano_3g

Re: [Bug-gnupod] 4th generation iPod Nano

2009-05-27 Thread Richard van den Berg
On 27-5-2009 11:48, H. Langos wrote: Here's a commit email regarding new artwork formats for the nano4g from libgpod: http://sourceforge.net/mailarchive/message.php?msg_id=E1LB8Vz-0005Dh-9Y%40d5vjzd1.ch3.sourceforge.com which has been fixed a little later

Re: [Bug-gnupod] 4th generation iPod Nano

2009-05-28 Thread Richard van den Berg
On 5/27/09 11:47 PM, Richard van den Berg wrote: I'll post a full patch including the documentation side later. Here is the patch to make the artwork work for the 4th generation iPod Nano. Cheers, Richard ? .gnupod_version ? Makefile ? autom4te.cache ? config.log ? config.status

Re: [Bug-gnupod] 4th generation iPod Nano

2009-05-28 Thread Richard van den Berg
On 5/27/09 11:48 AM, H. Langos wrote: On Wed, May 27, 2009 at 07:29:11AM +0200, Richard van den Berg wrote: I temporarily have access to a 4th generation iPod Nano. During the gnupod_INIT I see a bunch of: /usr/bin/tunes2pod: skipping unknown entry of type '32' Should I see where

Re: [Bug-gnupod] 4th generation iPod Nano

2009-05-29 Thread Richard van den Berg
On Fri, May 29, 2009 14:16, H. Langos wrote: It certainly wouldn't hurt to put some iTunesDB files away to have some data for verification if somebody sits down to reverse engineer that part of the iTunesDB format. I don't have the Nano anymore (it's on a plane to a sunny destination), but I

Re: [Bug-gnupod] mktunes.pl creates corrupt iTunesDB ?

2009-06-13 Thread Richard van den Berg
The results I got today were not consistent with yesterday (ok iTunesDBs would now be not ok). I learned a lot about the binary format, and figured out that by messing with the ArtworkDB (for the performance tests) the dbid_1 numbers were now out of whack. However, restoring the whole

[Bug-gnupod] Do not stretch artwork

2009-06-14 Thread Richard van den Berg
I might still convert the artwork generation to Image::Magick, but in the meantime here is a patch to not distort the artwork to a square. Instead the aspect is preserved, and white bands are added (left + right or top + bottom) when needed. Cheers, Richard Index: src/ext/ArtworkDB.pm

Re: [Bug-gnupod] Do not stretch artwork

2009-06-15 Thread Richard van den Berg
Are you sure that white is always the best way? I think the ipod touch is generally black and thus back might be better there? Do you want to use the color of the iPod housing? I was going for the background of the iPod UI. On my iPod Video the artwork is never displayed full screen. There is

Re: [Bug-gnupod] mktunes.pl creates corrupt iTunesDB ?

2009-06-16 Thread Richard van den Berg
On 6/16/09 12:44 AM, H. Langos wrote: My first idea now is to strip the iTunesDB of the stuff that is optional. Thanks again for the suggestion, that worked really well. I can now see all my 30415 songs! Whoohoo. :-) These are the mhods that gnupod supports: my %mhod_id = ( title=1,

Re: [Bug-gnupod] Do not stretch artwork

2009-06-16 Thread Richard van den Berg
On 6/15/09 6:01 PM, Christophe Fergeau wrote: The background color is specified in the SysInfoExtended file if you are using/parsing it. Thanks for the suggestion, but gnupod currently doen't parse this file. I think the best thing to do is have an option to select the background color.

Re: [Bug-gnupod] mktunes.pl creates corrupt iTunesDB ?

2009-06-17 Thread Richard van den Berg
On Wed, June 17, 2009 10:41, H. Langos wrote: The code and the naming of variables should express that this is a workaround, not the default. I.e the keepattr would better be named low_ram_attr or shrink_itunes_db or minimal_attr. I'll fix that. I was already thinkign you wouldn't like the

Re: [Bug-gnupod] mktunes.pl creates corrupt iTunesDB ?

2009-06-17 Thread Richard van den Berg
On 6/17/09 10:41 AM, H. Langos wrote: - $mktunes-WriteItunesDB; + $mktunes-WriteItunesDB(Keep=$opts{'keepattr'}); Shouldn't that be : $mktunes-WriteItunesDB( {Keep = $opts{'keepattr'}} ); It turns out it depends on your usage. The form I chose you can used as:

Re: [Bug-gnupod] mktunes.pl creates corrupt iTunesDB ?

2009-06-17 Thread Richard van den Berg
Patch 2 bound the iTunesDB and GNUtunes.xml on id. Since gnupod regenerates the id field on every mktunes run, other software might do the same. So I figured binding them on the path attribute would be a better idea. Cheers, Richard ? .gnupod_version ? Makefile ? autom4te.cache ? config.log

Re: [Bug-gnupod] mktunes.pl creates corrupt iTunesDB ?

2009-06-18 Thread Richard van den Berg
On Thu, June 18, 2009 08:22, H. Langos wrote: Did I mention before that I hate perl? :-) In about every other post to this list. ;-) To me, the things about perl that I sometimes hate let me very quickly write code that does what I want at other times. When I started with the tunes2pod code I

Re: [Bug-gnupod] mktunes.pl creates corrupt iTunesDB ?

2009-06-19 Thread Richard van den Berg
On Fri, June 19, 2009 10:27, H. Langos wrote: Good thing you mention tunes2pod. Please try to make your changes optional. Something like a --merge option to express that you are going to merge iTunesDB and GNUtunesDB.xml I thought about this myself, but we would have to make this a parameter

Re: [Bug-gnupod] mktunes.pl creates corrupt iTunesDB ?

2009-06-19 Thread Richard van den Berg
On Fri, June 19, 2009 11:07, H. Langos wrote: Maybe the merge code should only be active if your memory saving feature is active? That makes a lot of sense, and it easy to implement. :-) I'll post another patch tonight. Cheers, Richard ___

Re: [Bug-gnupod] mktunes.pl creates corrupt iTunesDB ?

2009-06-19 Thread Richard van den Berg
On 6/19/09 11:07 AM, H. Langos wrote: Maybe the merge code should only be active if your memory saving feature is active? Here is the new patch that does just that. I love git, it's super fast. :-) Cheers, Richard diff --git a/doc/gnupodrc.example b/doc/gnupodrc.example index

Re: [Bug-gnupod] mktunes.pl creates corrupt iTunesDB ?

2009-07-01 Thread Richard van den Berg
On Wed, July 1, 2009 16:13, Jacinta Richardson wrote: I imagine that the author didn't intend that effect of calling the subroutine that way. Absolutely right. I suspect it's a matter of laziness. I claim ignorance. I didn't know there was a fundamental difference between the two ways of

[Bug-gnupod] Configure as_echo fix

2009-07-03 Thread Richard van den Berg
Configure has always printed -n strings on my MacBook. I fixed that by using as_echo and as_echo_n. See my patch on the rvdb/configure-fix branch. Cheers, Richard ___ Bug-gnupod mailing list Bug-gnupod@nongnu.org

[Bug-gnupod] Text::CharWidth

2009-07-03 Thread Richard van den Berg
There is no test for Text::CharWidth in configure required by gnupod-delete. I'm not sure if it should be a required or an optional module. Cheers, Richard ___ Bug-gnupod mailing list Bug-gnupod@nongnu.org

Re: [Bug-gnupod] Configure as_echo fix

2009-07-03 Thread Richard van den Berg
On 7/3/09 9:59 PM, H. Langos wrote: Which mac os version did you use? OS X 10.5.7 The default Mac OS X sh was originally Zsh; it was changed to Bash in Mac OS X 10.2. I definitely use bash. If it wasn't the default, I would have changed it. :-) Do you happen to know if

Re: [Bug-gnupod] mktunes.pl creates corrupt iTunesDB ?

2009-07-03 Thread Richard van den Berg
On 7/2/09 3:43 PM, H. Langos wrote: Could you check if it still does what it was is supposed to do? :-) It looks fine, and my iPod still works, and didn't even have to reboot it for it to show my 30640 files. :-) I merged the low_ram branch into master yesterday evening but I wanted to

Re: [Bug-gnupod] Configure as_echo fix

2009-07-03 Thread Richard van den Berg
On 7/3/09 10:55 PM, H. Langos wrote: But it seems that autoconf itself is not covered by the posix standard. I assumed you already knew that. :-) Where did you find the hint to replace echo $ECHO_N by $as_echo_n? From the generated configure script. I wouldn't be surprised if the