bug#43527: [PATCH] grep: avoid unneeded compilation of regex

2020-09-22 Thread Norihiro Tanaka
On Tue, 22 Sep 2020 16:25:06 -0700 Jim Meyering wrote: > Oh! Good timing. I was about to make a new snapshot. > Do you happen to have a test case handy that demonstrates the failure? I added test case to previous patch. By the way, I found the following bug in making the test case, and it's

bug#43527: [PATCH] grep: avoid unneeded compilation of regex

2020-09-22 Thread Jim Meyering
On Tue, Sep 22, 2020 at 3:57 PM Norihiro Tanaka wrote: > On Tue, 22 Sep 2020 08:50:03 -0700 > Jim Meyering wrote: > > > On Tue, Sep 22, 2020 at 7:54 AM Norihiro Tanaka wrote: > > > On Mon, 21 Sep 2020 17:33:25 -0700 > > > Jim Meyering wrote: > > ... > > > > Here are the two patches (tested on

bug#43527: [PATCH] grep: avoid unneeded compilation of regex

2020-09-22 Thread Norihiro Tanaka
On Tue, 22 Sep 2020 08:50:03 -0700 Jim Meyering wrote: > On Tue, Sep 22, 2020 at 7:54 AM Norihiro Tanaka wrote: > > On Mon, 21 Sep 2020 17:33:25 -0700 > > Jim Meyering wrote: > ... > > > Here are the two patches (tested on top of a third that updates to > > > latest gnulib). I'll await an

bug#34288: Mention how to trigger ':' without filemane

2020-09-22 Thread 積丹尼 Dan Jacobson
OK closing, because I don't exactly remember my main point either. > "PE" == Paul Eggert writes: PE> On 1/31/19 3:42 PM, 積丹尼 Dan Jacobson wrote: PE> Unfortunately I don't understand this bug report. I don't know what PE> the "it" is that people would want to figure out.

bug#23267: suggestion: silently ignore EPIPE errors when SIGPIPE is set to 'ignore'

2020-09-22 Thread Paul Eggert
I'm cleaning up old grep bug reports and am closing this one as wontfix.

bug#23562: grep seems to write some error messages to stdout data stream --- shouldn't it be to stderr?

2020-09-22 Thread Paul Eggert
On 5/16/16 11:03 PM, John Refling wrote: error messages should NEVER be injected into the same stream as the users input / output data, firstly because it corrupts the data, and secondly if the output is redirected, the user will never see the error message. On further thought (and after

bug#30643: Mention . won't match illegal characters

2020-09-22 Thread Paul Eggert
$ man grep says The period . matches any single character. OK but it should also mention that illegal characters for the current locale will never be matched by ".". This has been done, by adding "It is unspecified whether it matches an encoding error" as part of a fix for Bug#30643.

bug#34288: Mention how to trigger ':' without filemane

2020-09-22 Thread Paul Eggert
On 1/31/19 3:42 PM, 積丹尼 Dan Jacobson wrote: Regarding (info "(grep) Context Line Control") To get exactly this great output $ seq 33|grep --context=4 --label= --with-filename 5$ without further tips on the page, the user won't figure it out. Even worse, if the input is from a file, not stdin,

bug#35339: Say what buffering is not --line-buffered

2020-09-22 Thread Paul Eggert
On 4/20/19 4:41 AM, 積丹尼 Dan Jacobson wrote: ‘--line-buffered’ Use line buffering on output. This can cause a performance penalty. OK, but say what will happen if one doesn't use this. Paragraph buffering? Page buffering? Thanks for mentioning this. I installed the attached

bug#43527: [PATCH] grep: avoid unneeded compilation of regex

2020-09-22 Thread Jim Meyering
On Tue, Sep 22, 2020 at 7:54 AM Norihiro Tanaka wrote: > On Mon, 21 Sep 2020 17:33:25 -0700 > Jim Meyering wrote: ... > > Here are the two patches (tested on top of a third that updates to > > latest gnulib). I'll await an 'ok' from Norihiro Tanaka before > > pushing, since commit-log metadata

bug#43527: [PATCH] grep: avoid unneeded compilation of regex

2020-09-22 Thread Norihiro Tanaka
On Mon, 21 Sep 2020 17:33:25 -0700 Jim Meyering wrote: > On Sun, Sep 20, 2020 at 6:34 PM Jim Meyering wrote: > > > > On Sun, Sep 20, 2020 at 12:17 AM Norihiro Tanaka wrote: > > > Hi, > > > Performace for as following case is fixed in bug#43040. > > > > > > $ yes 0 | head -10 | sed