Re: [PATCH] Drop the auto keyword

2013-11-29 Thread Justus Winter
Quoting Justus Winter (2013-11-29 01:02:40) Drop the auto keyword from the generated source code. auto is the default storage type for variables anyway and it is customary to omit it. Hm, this is already in, please ignore this. It slipped in while doing git send-email. Justus

[PATCH] libdiskfs: improve the diskfs_demuxer function

2013-11-29 Thread Justus Winter
Handle multiple request types as recommended by the Mach Server Writer's Guide section 4, subsection Handling Multiple Request Types. This avoids initializing the reply message in every X_server function. The reply message has already been properly initialized in libports, so there is no need to

Improving the demuxer functions

2013-11-29 Thread Justus Winter
Hi :) the way our demuxer functions chain the X_server functions is initializing the reply message over and over again. This can be avoided by following the recommendations of the Mach Server Writer's Guide. A patch for libdiskfs is sent as a follow-up. To improve the situation further, I

[PATCH 02/68] ddb/db_input.c: add comment after endif

2013-11-29 Thread Marin Ramesa
* ddb/db_input.c [DB_HISTORY_SIZE]: Add comment after endif. --- ddb/db_input.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ddb/db_input.c b/ddb/db_input.c index 8f875ad..7fee8fd 100644 --- a/ddb/db_input.c +++ b/ddb/db_input.c @@ -133,7 +133,7 @@ db_delete_line()

[PATCH 05/68] ddb/db_run.c: add comment after endif

2013-11-29 Thread Marin Ramesa
* ddb/db_run.c [FIXUP_PC_AFTER_BREAK]: Add comment after endif. --- ddb/db_run.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ddb/db_run.c b/ddb/db_run.c index acd5586..330b41b 100644 --- a/ddb/db_run.c +++ b/ddb/db_run.c @@ -81,7 +81,7 @@ db_stop_at_pc(is_breakpoint,

[PATCH 01/68] ddb/db_command.c: remove forward declarations

2013-11-29 Thread Marin Ramesa
* ddb/db_command.c: Include machine/db_interface.h. (db_help_cmd, db_stack_trace_cmd): Remove forward declarations. * ddb/db_command.h (db_help_cmd): Add prototype. * i386/i386/db_interface.h (db_stack_trace_cmd): Add prototype. --- ddb/db_command.c | 3 +-- ddb/db_command.h | 2

gnumach code cleanup

2013-11-29 Thread Marin Ramesa
I've broken up my previous patch into seperate git commits and added the removal of forward declarations. The result is a series of 68 patches. I am sorry of the length of the series causes any trouble. Large number of forward declarations have been turned into prototypes in header files and all

[PATCH 04/68] ddb/db_output.c: remove forward declaration

2013-11-29 Thread Marin Ramesa
* ddb/db_output.c (db_check_interrupt): Remove forward declaration. * ddb/db_output.h (db_check_interrupt): Add prototype. --- ddb/db_output.c | 2 -- ddb/db_output.h | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/ddb/db_output.c b/ddb/db_output.c index c08db6f..b63813b

[PATCH 07/68] ddb: new header file db_aout.h

2013-11-29 Thread Marin Ramesa
* Makefrag.am: Include ddb/db_aout.h. * ddb/db_aout.c: Include ddb/db_aout.h. * ddb/db_aout.h: New file. Add copyright. [_DDB_DB_AOUT_H_]: Add ifndef. Include ddb/db_sym.h. Include machine/db_machdep.h. (aout_db_line_at_pc, aout_db_lookup, aout_db_search_symbol, aout_db_symbol_values): Add

[PATCH 12/68] ddb/db_trap.c: remove forward declarations

2013-11-29 Thread Marin Ramesa
* ddb/db_run.h (db_restart_at_pc, db_stop_at_pc): Add prototypes. * ddb/db_trap.c (db_restart_at_pc, db_stop_at_pc): Remove forward declarations. Include ddb/db_run.h. --- ddb/db_run.h | 10 ++ ddb/db_trap.c | 4 +--- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git

[PATCH 14/68] device/device_init.c: remove forward declarations

2013-11-29 Thread Marin Ramesa
* device/dev_lookup.c: Include device/ds_routines.h. * device/device_init.c: Include device/ds_routines.h. Include device/net_io.h. (mach_device_init, dev_lookup_init, net_io_init, device_pager_init, io_done_thread, net_thread): Remove forward declarations. * device/ds_routines.h

[PATCH 08/68] ddb/db_sym.c: remove useless forward declarations without definitions

2013-11-29 Thread Marin Ramesa
* ddb/db_sym.c (coff_db_sym_init, coff_db_line_at_pc, db_sym_t coff_db_lookup, coff_db_search_symbol, coff_db_symbol_values): Remove forward declarations. (x_db): Modify field definition. --- ddb/db_sym.c | 9 - 1 file changed, 9 deletions(-) diff --git a/ddb/db_sym.c b/ddb/db_sym.c

[PATCH 06/68] ddb/db_aout.c: trivial stylistic fix for consistency

2013-11-29 Thread Marin Ramesa
* ddb/db_aout.c: Trivial stylistic fix for consistency. --- ddb/db_aout.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ddb/db_aout.c b/ddb/db_aout.c index a36ca0e..5480325 100644 --- a/ddb/db_aout.c +++ b/ddb/db_aout.c @@ -500,7 +500,7 @@ aout_db_line_at_pc(stab, sym,

[PATCH 09/68] ddb/db_sym.c: fix argument list

2013-11-29 Thread Marin Ramesa
* ddb/db_sym.c (dummy_db_free_symbol): Fix argument list. --- ddb/db_sym.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ddb/db_sym.c b/ddb/db_sym.c index 9d64f5b..fb0cd96 100644 --- a/ddb/db_sym.c +++ b/ddb/db_sym.c @@ -507,7 +507,7 @@ void db_free_symbol(db_sym_t s) *

[PATCH 18/68] i386/i386/io_perm.c: remove forward declaration

2013-11-29 Thread Marin Ramesa
* i386/i386/io_perm.c: Include pcb.h. (update_ktss_iopb): Remove forward declaration. * i386/i386/pcb.h (update_ktss_iopb): Add prototype. --- i386/i386/io_perm.c | 6 +- i386/i386/pcb.h | 2 ++ 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/i386/i386/io_perm.c

[PATCH 19/68] i386/i386/ldt.c: remove useless forward declaration without definition

2013-11-29 Thread Marin Ramesa
* i386/i386/ldt.c (syscall): Remove forward declaration. (syscall): New variable. --- i386/i386/ldt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/i386/i386/ldt.c b/i386/i386/ldt.c index 43b9efb..37f09fb 100644 --- a/i386/i386/ldt.c +++ b/i386/i386/ldt.c @@ -37,8 +37,6

[PATCH 17/68] i386/i386/fpu.c: remove (#if 1)

2013-11-29 Thread Marin Ramesa
* i386/i386/fpu.c: Remove (#if 1). --- i386/i386/fpu.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/i386/i386/fpu.c b/i386/i386/fpu.c index 4e3ab57..a850203 100644 --- a/i386/i386/fpu.c +++ b/i386/i386/fpu.c @@ -782,7 +782,6 @@ ASSERT_IPL(SPL0); memset(ifps, 0, sizeof *ifps);

[PATCH 11/68] ddb/db_command.c: remove useless forward declaration without definition

2013-11-29 Thread Marin Ramesa
* ddb/db_command.c (ddb_display): Remove forward declaration. Remove ddb_display call. --- ddb/db_command.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/ddb/db_command.c b/ddb/db_command.c index 833b720..b596e52 100644 --- a/ddb/db_command.c +++ b/ddb/db_command.c @@

[PATCH 21/68] kern: new header file exception.h

2013-11-29 Thread Marin Ramesa
* Makefrag.am: Include kern/exception.h. * i386/i386/trap.c: Include kern/exception.h. (exception, thread_exception_return): Remove forward declarations. * kern/exception.c: Include kern/exception.h. (exception, exception_try_task, exception_no_server, exception_raise, exception_parse_reply,

[PATCH 24/68] i386/i386at/conf.c: remove forward declarations

2013-11-29 Thread Marin Ramesa
* i386/Makefrag.am: Include i386/i386at/model_dep.h and i386/i386at/mem.h. * i386/i386at/com.h (comgetstat, comsetstat): Declare as extern. (comopen, comclose, comread, comwrite, comportdeath): Add prototypes. * i386/i386at/conf.c: Include kern/mach_clock.h and i386at/model_dep.h. (timeopen,

[PATCH 15/68] i386/i386/db_trace.c: remove forward declaration

2013-11-29 Thread Marin Ramesa
* i386/i386/db_interface.h: Include ddb/db_variables.h. (db_i386_reg_value): Add prototype. * i386/i386/db_trace.c (db_i386_reg_value): Remove forward declaration. --- i386/i386/db_interface.h | 8 i386/i386/db_trace.c | 7 --- 2 files changed, 8 insertions(+), 7 deletions(-)

[PATCH 44/68] kern: remove forward declaration

2013-11-29 Thread Marin Ramesa
* kern/xpr.c (db_printf): Remove forward declaration. [MACH_KDB] Include ddb/db_output.h. --- kern/xpr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kern/xpr.c b/kern/xpr.c index b482a12..92b253c 100644 --- a/kern/xpr.c +++ b/kern/xpr.c @@ -132,9 +132,8 @@ void

[PATCH 22/68] kern/exception.c: remove forward declarations

2013-11-29 Thread Marin Ramesa
* i386/i386/trap.h (thread_kdb_return): Add prototype. * kern/exception.c (thread_kdb_return, db_printf): Remove forward declarations. Include machine/trap.h. Include ddb/db_output.h. --- i386/i386/trap.h | 3 +++ kern/exception.c | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff

[PATCH 13/68] ddb/db_variables.c: remove forward declarations

2013-11-29 Thread Marin Ramesa
* ddb/db_task_thread.h: Include ddb/db_variables.h. (db_set_default_thread, db_get_task_thread): Add prototypes. * ddb/db_variables: Include ddb/db_macro.h. (db_set_default_thread, db_get_task_thread, db_arg_variable): Remove forward declarations. --- ddb/db_task_thread.h | 15 +++

[PATCH 23/68] i386/i386at/autoconf.c, com.c, lpr.c: remove forward declarations

2013-11-29 Thread Marin Ramesa
* i386/i386/autoconf.c (comintr, lprintr): Remove forward declarations. Include i386at/com.h. Include i386at/lprreg.h. * i386/i386at/com.c (comprobe, commctl, comstart, comstop, comattach, comintr, comgetstat, comsetstat): Remove forward declarations. * i386/i386at/com.h: Include device/tty.h.

[PATCH 31/68] ipc/ipc_kmsg.c: remove forward declarations

2013-11-29 Thread Marin Ramesa
* ipc/ipc_kmsg.c (copyinmap, copyoutmap, ipc_msg_print): Remove forward declarations. * ipc/ipc_kmsg.h (ipc_msg_print): Add prototype. --- ipc/ipc_kmsg.c | 4 ipc/ipc_kmsg.h | 2 ++ 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/ipc/ipc_kmsg.c b/ipc/ipc_kmsg.c index

[PATCH 38/68] kern/sched_prim.c: remove forward declarations

2013-11-29 Thread Marin Ramesa
* kern/sched_prim.c (set_pri, do_thread_scan, choose_pset_thread, checkrq, thread_check): Remove forward declarations. * kern/sched_prim.h (set_pri, do_thread_scan, choose_pset_thread, checkrq, thread_check): Add prototypes. --- kern/sched_prim.c | 10 -- kern/sched_prim.h | 9

[PATCH 56/68] Remove unnecessary files

2013-11-29 Thread Marin Ramesa
* i386/Makefrag.am: Don't include i386/i386/kttd_interface.c. Don't include i386/i386/kttd_machdep.h. Don't include i386/include/mach/i386/rpc.h. * i386/i386/kttd_interface.c: Remove file. * i386/i386/kttd_machdep.h: Remove file. * i386/i386/time_stamp.h: Remove file. *

[PATCH 16/68] i386/i386/fpu.c, trap.c: remove forward declarations

2013-11-29 Thread Marin Ramesa
* i386/i386/fpu.c: Include i386/trap.h. (void i386_exception, fp_save, fp_load): Remove forward declaration. * i386/i386/trap.c (void i386_exception): Remove forward declaration. * i386/i386/trap.h (void i386_exception): Add prototype. --- i386/i386/fpu.c | 6 +- i386/i386/trap.c | 2 --

[PATCH 29/68] i386/i386at/pic_isa.c: remove forward declaration

2013-11-29 Thread Marin Ramesa
* i386/i386at/pic_isa.c: Include kern/mach_clock.h. (hardclock): Remove forward declaration. * kern/mach_clock.h: Include machine/thread.h. (hardclock): Add prototype. --- i386/i386at/pic_isa.c | 2 +- kern/mach_clock.h | 9 - 2 files changed, 9 insertions(+), 2 deletions(-) diff

[PATCH 30/68] i386/intel/pmap.c: remove forward declarations

2013-11-29 Thread Marin Ramesa
* i386/intel/pmap.c (pmap_remove_range, signal_cpus): Remove forward declarations. * i386/intel/pmap.h (pmap_remove_range, signal_cpus): Add prototypes. --- i386/intel/pmap.c | 5 - i386/intel/pmap.h | 14 ++ 2 files changed, 14 insertions(+), 5 deletions(-) diff --git

[PATCH 64/68] ipc/mach_port.c: remove forward declaration

2013-11-29 Thread Marin Ramesa
* ipc/mach_port.c (mach_port_get_receive_status): Remove forward declaration. * ipc/mach_port.h (mach_port_get_receive_status): Add prototype. --- ipc/mach_port.c | 2 -- ipc/mach_port.h | 6 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/ipc/mach_port.c b/ipc/mach_port.c

[PATCH 40/68] kern/syscall_subr.c: remove forward declaration

2013-11-29 Thread Marin Ramesa
* kern/syscall_subr.c (thread_depress_priority): Remove forward declaration. * kern/syscall_subr.h (thread_depress_priority): Add prototype. --- kern/syscall_subr.c | 3 --- kern/syscall_subr.h | 1 + 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/kern/syscall_subr.c

[PATCH 26/68] i386/i386at/kd_event.c: remove forward declarations

2013-11-29 Thread Marin Ramesa
* i386/i386at/kd_event.c (kbd_enqueue, X_kdb_enter_init, X_kdb_exit_init, kbd_read_done): Remove forward declarations. * i386/i386at/kd_event.h (kbd_enqueue, X_kdb_enter_init, X_kdb_exit_init, kbd_read_done): Add prototypes. --- i386/i386at/kd_event.c | 8 i386/i386at/kd_event.h | 7

[PATCH 43/68] kern/thread.c: remove forward declaration

2013-11-29 Thread Marin Ramesa
* i386/i386/pcb.h (pcb_module_init): Add prototype. * kern/thread.c (pcb_module_init): Remove forward declaration. --- i386/i386/pcb.h | 2 ++ kern/thread.c | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/i386/i386/pcb.h b/i386/i386/pcb.h index 4aad0b2..b2e5f07 100644

[PATCH 27/68] i386/i386at/kd_mouse.c: remove forward declarations

2013-11-29 Thread Marin Ramesa
* i386/i386at/kd_mouse.c (mouseintr, mouse_enqueue, mouse_read_done): Remove forward declarations. (mouseintr): Define argument type. * i386/i386at/kd_mouse.h (mouseintr, mouse_enqueue, mouse_read_done): Add prototypes. --- i386/i386at/kd_mouse.c | 6 +- i386/i386at/kd_mouse.h | 4 2

[PATCH 60/68] device/net_io.c: remove forward declarations

2013-11-29 Thread Marin Ramesa
* device/net_io.c (net_rcv_port, net_hash_entry, net_hash_header): Move structs to net_io.h. (net_do_filter, bpf_do_filter, hash_ent_remove, net_free_dead_infp, net_free_dead_entp, bpf_validate, bpf_eq, net_add_q_info, bpf_match): Remove forward declarations. * device/net_io.h (net_do_filter,

[PATCH 52/68] vm/vm_user.c: remove forward declaration

2013-11-29 Thread Marin Ramesa
* vm/vm_user.c (vm_map_machine_attribute): Remove forward declaration. --- vm/vm_user.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/vm/vm_user.c b/vm/vm_user.c index c18baf2..f721e87 100644 --- a/vm/vm_user.c +++ b/vm/vm_user.c @@ -224,8 +224,6 @@ kern_return_t vm_machine_attribute(map,

[PATCH 47/68] vm/vm_fault.c: remove forward declaration

2013-11-29 Thread Marin Ramesa
* vm/vm_fault.c (vm_fault_wire_fast): Remove forward declaration. * vm/vm_fault.h (vm_fault_wire_fast): Add prototype. --- vm/vm_fault.c | 2 -- vm/vm_fault.h | 6 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/vm/vm_fault.c b/vm/vm_fault.c index d0c7f96..96c8387 100644

[PATCH 32/68] ipc/ipc_table.c: remove forward declaration

2013-11-29 Thread Marin Ramesa
* ipc/ipc_table.c (ipc_table_fill): Remove forward declaration. * ipc/ipc_table.h (ipc_table_fill): Add prototype. --- ipc/ipc_table.c | 9 - ipc/ipc_table.h | 6 ++ 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/ipc/ipc_table.c b/ipc/ipc_table.c index

[PATCH 49/68] vm/vm_map.c: remove forward declarations

2013-11-29 Thread Marin Ramesa
* vm/vm_map.c (_vm_map_clip_start, _vm_map_copy_clip_start, _vm_map_clip_end, _vm_map_copy_clip_end): Remove forward declarations. * vm/vm_map.h (_vm_map_clip_end): Correct prototype. --- vm/vm_map.c | 4 vm/vm_map.h | 5 - 2 files changed, 4 insertions(+), 5 deletions(-) diff --git

[PATCH 41/68] kern/syscall_sw.c: remove forward declarations

2013-11-29 Thread Marin Ramesa
* kern/eventcount.h (evc_wait_clear): Add prototype. * kern/ipc_mig.h: Include device/device_types.h. (syscall_vm_map, syscall_vm_allocate, syscall_vm_deallocate, syscall_task_create, syscall_task_terminate, syscall_task_suspend, syscall_task_set_special_port, syscall_mach_port_allocate,

[PATCH 36/68] kern/ipc_mig.c: remove forward declarations

2013-11-29 Thread Marin Ramesa
* device/ds_routines.h (ds_device_write_trap, ds_device_writev_trap): Add prototypes. * kern/ipc_mig.c (ds_device_write_trap, ds_device_writev_trap): Remove forward declarations. --- device/ds_routines.h | 13 + kern/ipc_mig.c | 4 2 files changed, 13 insertions(+), 4

[PATCH 57/68] Remove MACH_TTD code

2013-11-29 Thread Marin Ramesa
* device/net_io.c [MACH_TTD]: Remove code. * i386/i386/trap.c [MACH_TTD]: Likewise. * i386/i386at/autoconf.c [MACH_TTD]: Likewise. --- device/net_io.c| 29 - i386/i386/trap.c | 28 i386/i386at/autoconf.c | 7 --- 3 files

[PATCH 37/68] kern/processor.c: remove forward declarations

2013-11-29 Thread Marin Ramesa
* kern/processor.c (quantum_set, pset_init, processor_init): Remove forward declarations. * kern/processor.h (quantum_set, pset_init, processor_init): Add prototypes. --- kern/processor.c | 7 --- kern/processor.h | 4 +++- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git

[PATCH 65/68] kern/mach_clock.c: remove forward declaration

2013-11-29 Thread Marin Ramesa
* Makefrag.am: Include kern/priority.h. * kern/mach_clock.c (thread_quantum_update): Remove forward declaration. Include kern/priority.h. * kern/priority.h: New file. Add copyright. [_KERN_PRIORITY_H_]: Add ifndef. (thread_quantum_update): Add prototype. --- Makefrag.am | 1 +

[PATCH 62/68] i386/i386at/model_dep.c: remove forward declaration

2013-11-29 Thread Marin Ramesa
* i386/i386at/model_dep.c (init_alloc_aligned): Remove forward declaration. * i386/i386at/model_dep.h (init_alloc_aligned): Add prototype. --- i386/i386at/model_dep.c | 2 -- i386/i386at/model_dep.h | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/i386/i386at/model_dep.c

[PATCH 50/68] vm/vm_pageout.c: remove forward declarations

2013-11-29 Thread Marin Ramesa
* vm/vm_pageout.c (vm_pageout_continue, vm_pageout_scan_continue): Remove forward declarations. * vm/vm_pageout.h (vm_pageout_continue, vm_pageout_scan_continue): Add prototypes. --- vm/vm_pageout.c | 3 --- vm/vm_pageout.h | 2 ++ 2 files changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 45/68] ipc/ipc_kmsg.h: update comment

2013-11-29 Thread Marin Ramesa
Struct ipc_kmsg_queue is not defined in kern/thread.h. * ipc/ipc_kmsg.h: Update comment. --- ipc/ipc_kmsg.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ipc/ipc_kmsg.h b/ipc/ipc_kmsg.h index fdc7d2d..6495e01 100644 --- a/ipc/ipc_kmsg.h +++ b/ipc/ipc_kmsg.h @@ -140,8

[PATCH 42/68] kern/task.c: remove forward declarations

2013-11-29 Thread Marin Ramesa
* ipc/ipc_mqueue.h: Include ipc/ipc_kmsg_queue.h. * kern/ipc_kobject.h: Move includes into ifndef. * kern/syscall_emulation.h: Include kern/task.h. (eml_init, eml_task_reference, eml_task_deallocate): Add prototypes. * kern/task.c: Include kern/syscall_emulation.h. (eml_init, eml_task_reference,

[PATCH 59/68] Type definition

2013-11-29 Thread Marin Ramesa
* i386/i386/pic.c (intnull): Define argument type. (prtnull): Likewise. * i386/i386at/com.c (compr_addr): Likewise. * i386/i386at/kd.c (kd_cmdreg_write, kd_kbd_magic): Likewise. * i386/i386at/kd_mouse.c (init_mouse_hw): Likewise. * ipc/mach_port.c (sact_count): Declare void argument list and

[PATCH 51/68] vm/vm_resident.c: correct comment

2013-11-29 Thread Marin Ramesa
This is vm_resident.c, not vm_page.c. * vm/vm_resident.c: Correct comment. --- vm/vm_resident.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vm/vm_resident.c b/vm/vm_resident.c index fbd4275..f0f31f6 100644 --- a/vm/vm_resident.c +++ b/vm/vm_resident.c @@ -27,7 +27,7 @@

[PATCH 61/68] i386/i386at/kd.c: remove forward declarations

2013-11-29 Thread Marin Ramesa
* i386/i386at/kd.c (kd_getdata, state2leds): Remove forward declarations. * i386/i386at/kd.h (kd_getdata, state2leds): Add prototypes. --- i386/i386at/kd.c | 6 -- i386/i386at/kd.h | 3 +++ 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/i386/i386at/kd.c b/i386/i386at/kd.c

[PATCH 46/68] kern/ipc_kobject.c: remove forward declarations

2013-11-29 Thread Marin Ramesa
* i386/i386/machine_routines.h: Define mig_external. (mach_server_routine, mach_port_server_routine, mach_host_server_routine, device_server_routine, device_pager_server_routine, mach4_server_routine, gnumach_server_routine, mach_debug_server_routine, MACHINE_SERVER_ROUTINE): Add prototypes. *

[PATCH 34/68] kern/bootstrap.c: remove forward declarations

2013-11-29 Thread Marin Ramesa
* i386/i386/pcb.h: Include mach/thread_status.h. Include machine/thread.h. * kern/bootstrap.c: Include machine/pcb.h. (user_stack_low, set_user_regs): Remove forward declarations. --- i386/i386/pcb.h | 2 ++ kern/bootstrap.c | 4 +--- 2 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH 33/68] ipc/mach_msg.c: remove forward declarations

2013-11-29 Thread Marin Ramesa
* ipc/mach_msg.c: Include kern/exception.h. (exception_raise_continue, exception_raise_continue_fast): Remove forward declarations. * kern/exception.h: Include ipc/ipc_types.h. Include ipc/ipc_kmsg.h. --- ipc/mach_msg.c | 4 +--- kern/exception.h | 3 +++ 2 files changed, 4 insertions(+), 3

[PATCH 66/68] ddb/db_variables.c: fix near initialization

2013-11-29 Thread Marin Ramesa
* ddb/db_task_thread.c (db_set_default_thread): New parameter. * ddb/db_task_thread.h (db_set_default_thread): Likewise. --- ddb/db_task_thread.c | 3 ++- ddb/db_task_thread.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/ddb/db_task_thread.c b/ddb/db_task_thread.c

[PATCH 63/68] ipc/ipc_entry.c: remove forward declaration

2013-11-29 Thread Marin Ramesa
* ipc/ipc_entry.c (db_ipc_object_by_name): Remove forward declaration. * ipc/ipc_entry.h (db_ipc_object_by_name): Add prototype. --- ipc/ipc_entry.c | 4 ipc/ipc_entry.h | 5 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/ipc/ipc_entry.c b/ipc/ipc_entry.c index

[PATCH 58/68] kern/time_stamp.c: remove multimax code

2013-11-29 Thread Marin Ramesa
* kern/time_stamp.c [multimax]: Remove code. --- kern/time_stamp.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/kern/time_stamp.c b/kern/time_stamp.c index f0df0eb..1d57eb6 100644 --- a/kern/time_stamp.c +++ b/kern/time_stamp.c @@ -32,27 +32,15 @@ /* * ts.c -

[PATCH 25/68] i386/i386at/kd.c: remove forward declarations

2013-11-29 Thread Marin Ramesa
* i386/i386at/kd.c (kd_enqsc, kdcheckmagic, do_modifier, bmpch2bit, bmppaintcsr, bit2fbptr): Remove forward declarations. * i386/i386at/kd.h: Include device/buf.h. Include i386at/kdsoft.h. (kdcheckmagic, do_modifier, bmpch2bit, bmppaintcsr, bit2fbptr): Add prototypes. * i386/i386at/kd_event.h

[PATCH 28/68] i386/i386at: remove forward declarations

2013-11-29 Thread Marin Ramesa
* Makefrag.am: Include kern/startup.h. * i386/i386at/model_dep.c: Include kern/startup.h. Include i386at/model_dep.h. (setup_main, halt_all_cpus, halt_cpu, inittodr): Remove forward declarations. * i386/i386at/model_dep.h (halt_all_cpus, halt_cpu, inittodr): Add prototypes. * kern/startup.h: New

[PATCH 55/68] Declare void argument lists

2013-11-29 Thread Marin Ramesa
Declare void argument lists and further normalize whitespace. --- ddb/db_break.c | 8 +++--- ddb/db_command.c | 4 +-- ddb/db_command.h | 2 +- ddb/db_cond.c| 2 +- ddb/db_examine.c | 4 +-- ddb/db_input.c | 4 +-- ddb/db_macro.c

Re: [PATCH 40/68] kern/syscall_subr.c: remove forward declaration

2013-11-29 Thread Ivan Shmakov
Marin Ramesa m...@hi.t-com.hr writes: […] --- a/kern/syscall_subr.h +++ b/kern/syscall_subr.h @@ -37,5 +37,6 @@ extern int thread_switch(mach_port_t, int, mach_msg_timeout_t); extern void thread_depress_timeout(thread_t); extern kern_return_t thread_depress_abort(thread_t);

[PATCH 39/68] kern/startup.c: remove forward declarations

2013-11-29 Thread Marin Ramesa
* Makefrag.am: Include kern/bootstrap.h. Include vm/vm_init.h. Include device/device_init.h. * device/device_init.h: New file. Add copyright. [_DEVICE_DEVICE_INIT_H_]: Add ifndef. (device_service_create): Add prototype. * i386/i386/mp_desc.h (start_other_cpus): Add prototype. * kern/bootstrap.h:

Re: [PATCH 19/68] i386/i386/ldt.c: remove useless forward declaration without definition

2013-11-29 Thread Ivan Shmakov
Marin Ramesa m...@hi.t-com.hr writes: * i386/i386/ldt.c (syscall): Remove forward declaration. (syscall): New variable. […] #include ldt.h -extern int syscall(); - #ifdef MACH_PV_DESCRIPTORS /* It is actually defined in xen_boothdr.S */ extern @@ -60,6 +58,7 @@

Re: [PATCH 19/68] i386/i386/ldt.c: remove useless forward declaration without definition

2013-11-29 Thread Marin Ramesa
On 29.11.2013 23:52:00, Ivan Shmakov wrote: Correct me if I’m wrong, but doesn’t it replace a pointer to an global (external) syscall () function with a pointer to a local variable? I don’t seem to understand how the logic is preserved in this change. The function syscall() doesn't

Re: [PATCH 19/68] i386/i386/ldt.c: remove useless forward declaration without definition

2013-11-29 Thread Samuel Thibault
Marin Ramesa, le Sat 30 Nov 2013 00:22:53 +0100, a écrit : On 29.11.2013 23:52:00, Ivan Shmakov wrote: Correct me if I’m wrong, but doesn’t it replace a pointer to an global (external) syscall () function with a pointer to a local variable? I don’t seem to understand how the logic is

Re: [PATCH 40/68] kern/syscall_subr.c: remove forward declaration

2013-11-29 Thread Marin Ramesa
On 29.11.2013 23:46:57, Ivan Shmakov wrote: Shouldn’t it be declared as ‘extern’ just as well? (And the argument names are unnecessary, BTW.) Also, it may make sense to “pair” it with thread_depress_timeout (), like: It's used only locally, so I figured extern is not

Re: [PATCH 19/68] i386/i386/ldt.c: remove useless forward declaration without definition

2013-11-29 Thread Marin Ramesa
On 30.11.2013 00:27:23, Samuel Thibault wrote: Marin Ramesa, le Sat 30 Nov 2013 00:22:53 +0100, a écrit : On 29.11.2013 23:52:00, Ivan Shmakov wrote: Correct me if I’m wrong, but doesn’t it replace a pointer to an global (external) syscall () function with a pointer to a local