Re: [PATCH gnumach] x86_64: Support 8 byte inlined port rights to avoid message resizing.

2023-11-28 Thread Flávio Cruz
On Tue, Nov 28, 2023 at 7:53 PM Samuel Thibault wrote: > Samuel Thibault, le mer. 29 nov. 2023 00:19:41 +0100, a ecrit: > > I'm hitting the last assertion, not sure exactly where it is coming from > yet. > > Ok, I missed updating libc :) Now fixed. I'm however getting: > > task /sbin/getty(631)

[PATCH gnumach] Use MACH_PORT_NAME_NULL and MACH_PORT_NAME_DEAD when checking for null or dead rights

2023-11-28 Thread Flavio Cruz
Comparing mach_port_name_t that is MACH_PORT_NAME_DEAD against MACH_PORT_DEAD will always return false. --- ipc/ipc_space.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipc/ipc_space.h b/ipc/ipc_space.h index 9b199de..3f0eaa0 100644 --- a/ipc/ipc_space.h +++

Re: [PATCH gnumach] x86_64: Support 8 byte inlined port rights to avoid message resizing.

2023-11-28 Thread Samuel Thibault
Samuel Thibault, le mer. 29 nov. 2023 00:19:41 +0100, a ecrit: > I'm hitting the last assertion, not sure exactly where it is coming from yet. Ok, I missed updating libc :) Now fixed. I'm however getting: task /sbin/getty(631) looked up a bogus port 4294967295 for 28000, most probably a bug.

Re: [PATCH gnumach] x86_64: Support 8 byte inlined port rights to avoid message resizing.

2023-11-28 Thread Samuel Thibault
Hello, Flavio Cruz, le ven. 24 nov. 2023 16:30:41 -0500, a ecrit: > +#ifdef USER32 > + assert(size == > bytes_to_descsize(sizeof(mach_port_name_t))); >if ((usaddr + sizeof(mach_port_name_t)*number) > ueaddr) > return 1; >

Re: [PATCH gnumach] x86_64: Support 8 byte inlined port rights to avoid message resizing.

2023-11-28 Thread Samuel Thibault
Luca, le mar. 28 nov. 2023 21:57:54 +0100, a ecrit: > Il 24/11/23 22:30, Flavio Cruz ha scritto: > > If a port is inlined in a message, the user has to use > > mach_port_name_inlined_t to define each port. Out of line memory > > continues to use mach_port_name_t since that memory has to be copied

Re: [PATCH gnumach] x86_64: Support 8 byte inlined port rights to avoid message resizing.

2023-11-28 Thread Luca
Il 24/11/23 22:30, Flavio Cruz ha scritto: If a port is inlined in a message, the user has to use mach_port_name_inlined_t to define each port. Out of line memory continues to use mach_port_name_t since that memory has to be copied to the kernel anyway. Both copyinmsg and copyoutmsg can be