[PATCH 19/68] i386/i386/ldt.c: remove useless forward declaration without definition

2013-11-29 Thread Marin Ramesa
* i386/i386/ldt.c (syscall): Remove forward declaration. (syscall): New variable. --- i386/i386/ldt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/i386/i386/ldt.c b/i386/i386/ldt.c index 43b9efb..37f09fb 100644 --- a/i386/i386/ldt.c +++ b/i386/i386/ldt.c @@ -37,8 +37,6

Re: [PATCH 19/68] i386/i386/ldt.c: remove useless forward declaration without definition

2013-11-29 Thread Ivan Shmakov
Marin Ramesa m...@hi.t-com.hr writes: * i386/i386/ldt.c (syscall): Remove forward declaration. (syscall): New variable. […] #include ldt.h -extern int syscall(); - #ifdef MACH_PV_DESCRIPTORS /* It is actually defined in xen_boothdr.S */ extern @@ -60,6 +58,7 @@

Re: [PATCH 19/68] i386/i386/ldt.c: remove useless forward declaration without definition

2013-11-29 Thread Marin Ramesa
On 29.11.2013 23:52:00, Ivan Shmakov wrote: Correct me if I’m wrong, but doesn’t it replace a pointer to an global (external) syscall () function with a pointer to a local variable? I don’t seem to understand how the logic is preserved in this change. The function syscall() doesn't

Re: [PATCH 19/68] i386/i386/ldt.c: remove useless forward declaration without definition

2013-11-29 Thread Samuel Thibault
Marin Ramesa, le Sat 30 Nov 2013 00:22:53 +0100, a écrit : On 29.11.2013 23:52:00, Ivan Shmakov wrote: Correct me if I’m wrong, but doesn’t it replace a pointer to an global (external) syscall () function with a pointer to a local variable? I don’t seem to understand how the logic is

Re: [PATCH 19/68] i386/i386/ldt.c: remove useless forward declaration without definition

2013-11-29 Thread Marin Ramesa
On 30.11.2013 00:27:23, Samuel Thibault wrote: Marin Ramesa, le Sat 30 Nov 2013 00:22:53 +0100, a écrit : On 29.11.2013 23:52:00, Ivan Shmakov wrote: Correct me if I’m wrong, but doesn’t it replace a pointer to an global (external) syscall () function with a pointer to a local