I talked to Giuseppe on IRC, and said that I liked the patch, but
would prefer one where you don't need to redefine all elements of the
SYSTEM_FUNCTIONS structure. Anyway, he'll push/post/whatever a new/old
version soon.
(Just FYI)
Alfred M. Szmidt a...@gnu.org writes:
+#define HAVE_SYSTEM_IF_NAMEINDEX 1
I dislike this so much that I have to object to the patch, can't we
put the GNU/Linux cruft in linux.c, and have a generic version in
generic.c that is used by OSF, Solaris, ...? Or find something more
decent than
+2010-08-01 Giuseppe Scrivano gscriv...@gnu.org
+
+Under GNU/Linux ifconfig -a includes interfaces without an address
Doesn't describe the change, should say something like:
Don't show FOO under BAR when doing BAZ.
+* bootstrap.conf (gnulib_modules): Add module
+#define HAVE_SYSTEM_IF_NAMEINDEX 1
I dislike this so much that I have to object to the patch, can't we
put the GNU/Linux cruft in linux.c, and have a generic version in
generic.c that is used by OSF, Solaris, ...? Or find something more
decent than have random macros all over the place?
Giuseppe Scrivano gscriv...@gnu.org writes:
It seems that SIOCGIFCONF, used by ifconfig, doesn't return all
interfaces as we expect.
What do you think about this patch? Any comment?
Cheers,
Giuseppe
From 1f4f0273c5dbb14706055639e932554dce8d0353 Mon Sep 17 00:00:00 2001
From: Giuseppe
+2010-08-01 Giuseppe Scrivano gscriv...@gnu.org
+
+* NEWS: Mention the change.
Just write Updated., all I can think is What change?...
+* ifconfig/if_index.c (if_nameindex): Remove local variables
+`ifc', `i', `rq_len', `last_len', `ifr', `end', `cur'.
+Add
Giuseppe Scrivano gscriv...@gnu.org ha escrit:
What do you think about this patch? Any comment?
This will certainly work on GNU/Linux. But how about other
systems? Besides, this stuff being Linux-specific, it should
go to ifconfig/system/linux.c.
Regards,
Sergey
