Re: ltmain.sh install does not support spaces in destdir
Hello Sam, Thanks for the report and patch. * Sam Steingold wrote on Mon, Dec 03, 2007 at 06:08:47PM CET: VERSION=1.5.22 TIMESTAMP= (1.1220.2.365 2005/12/18 22:14:06) ltmain.sh install does not support spaces in destdir, because it does not quote destdir. this can be a serious problem for woe32 users. Whitespace issues are all over ltmain.in. It's easy to fix some, it's almost impossible to fix all instances in a way such that the absolute names to installed programs and libraries can contain whitespace. At least the cost to benefit ratio for this problem is way out of proportion, and it would quite certainly make `libtool' much slower than it is today (and it is already quite slow). Case in point: all loops over deplibs would need to quote them, matching a la case $deplib in would need eval'ing and so on. It would amount to more or less a rewrite. All that can reasonably be done is to fix issues that prevent whitespace in the absolute name of the source tree and the build tree. Which hasn't been done, and is not simple either, but at least possible. (I'm in the process of fixing most of such issues that are in Autoconf and Automake ATM; I'd rather not do it for Libtool). please consider the appended patch which fixed the problem for me: Just a dozen lines further down are more issues. If you decide to redo, please against CVS HEAD, and please add a testcase so that at least this instance will remain fixed. It won't help third-party, libtool-using packages to use your installed library, though, due to the whitespace in its absolute name. Cheers, Ralf 2007-12-03 Sam Steingold [EMAIL PROTECTED] * ltmain.sh: quote $destdir in install to support spaces in it ___ Bug-libtool mailing list Bug-libtool@gnu.org http://lists.gnu.org/mailman/listinfo/bug-libtool
Re: ltmain.sh install does not support spaces in destdir
On Thu, 6 Dec 2007, Ralf Wildenhues wrote: Thanks for the report and patch. * Sam Steingold wrote on Mon, Dec 03, 2007 at 06:08:47PM CET: VERSION=1.5.22 TIMESTAMP= (1.1220.2.365 2005/12/18 22:14:06) ltmain.sh install does not support spaces in destdir, because it does not quote destdir. this can be a serious problem for woe32 users. Whitespace issues are all over ltmain.in. It's easy to fix some, it's almost impossible to fix all instances in a way such that the absolute names to installed programs and libraries can contain whitespace. For Windows users there is actually some hope since Windows provides a way to obtain an obfusticated path which does not contain any spaces. Translating user-provided paths to ones without spaces may avoid many problems. However, any use of 'pwd' to obtain the current directory path might return a path which does contain spaces. Bob == Bob Friesenhahn [EMAIL PROTECTED], http://www.simplesystems.org/users/bfriesen/ GraphicsMagick Maintainer,http://www.GraphicsMagick.org/ ___ Bug-libtool mailing list Bug-libtool@gnu.org http://lists.gnu.org/mailman/listinfo/bug-libtool
ltmain.sh install does not support spaces in destdir
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 VERSION=1.5.22 TIMESTAMP= (1.1220.2.365 2005/12/18 22:14:06) ltmain.sh install does not support spaces in destdir, because it does not quote destdir. this can be a serious problem for woe32 users. please consider the appended patch which fixed the problem for me: 2007-12-03 Sam Steingold [EMAIL PROTECTED] * ltmain.sh: quote $destdir in install to support spaces in it - --- ltmain.sh.~1.2.~ 2007-11-02 12:35:57.0 -0400 +++ ltmain.sh 2007-12-03 12:06:57.000107000 -0500 @@ -5994,11 +5994,11 @@ relink_command=\$relink_command\ test -n $relink_command srcname=$realnameT # Install the shared library and build the symlinks. - - $show $install_prog $dir/$srcname $destdir/$realname - - $run eval $install_prog $dir/$srcname $destdir/$realname || exit $? + $show $install_prog $dir/$srcname '$destdir/$realname' + $run eval $install_prog $dir/$srcname '$destdir/$realname' || exit $? if test -n $stripme test -n $striplib; then - - $show $striplib $destdir/$realname - - $run eval $striplib $destdir/$realname || exit $? + $show $striplib '$destdir/$realname' + $run eval $striplib '$destdir/$realname' || exit $? fi if test $# -gt 0; then -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHVDgfPp1Qsf2qnMcRAm7OAJ0S+Vzi/gD2LlppHqPfQm5D2pf5PgCggNYr 2K8WWz+UlaWh7VUmnr0FDAc= =dOAV -END PGP SIGNATURE- ___ Bug-libtool mailing list Bug-libtool@gnu.org http://lists.gnu.org/mailman/listinfo/bug-libtool
