Re: Issue 1096 in lilypond: ly:parser-parse-string segfaults when directly called at toplevel

Updates: Status: Verified Comment #27 on issue 1096 by PhilEHolmes: ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 (No comment was entered for this change.) ___

Re: Issue 1096 in lilypond: ly:parser-parse-string segfaults when directly called at toplevel

Updates: Status: Fixed Labels: fixed_2_13_32 Comment #26 on issue 1096 by n.puttock: ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 (No comment was entered for this change.)

Re: Issue 1096 in lilypond: ly:parser-parse-string segfaults when directly called at toplevel

Comment #23 on issue 1096 by n.puttock: ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 New patch with better message. Thanks, looks OK. There are a few minor details which need fixing, but I'll sort them out

Re: Issue 1096 in lilypond: ly:parser-parse-string segfaults when directly called at toplevel

Comment #24 on issue 1096 by musiccomposition: ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 Thanks for reviewing! Sorry about style; I'm used to writing C in Python's style. Were the first two lines a correction?

Re: Issue 1096 in lilypond: ly:parser-parse-string segfaults when directly called at toplevel

Comment #25 on issue 1096 by n.puttock: ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 Were the first two lines a correction? Yep, just the space following `is_clean'. bool is_clean () const;

Re: Issue 1096 in lilypond: ly:parser-parse-string segfaults when directly called at toplevel

Comment #22 on issue 1096 by musiccomposition: ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 I assume you don't have tests for error conditions? ___ bug-lilypond mailing

Re: Issue 1096 in lilypond: ly:parser-parse-string segfaults when directly called at toplevel

Comment #20 on issue 1096 by n.puttock: ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 +parser-parser_error(ly:parser-parse-string only valid with new parser); I think a message gently pointing the user in the

Re: Issue 1096 in lilypond: ly:parser-parse-string segfaults when directly called at toplevel

Comment #19 on issue 1096 by musiccomposition: ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 New patch to use parser_error(). Attachments: 0001-don-t-allow-ly-parser-parse-file-to-continue-unless-.patch 1.7

Re: Issue 1096 in lilypond: ly:parser-parse-string segfaults when directly called at toplevel

Comment #17 on issue 1096 by n.puttock: ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 parser_error doesn't generate a syntax error: music.ly:1:0: error: Display a helpful message to the user.

Re: Issue 1096 in lilypond: ly:parser-parse-string segfaults when directly called at toplevel

Updates: Owner: n.puttock Comment #18 on issue 1096 by Carl.D.Sorensen: ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 Neil's following this now, so I made him the owner

Re: Issue 1096 in lilypond: ly:parser-parse-string segfaults when directly called at toplevel

Comment #13 on issue 1096 by musiccomposition: ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 Here's a patch, which should do the trick. I wasn't sure what to do in the case that the function shouldn't run, so I

Re: Issue 1096 in lilypond: ly:parser-parse-string segfaults when directly called at toplevel

Comment #14 on issue 1096 by n.puttock: ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 I wasn't sure what to do in the case that the function shouldn't run, so I just threw an error. You can use parser_error here.

Re: Issue 1096 in lilypond: ly:parser-parse-string segfaults when directly called at toplevel

Comment #15 on issue 1096 by musiccomposition: ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 But it's a syntax error. ___ bug-lilypond mailing list bug-lilypond@gnu.org

Re: Issue 1096 in lilypond: ly:parser-parse-string segfaults when directly called at toplevel

Comment #16 on issue 1096 by musiccomposition: ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 But it's not a syntax error. ___ bug-lilypond mailing list

Re: Issue 1096 in lilypond: ly:parser-parse-string segfaults when directly called at toplevel

Updates: Labels: -Patch Comment #12 on issue 1096 by n.puttock: ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 The revised patch which adds `ly:parser-include-string' has been applied. Benjamin has promised

Re: Issue 1096 in lilypond: ly:parser-parse-string segfaults when directly called at toplevel

Comment #11 on issue 1096 by pnorcks: ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 Issue 1119 has been merged into this issue. ___ bug-lilypond mailing list

Re: Issue 1096 in lilypond: ly:parser-parse-string segfaults when directly called at toplevel

Updates: Owner: Carl.D.Sorensen Comment #10 on issue 1096 by Carl.D.Sorensen: ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 I guess I own it since I posted the patch.

Re: Issue 1096 in lilypond: ly:parser-parse-string segfaults when directly called at toplevel

Comment #8 on issue 1096 by Carl.D.Sorensen: ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 New patch is up for comments on Rietveld. http://codereview.appspot.com/1345041/show

Re: Issue 1096 in lilypond: ly:parser-parse-string segfaults when directly called at toplevel

Comment #9 on issue 1096 by Carl.D.Sorensen: ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 New patch is up for comments on Rietveld. http://codereview.appspot.com/1345041/show

Re: Issue 1096 in lilypond: ly:parser-parse-string segfaults when directly called at toplevel

Comment #7 on issue 1096 by musiccomposition: ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 Attaching a patch which adds a new ly:parser-include-string interface. Attachments:

Re: Issue 1096 in lilypond: ly:parser-parse-string segfaults when directly called at toplevel

Updates: Labels: Patch Comment #4 on issue 1096 by v.villenave: ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 The patch works, but I'm getting a weird difference in some horizontal spacing (see attached)...

Re: Issue 1096 in lilypond: ly:parser-parse-string segfaults when directly called at toplevel

Comment #5 on issue 1096 by Carl.D.Sorensen: ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 test-output-distance is intended to get a different output distance every time, so you can be sure the regtests have been

Re: Issue 1096 in lilypond: ly:parser-parse-string segfaults when directly called at toplevel

Updates: Status: Started Comment #6 on issue 1096 by v.villenave: ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 Oh, I guess I'm just plain wrong then :-) OK, as far as testing goes, there's nothing wrong

Re: Issue 1096 in lilypond: ly:parser-parse-string segfaults when directly called at toplevel

Comment #3 on issue 1096 by musiccomposition: ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 The problem is that the embedded scm causes a recursive yyparse() to be invokved. However, when the string input is

Re: Issue 1096 in lilypond: ly:parser-parse-string segfaults when directly called at toplevel

Comment #2 on issue 1096 by v.villenave: ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 I didn't mark it as High because in no circumstance it would affect someone who uses LilyPond in a normal (i.e. non-geeky,

Issue 1096 in lilypond: ly:parser-parse-string segfaults when directly called at toplevel

Status: Accepted Owner: Labels: Type-Defect Priority-Medium Syntax Bounty New issue 1096 by v.villenave: ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 %% The following code exits with a segfault, even though the

Re: Issue 1096 in lilypond: ly:parser-parse-string segfaults when directly called at toplevel

Updates: Labels: -Priority-Medium Priority-Critical Comment #1 on issue 1096 by percival.music.ca: ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 A segfault is never acceptable.