[bug #63650] Performance regression with EXPORT_ALL_VARIABLES enabled

Follow-up Comment #9, bug#63650 (group make): Interesting idea, one that doesn't seem to be ruled out by anything in the original problem report, bug #10593. (I have a copy of the Makefile from that bug with an mtime one day earlier than the submission date. It looks like my idiolect. Guess I

[bug #63650] Performance regression with EXPORT_ALL_VARIABLES enabled

Follow-up Comment #8, bug#63650 (group make): I just ran into this bug while trying to upgrade from 4.2 to 4.4. We had a lot of builds get slower. Specifically [trace-cmd](https://git.kernel.org/pub/scm/utils/trace-cmd/trace-cmd.git/tag/?h=trace-cmd-v3.1.5) now takes minutes to run the Makefile

[bug #63650] Performance regression with EXPORT_ALL_VARIABLES enabled

Follow-up Comment #7, bug #63650 (project make): I don't think it is reasonable to cache environment. The number of operations needed for a single expansion is a very fast growing sequence. So if it will help with e.g. n=5, n=6 will still take a long time to compute. Maybe just show a warning

[bug #63650] Performance regression with EXPORT_ALL_VARIABLES enabled

Follow-up Comment #6, bug #63650 (project make): I guess we might be saved by a weird behavior of GNU Make that I've long considered changing because it confuses people: when we are about to expand a recipe we expand all lines in the recipe at once, before we invoke the first line. This means

[bug #63650] Performance regression with EXPORT_ALL_VARIABLES enabled

Update of bug #63650 (project make): Item Group: Bug => Enhancement ___ Follow-up Comment #5: What about this idea: we would create a new environment when needed with all variables expanded,

[bug #63650] Performance regression with EXPORT_ALL_VARIABLES enabled

Follow-up Comment #4, bug #63650 (project make): I don't think this is a bug. Or, at least I don't think we can fix it. In previous versions of GNU Make we did not add make variables to the environment of the shell function regardless of their export status. So for example this makefile:

[bug #63650] Performance regression with EXPORT_ALL_VARIABLES enabled

Follow-up Comment #3, bug #63650 (project make): I think they just mean they also tested Git HEAD (which is the commit mentioned) and see the same behavior as with the GNU Make 4.4 release. ___ Reply to this item at:

[bug #63650] Performance regression with EXPORT_ALL_VARIABLES enabled

Follow-up Comment #2, bug #63650 (project make): ??? Do you mean to say that commit f51fc130 caused this regression? If so, I don't understand: that commit changed code that is only used on MS-Windows, whereas the OP is on Arch Linux...

[bug #63650] Performance regression with EXPORT_ALL_VARIABLES enabled

Follow-up Comment #1, bug #63650 (project make): Update: reproduces when building from git. Commit sha f51fc130, message: [SV 63638] Fix processing PATH on MS-Windows ___ Reply to this item at:

[bug #63650] Performance regression with EXPORT_ALL_VARIABLES enabled

URL: Summary: Performance regression with EXPORT_ALL_VARIABLES enabled Project: make Submitter: None Submitted: Fri 13 Jan 2023 12:33:13 PM UTC Severity: 3 - Normal