[Bug-tar] [PATCH] xattr: fix compilation failure with -Werror

2013-04-24 Thread Stefano Lattarini
Without this change, building from the bootstrapped Git repository with GCC (4.7.2) fails like this: xattrs.c:488:1: error: ‘xattrs__fd_set’ defined but not used \ [-Werror=unused-function] cc1: all warnings being treated as errors Makefile:1305: recipe for target 'xattrs.o' failed

[Bug-tar] [PATCH] build: support newer Automake with older Gettext

2013-04-24 Thread Stefano Lattarini
* configure.ac (AC_SUBST): Define @mkdir_p@ to $(MKDIR_P), to support the Makefile generated by pre-1.18.2 Gettext even when bleeding-edge Automake is in use. Copyright-paperwork-exempt: yes Signed-off-by: Stefano Lattarini stefano.lattar...@gmail.com --- configure.ac | 3 +++ 1 file changed, 3

Re: [Bug-tar] [PATCH] xattr: fix compilation failure with -Werror

2013-04-24 Thread Pavel Raiskup
On Wednesday, April 24, 2013 11:17:54 AM Stefano Lattarini wrote: Without this change, building from the bootstrapped Git repository with GCC (4.7.2) fails like this: xattrs.c:488:1: error: ‘xattrs__fd_set’ defined but not used \ [-Werror=unused-function] cc1: all warnings being

Re: [Bug-tar] [PATCH] xattr: fix compilation failure with -Werror

2013-04-24 Thread Paul Eggert
On 04/24/2013 03:10 AM, Pavel Raiskup wrote: please use Stefano's fix, it is a second proposal already: Thanks, I applied that.

Re: [Bug-tar] [PATCH] Do not fail when 'compress' is unable to provide sufficient compress ratio

2013-04-24 Thread Paul Eggert
I think I'd rather have tar assume the gzip exit-status convention, and depart from that only for bzip2 and lzip (which don't use the convention). That's a bit simpler and is more likely to match some random future compressor.