On Wed, 20 Sep 2023 22:46:16 GMT, Srinivas Vamsi Parasa
wrote:
> Hi Vladimir,
>
> Just trying to understand: is there a reason to use
> `DualPivotQuicksort_RadixForParallel.java` and
> `DualPivotQuicksort_RadixForAll.java`?
>
> Would it not be sufficient to do the following two runs:
>
>
On Tue, 19 Sep 2023 14:14:35 GMT, Antonios Printezis wrote:
>> The build failure happens when building on RISC-V with GCC 12.3. Is there a
>> better way to address this than disabling the stringop-overflow warnings for
>> the two files in question?
>
> Antonios Printezis has updated the pull
On Wed, 20 Sep 2023 17:19:42 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
On Wed, 20 Sep 2023 17:19:42 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
On Wed, 20 Sep 2023 17:19:42 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
On Tue, 19 Sep 2023 14:14:35 GMT, Antonios Printezis wrote:
>> The build failure happens when building on RISC-V with GCC 12.3. Is there a
>> better way to address this than disabling the stringop-overflow warnings for
>> the two files in question?
>
> Antonios Printezis has updated the pull
On Tue, 19 Sep 2023 17:59:05 GMT, Erik Joelsson wrote:
> After [JDK-8253620](https://bugs.openjdk.org/browse/JDK-8253620),
> BuildMicrobenchmark.gmk has started printing warnings about overriding
> targets on macos. This is caused by a CopyFiles using the `FLATTEN` option in
> combination
Hello Andrew,
The bootcycle-images target is AFAIK just a test. It's certainly not
meant to be the authoritative way of building the JDK. Using JDK N-1 as
bootjdk is the official way of producing a JDK of version JDK N. For
convenience, and because it should work, we also allow JDK N. Vendors
On Wed, 13 Sep 2023 20:15:09 GMT, Naoto Sato wrote:
> This PR is to incorporate the latest Unicode 15.1, which was released
> yesterday. Besides the usual character data update, an upgraded
> implementation of RegEx which reflects the Indic Conjunct Break specified in
> the latest [Unicode
> The goal is to develop faster sort routines for x86_64 CPUs by taking
> advantage of AVX512 instructions. This enhancement provides an order of
> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>
> This PR shows upto ~7x improvement for 32-bit datatypes (int,
On Wed, 20 Sep 2023 07:18:55 GMT, iaroslavski wrote:
> ... and suggestion to improve naming: there are inconsistent new names:
> pivotIndices, indexPivot1 and indexPivot2. I think names pivotIndices,
> pivotIndex1 and pivotIndex2 will be better. Do you agree?
Please see the variable names
On Wed, 20 Sep 2023 16:27:19 GMT, Srinivas Vamsi Parasa
wrote:
> This API was suggested to me and was already reviewed by others.
Confirming so, this was my suggestion. We use the _double-register_ addressing
mode (as commonly applied in unsafe), thereby the intrinsic is capable of being
On Tue, 19 Sep 2023 01:57:44 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
On Tue, 19 Sep 2023 17:59:05 GMT, Erik Joelsson wrote:
> After [JDK-8253620](https://bugs.openjdk.org/browse/JDK-8253620),
> BuildMicrobenchmark.gmk has started printing warnings about overriding
> targets on macos. This is caused by a CopyFiles using the `FLATTEN` option in
> combination
Hi Magnus,
So yes, jrt-fs.jar can be different between a normal build and a bootcycle
build, which is where I sort of came in here... For example, building say
jdk-21 using a jdk-20 bootjdk, you will find that there is an extra inner
class in the standard build of jrt-fs.jar, due to the fact that
On Tue, 19 Sep 2023 17:59:05 GMT, Erik Joelsson wrote:
> After [JDK-8253620](https://bugs.openjdk.org/browse/JDK-8253620),
> BuildMicrobenchmark.gmk has started printing warnings about overriding
> targets on macos. This is caused by a CopyFiles using the `FLATTEN` option in
> combination
On Wed, 20 Sep 2023 14:41:59 GMT, Jorn Vernee wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove unused define
>
> src/java.base/windows/native/libjava/java_props_md.c line 214:
>
>> 212: HRESULT
On Mon, 18 Sep 2023 18:10:12 GMT, Daniel Jeliński wrote:
>> Please review this patch that makes java.dll load shell32.dll earlier.
>> Delay-loading requires some additional code (delayimp.lib), and offers no
>> benefits since we always load shell32 during JVM startup.
>>
>> Other than
On Wed, 20 Sep 2023 13:57:05 GMT, Magnus Ihse Bursie wrote:
> Does this change the actual path where the lib*.dylib files end up? If so, do
> we need any changes to the runtime configuration of the micros to get them to
> properly pick up the libs?
No, they end up in the same place
On Tue, 19 Sep 2023 17:59:05 GMT, Erik Joelsson wrote:
> After [JDK-8253620](https://bugs.openjdk.org/browse/JDK-8253620),
> BuildMicrobenchmark.gmk has started printing warnings about overriding
> targets on macos. This is caused by a CopyFiles using the `FLATTEN` option in
> combination
Vote: yes
Tim
On 9/20/23 03:21, Magnus Ihse Bursie wrote:
nominate Julian Waters
On 2023-09-20 09:38, Andrew Leonard wrote:
Thanks Alan,
So different gcc, glibc, Xcode,.. agree, they need to be the same for
identical bits.
However, at the moment using the same toolchains, if you do a standard
product build,
and then a bootcycle build, of the same source, jrt-fs.jar will
On Tue, 19 Sep 2023 14:44:26 GMT, Leo Korinth wrote:
> `make test` outputs `TEST SUCCESS` after unsuccessful exit of JVM. One
> example is bad VM flags.
>
> I now have a reproducer for something that has puzzled me before (and most of
> my co-workers I think):
>
> // first test uses
On Wed, 20 Sep 2023 07:49:20 GMT, Leo Korinth wrote:
>> `make test` outputs `TEST SUCCESS` after unsuccessful exit of JVM. One
>> example is bad VM flags.
>>
>> I now have a reproducer for something that has puzzled me before (and most
>> of my co-workers I think):
>>
>> // first test uses
On Wed, 20 Sep 2023 12:47:19 GMT, Erik Joelsson wrote:
> Looks good. I assume you have verified that this still works.
Thank you @erikj79 . I appreciate your input.
Yes, I have verified the changes , build successfully completed.
-
PR Comment:
On Tue, 12 Sep 2023 16:51:53 GMT, Erik Joelsson wrote:
>> Deepa Kumari has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove quotes
>
> make/autoconf/basic.m4 line 482:
>
>> 480: # is the same. On older AIXes we just continue to
On Wed, 20 Sep 2023 12:44:05 GMT, Erik Joelsson wrote:
>> make/modules/java.base/Lib.gmk line 55:
>>
>>> 53: LDFLAGS := $(LDFLAGS_JDKLIB) \
>>> 54: $(call SET_SHARED_LIBRARY_ORIGIN), \
>>> 55: LDFLAGS_windows := -delayload:secur32.dll -delayload:iphlpapi.dll \
>>
>> Wonder if
On Fri, 1 Sep 2023 21:08:53 GMT, Erik Joelsson wrote:
> Compiling the ADLC build tool on Windows is generating multiple warnings like
> this:
>
> cl : Command line warning D9007 : '/pathmap:' requires
> '/experimental:deterministic'; option ignored
>
> This is caused by the `ADLC_CFLAGS` are
On Wed, 20 Sep 2023 10:21:36 GMT, Deepa Kumari wrote:
>> Previously [JDK-8304364](https://github.com/openjdk/jdk/pull/13066/files) ,
>> the AIX build process raised complaints about the disk location detection,
>> incorrectly determining that the build wasn't on a local disk. However, a
>>
Vote: yes
/Erik
On 9/20/23 03:21, Magnus Ihse Bursie wrote:
I hereby nominate Julian Waters (jwaters/TheShermanTanker) to
Membership in the Build Group.
Julian has shown great enthusiasm, skill and patience in working with
tricky bugs in the build system. He has committed more than 60 fixes
On Wed, 20 Sep 2023 07:49:20 GMT, Leo Korinth wrote:
>> `make test` outputs `TEST SUCCESS` after unsuccessful exit of JVM. One
>> example is bad VM flags.
>>
>> I now have a reproducer for something that has puzzled me before (and most
>> of my co-workers I think):
>>
>> // first test uses
On Wed, 20 Sep 2023 03:51:20 GMT, Julian Waters wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert test changes
>
> make/modules/java.base/Lib.gmk line 55:
>
>> 53: LDFLAGS := $(LDFLAGS_JDKLIB) \
>>
On Tue, 6 Jun 2023 19:39:31 GMT, Tim Prinzing wrote:
> The socket read/write JFR events currently use instrumentation of java.base
> code using templates in the jdk.jfr modules. This results in some java.base
> code residing in the jdk.jfr module which is undesirable.
>
> JDK19 added static
On Wed, 20 Sep 2023 11:21:51 GMT, Daniel Fuchs wrote:
> Thanks Tim. Should 8308995 be listed in the `@bug` clause of these two tests?
I don't think so as these tests are just used to check that changes haven't
broken anything.
-
PR Comment:
On Tue, 19 Sep 2023 20:51:41 GMT, Tim Prinzing wrote:
> The existing JFR tests TestSocketChannelEvents and TestSocketEvents in
> jdk.jfr.event.io verify the events are still emitted as expected.
Thanks Tim. Should 8308995 be listed in the `@bug` clause of these two tests?
-
PR
> Previously [JDK-8304364](https://github.com/openjdk/jdk/pull/13066/files) ,
> the AIX build process raised complaints about the disk location detection,
> incorrectly determining that the build wasn't on a local disk. However, a
> partial fix introduced a new problem, the build process
I hereby nominate Julian Waters (jwaters/TheShermanTanker) to Membership
in the Build Group.
Julian has shown great enthusiasm, skill and patience in working with
tricky bugs in the build system. He has committed more than 60 fixes to
the JDK[1], many of these in the build system.
Votes are
On Fri, 1 Sep 2023 21:08:53 GMT, Erik Joelsson wrote:
> Compiling the ADLC build tool on Windows is generating multiple warnings like
> this:
>
> cl : Command line warning D9007 : '/pathmap:' requires
> '/experimental:deterministic'; option ignored
>
> This is caused by the `ADLC_CFLAGS` are
On Wed, 20 Sep 2023 07:49:20 GMT, Leo Korinth wrote:
>> `make test` outputs `TEST SUCCESS` after unsuccessful exit of JVM. One
>> example is bad VM flags.
>>
>> I now have a reproducer for something that has puzzled me before (and most
>> of my co-workers I think):
>>
>> // first test uses
> `make test` outputs `TEST SUCCESS` after unsuccessful exit of JVM. One
> example is bad VM flags.
>
> I now have a reproducer for something that has puzzled me before (and most of
> my co-workers I think):
>
> // first test uses -XX:+UseG1GC second and third uses -XX:+UseG1GCC (sic)
> `make
On Tue, 19 Sep 2023 14:44:26 GMT, Leo Korinth wrote:
> `make test` outputs `TEST SUCCESS` after unsuccessful exit of JVM. One
> example is bad VM flags.
>
> I now have a reproducer for something that has puzzled me before (and most of
> my co-workers I think):
>
> // first test uses
On Tue, 19 Sep 2023 01:57:44 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
On Tue, 19 Sep 2023 21:44:00 GMT, iaroslavski wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Update DualPivotQuicksort.java
>> - Rename arraySort and arrayPartition Java methods to sort and partition.
43 matches
Mail list logo
