On Fri, 15 Dec 2023 15:52:07 GMT, Kim Barrett wrote:
> gcc: https://gcc.gnu.org/gcc-9/changes.html
> "The C++17 implementation is no longer experimental."
Bumping to gcc10 rather than gcc9 would have the benefit that we could get a
work-alike for C++20
`std::is_constant_evaluated` even though
On Fri, 15 Dec 2023 16:20:02 GMT, Kim Barrett wrote:
>> Julian Waters has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>>
On Fri, 15 Dec 2023 13:52:28 GMT, Martin Doerr wrote:
> In case you want to update the required compiler versions as part of this PR:
> We have tested -TOOLCHAIN_MINIMUM_VERSION_xlc="16.1.0.0011"
> +TOOLCHAIN_MINIMUM_VERSION_xlc="17.1.1.4" (Already discussed with Kim.)
Also discussed with the
On Fri, 15 Dec 2023 16:20:02 GMT, Kim Barrett wrote:
>> Julian Waters has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>>
On Fri, 15 Dec 2023 13:05:32 GMT, Julian Waters wrote:
>> The keyword also happens to go in the same location as well. How
>> coincidental...
>
> I also realized that this uses a gcc statement expression currently, I wonder
> if this could use a lambda expression instead in another change?
On Fri, 15 Dec 2023 08:08:10 GMT, Julian Waters wrote:
>> Implementation of [JEP draft: Compile the JDK as
>> C++17](https://bugs.openjdk.org/browse/JDK-8310260)
>
> Julian Waters has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes
On Fri, 15 Dec 2023 08:08:10 GMT, Julian Waters wrote:
>> Implementation of [JEP draft: Compile the JDK as
>> C++17](https://bugs.openjdk.org/browse/JDK-8310260)
>
> Julian Waters has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes
On Fri, 15 Dec 2023 08:08:10 GMT, Julian Waters wrote:
>> Implementation of [JEP draft: Compile the JDK as
>> C++17](https://bugs.openjdk.org/browse/JDK-8310260)
>
> Julian Waters has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes
On Fri, 15 Dec 2023 12:56:07 GMT, Julian Waters wrote:
>> It's not that it overrides the warning. They are different syntactic
>> constructs that just happen to have
>> a word in common. The joys of parsing C++ ...
>
> The keyword also happens to go in the same location as well. How
>
On Fri, 15 Dec 2023 12:31:51 GMT, Kim Barrett wrote:
>> Ah, I was not aware that the asm specifications for explicit registers
>> overrides the warning about the register keyword, thanks!
>
> It's not that it overrides the warning. They are different syntactic
> constructs that just happen to
On Fri, 15 Dec 2023 11:25:24 GMT, Julian Waters wrote:
>> Looks like this change has also already been made, by JDK-8319440.
>>
>> All of the other non-comment uses of "register" I found in HotSpot are gcc
>> local variable register specifications:
>>
On Fri, 15 Dec 2023 09:05:37 GMT, Kim Barrett wrote:
>> There are, strangely, many more register keywords in the JDK codebase than
>> just this one, but none of them throw the same errors, only this one does
>
> Looks like this change has also already been made, by JDK-8319440.
>
> All of the
On Fri, 15 Dec 2023 08:12:47 GMT, Julian Waters wrote:
>> No problem!
>
> There are, strangely, many more register keywords in the JDK codebase than
> just this one, but none of them throw the same errors, only this one does
Looks like this change has also already been made, by JDK-8319440.
On Fri, 15 Dec 2023 08:03:45 GMT, Julian Waters wrote:
>> src/hotspot/os_cpu/linux_riscv/vm_version_linux_riscv.cpp line 77:
>>
>>> 75: #define read_csr(csr) \
>>> 76: ({ \
>>> 77:
> Implementation of [JEP draft: Compile the JDK as
> C++17](https://bugs.openjdk.org/browse/JDK-8310260)
Julian Waters has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull
On Fri, 15 Dec 2023 07:48:46 GMT, Kim Barrett wrote:
>> Julian Waters has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>>
16 matches
Mail list logo
