On Fri, 16 Feb 2024 00:46:34 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Fri, 16 Feb 2024 04:46:24 GMT, Kim Barrett wrote:
> > Unfortunately this will break my workflow on Linux - I use clang to build
> > on Ubuntu 20.04, which is not that old, but it ships with clang 12. This is
> > not a deal breaker, just annoying.
>
> That's unfortunate, but I think the
On Thu, 15 Feb 2024 12:45:45 GMT, Thomas Stuefe wrote:
> Unfortunately this will break my workflow on Linux - I use clang to build on
> Ubuntu 20.04, which is not that old, but it ships with clang 12. This is not
> a deal breaker, just annoying.
That's unfortunate, but I think the
On Thu, 15 Feb 2024 12:19:31 GMT, Magnus Ihse Bursie wrote:
> Since jcheck only checks file in a commit, there is a possibility of us
> getting files in the repository that would not be accepted by jcheck. This
> can happen when extending the set of files checked by jcheck, or if jcheck
>
> Please review a patch to add support for Markdown syntax in documentation
> comments, as described in the associated JEP.
>
> Notable features:
>
> * support for `///` documentation comments in `JavaTokenizer`
> * new module `jdk.internal.md` -- a private copy of the `commonmark-java`
>
Hi Magnus,
For hotspot symbols that need to be exported, when statically linking
the launcher executable using libjvm.a, we use lld's
`-Wl,--export-dynamic-symbol-list=` option. Those exported symbols can
be used outside the VM code, e.g. in agent. Our friend(s) in c++
compiler/toolchain added
On Thu, 15 Feb 2024 12:19:31 GMT, Magnus Ihse Bursie wrote:
> Since jcheck only checks file in a commit, there is a possibility of us
> getting files in the repository that would not be accepted by jcheck. This
> can happen when extending the set of files checked by jcheck, or if jcheck
>
> Please review a patch to add support for Markdown syntax in documentation
> comments, as described in the associated JEP.
>
> Notable features:
>
> * support for `///` documentation comments in `JavaTokenizer`
> * new module `jdk.internal.md` -- a private copy of the `commonmark-java`
>
On Wed, Feb 14, 2024 at 5:07 PM Jiangli Zhou wrote:
>
> Hi Magnus,
>
> Thanks for looking into this from the build perspective.
>
> On Wed, Feb 14, 2024 at 1:00 AM Magnus Ihse Bursie
> wrote:
> >
> > First some background for build-dev: I have spent some time looking at
> > the build
On Thu, 15 Feb 2024 19:39:07 GMT, Pavel Rappo wrote:
>> whitespace is handled separately, on line 280 (`readIndent`) and285 (`:
>> (indent <= 3) ? peekLineKind()`)
>
> Correct, but I believe the ordered list marker should be like this:
>
> ORDERED_LIST_ITEM(Pattern.compile("[0-9]{1,9}[.)]
On Thu, 15 Feb 2024 19:36:36 GMT, Jonathan Gibbons wrote:
>> 1. Since forever, and still true, the way to specify a doclet is by its
>> name, and the tool will create the instance for you. This goes back to the
>> original old days before any API, when the only entry point was the command
On Thu, 15 Feb 2024 19:39:07 GMT, Pavel Rappo wrote:
>> whitespace is handled separately, on line 280 (`readIndent`) and285 (`:
>> (indent <= 3) ? peekLineKind()`)
>
> Correct, but I believe the ordered list marker should be like this:
>
> ORDERED_LIST_ITEM(Pattern.compile("[0-9]{1,9}[.)]
On Thu, 15 Feb 2024 19:20:23 GMT, Jonathan Gibbons wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java
>> line 1401:
>>
>>> 1399: */
>>> 1400: enum LineKind {
>>> 1401: BLANK(Pattern.compile("[ \t]*")),
>>
>> `BLANK` is a pseudo kind,
On Thu, 15 Feb 2024 19:15:25 GMT, Jonathan Gibbons wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/Start.java line 571:
>>
>>> 569: // of a doclet to be specified instead of the name of the
>>> 570: // doclet class and optional doclet path.
>>> 571: //
> Please review a patch to add support for Markdown syntax in documentation
> comments, as described in the associated JEP.
>
> Notable features:
>
> * support for `///` documentation comments in `JavaTokenizer`
> * new module `jdk.internal.md` -- a private copy of the `commonmark-java`
>
On Thu, 15 Feb 2024 19:27:12 GMT, Jonathan Gibbons wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java
>> line 422:
>>
>>> 420: defaultContentCharacter();
>>> 421: }
>>> 422: }
>>
>>
On Thu, 15 Feb 2024 17:17:46 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 44 commits:
>>
>> - fill in `visitRawText` in `CommentHelper.getTags` visitor
>> - fixes for the "New API"
On Thu, 15 Feb 2024 17:03:09 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 44 commits:
>>
>> - fill in `visitRawText` in `CommentHelper.getTags` visitor
>> - fixes for the "New API"
On Tue, 13 Feb 2024 11:15:55 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 40 commits:
>>
>> - Merge remote-tracking branch 'upstream/master' into
>> 8298405.doclet-markdown-v3
>>
> Please review a patch to add support for Markdown syntax in documentation
> comments, as described in the associated JEP.
>
> Notable features:
>
> * support for `///` documentation comments in `JavaTokenizer`
> * new module `jdk.internal.md` -- a private copy of the `commonmark-java`
>
On Thu, 15 Feb 2024 15:07:46 GMT, Magnus Ihse Bursie wrote:
> I don't understand why I have never thought of this before. If we add `-x` to
> the set of bash arguments when running with LOG=debug, we get output of *all*
> shell commands that make is running, even those for $(shell).
>
> This
On Thu, 15 Feb 2024 17:28:52 GMT, Andy Goryachev wrote:
>> Please do not replace those tabs with spaces as they are intentional for
>> testing the runtime to safely ignore them. I suggest replacing them with
>> Unicode escapes (`\u000b`)
>
> `\u000b` is VT (vertical tab)
> `\u0009` or `\t`
On Thu, 15 Feb 2024 17:09:17 GMT, Naoto Sato wrote:
>> All the java/util/Currency tests pass. I also searched the code for "ZZ" but
>> could not find any references in the test.
>
> Please do not replace those tabs with spaces as they are intentional for
> testing the runtime to safely ignore
On Thu, 15 Feb 2024 00:30:25 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Mon, 5 Feb 2024 09:44:02 GMT, Magnus Ihse Bursie wrote:
> > Sure, you can always install a newer GCC than the system one, but it's
> > another thing that makes it harder for people to build OpenJDK. Having said
> > that, C++17 is nice to have.
>
> @theRealAph I am still just hearing
On Thu, 15 Feb 2024 15:48:38 GMT, Magnus Ihse Bursie wrote:
>> This looks weird indeed. Luckily it's just test code. Did you run the test
>> after this change?
>
> All the java/util/Currency tests pass. I also searched the code for "ZZ" but
> could not find any references in the test.
Please
On Thu, 15 Feb 2024 15:54:56 GMT, Magnus Ihse Bursie wrote:
> > I would like it if toolchain version bumps were discussed somewhere else
> > first, not in a PR. (And apologies if it was and I missed that discussion).
>
> Yes, it definitely was. I posted a separate [mail to
>
On Thu, 15 Feb 2024 13:00:58 GMT, Thomas Stuefe wrote:
> I would like it if toolchain version bumps were discussed somewhere else
> first, not in a PR. (And apologies if it was and I missed that discussion).
Yes, it definitely was. I posted a separate [mail to
On Wed, 14 Feb 2024 22:43:37 GMT, Kim Barrett wrote:
> Please review this change that updates the minimum supported version of IBM
> Open XL C/C++. SAP dropped support for older versions in JDK 22, only
> supporting the version specified in this change.
>
> I need someone from the aix-ppc
On Thu, 15 Feb 2024 14:01:46 GMT, Erik Joelsson wrote:
>> test/jdk/java/util/Currency/currency.properties line 18:
>>
>>> 16: SB=EUR,111,2, 2099-01-01T00:00:00
>>> 17: US=euR,978,2,2001-01-01T00:00:00
>>> 18: ZZ = ZZZ , 999 , 3
>>
>> This looks weird, but so did
I don't understand why I have never thought of this before. If we add `-x` to
the set of bash arguments when running with LOG=debug, we get output of *all*
shell commands that make is running, even those for $(shell).
This makes it s much easier to understand what is actually happening in
On Thu, 15 Feb 2024 12:26:11 GMT, Magnus Ihse Bursie wrote:
>> Since jcheck only checks file in a commit, there is a possibility of us
>> getting files in the repository that would not be accepted by jcheck. This
>> can happen when extending the set of files checked by jcheck, or if jcheck
>>
On Thu, 15 Feb 2024 12:49:26 GMT, Julian Waters wrote:
> > > I see. I believe I wrote that piece of code, but I'd clearly forgotten
> > > that. Thanks! :)
> >
> >
> > No, this was added by me, because this was the root point to still resolve
> > to globalDefinitions_xlc.hpp even with
On Thu, 11 Jan 2024 13:23:45 GMT, Julian Waters wrote:
>> Compile the JDK as C++17, enabling the use of all C++17 language features
>
> Julian Waters has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Require clang 13 in toolchain.m4
Just on
On Thu, 15 Feb 2024 12:36:25 GMT, Joachim Kern wrote:
> > I see. I believe I wrote that piece of code, but I'd clearly forgotten
> > that. Thanks! :)
>
> No, this was added by me, because this was the root point to still resolve to
> globalDefinitions_xlc.hpp even with toolchain clang
On Thu, 15 Feb 2024 05:19:45 GMT, Kim Barrett wrote:
> Please review this change that updates the minimum supported version of Clang
> to be used for building OpenJDK from 3.5 to 13.
>
> This permits enabling C++17 (JDK-8314488), though Clang 5 might suffice for
> that. A minimum of Clang 13
On Thu, 15 Feb 2024 12:29:50 GMT, Magnus Ihse Bursie wrote:
> I see. I believe I wrote that piece of code, but I'd clearly forgotten that.
> Thanks! :)
No, this was added by me, because this was the root point to still resolve to
globalDefinitions_xlc.hpp even with toolchain clang
On Wed, 14 Feb 2024 22:43:37 GMT, Kim Barrett wrote:
> Please review this change that updates the minimum supported version of IBM
> Open XL C/C++. SAP dropped support for older versions in JDK 22, only
> supporting the version specified in this change.
>
> I need someone from the aix-ppc
On Thu, 15 Feb 2024 12:19:31 GMT, Magnus Ihse Bursie wrote:
> Since jcheck only checks file in a commit, there is a possibility of us
> getting files in the repository that would not be accepted by jcheck. This
> can happen when extending the set of files checked by jcheck, or if jcheck
>
Since jcheck only checks file in a commit, there is a possibility of us getting
files in the repository that would not be accepted by jcheck. This can happen
when extending the set of files checked by jcheck, or if jcheck changes how it
checks files (perhaps due to bug fixes).
I have now run
On Thu, 15 Feb 2024 11:10:32 GMT, Joachim Kern wrote:
>> What does this mean? That you are not using xlc at all? Or is it clang but
>> still with an xlc frontend, so all xlc flags etc need to stay?
>
>> What does this mean? That you are not using xlc at all? Or is it clang but
>> still with an
On Thu, 15 Feb 2024 11:10:32 GMT, Joachim Kern wrote:
>> What does this mean? That you are not using xlc at all? Or is it clang but
>> still with an xlc frontend, so all xlc flags etc need to stay?
>
>> What does this mean? That you are not using xlc at all? Or is it clang but
>> still with an
On Thu, 15 Feb 2024 10:40:53 GMT, Magnus Ihse Bursie wrote:
> What does this mean? That you are not using xlc at all? Or is it clang but
> still with an xlc frontend, so all xlc flags etc need to stay?
The `xlc` toolchain is for the compiler versions up to 16 (xlclang++); the
`clang`
On Thu, 15 Feb 2024 05:19:45 GMT, Kim Barrett wrote:
> Please review this change that updates the minimum supported version of Clang
> to be used for building OpenJDK from 3.5 to 13.
>
> This permits enabling C++17 (JDK-8314488), though Clang 5 might suffice for
> that. A minimum of Clang 13
On Wed, 14 Feb 2024 22:43:37 GMT, Kim Barrett wrote:
> Please review this change that updates the minimum supported version of IBM
> Open XL C/C++. SAP dropped support for older versions in JDK 22, only
> supporting the version specified in this change.
>
> I need someone from the aix-ppc
On Wed, 14 Feb 2024 15:33:22 GMT, Magnus Ihse Bursie wrote:
> The file NativeCompilation.gmk is a beast. It is one of the largest in the
> build system, and it is not very well organized. This makes it hard to read,
> understand, debug, edit and modify, especially since IDEs have a hard time
On Thu, 15 Feb 2024 08:53:35 GMT, Julian Waters wrote:
> This is not going to be fun to rebase on top on in my port :(
Apologies. :( But I think it might not be that hard either, if you do it
correctly. That was one of my goals by keeping the order so strict, to
facilitate this kind of
On Wed, 14 Feb 2024 22:43:37 GMT, Kim Barrett wrote:
> Please review this change that updates the minimum supported version of IBM
> Open XL C/C++. SAP dropped support for older versions in JDK 22, only
> supporting the version specified in this change.
>
> I need someone from the aix-ppc
On Wed, 14 Feb 2024 22:43:37 GMT, Kim Barrett wrote:
> Please review this change that updates the minimum supported version of IBM
> Open XL C/C++. SAP dropped support for older versions in JDK 22, only
> supporting the version specified in this change.
>
> I need someone from the aix-ppc
On Wed, 14 Feb 2024 15:44:27 GMT, Magnus Ihse Bursie wrote:
>> The file NativeCompilation.gmk is a beast. It is one of the largest in the
>> build system, and it is not very well organized. This makes it hard to read,
>> understand, debug, edit and modify, especially since IDEs have a hard
On Wed, 14 Feb 2024 22:43:37 GMT, Kim Barrett wrote:
> Please review this change that updates the minimum supported version of IBM
> Open XL C/C++. SAP dropped support for older versions in JDK 22, only
> supporting the version specified in this change.
>
> I need someone from the aix-ppc
On Thu, 15 Feb 2024 05:19:45 GMT, Kim Barrett wrote:
> Please review this change that updates the minimum supported version of Clang
> to be used for building OpenJDK from 3.5 to 13.
>
> This permits enabling C++17 (JDK-8314488), though Clang 5 might suffice for
> that. A minimum of Clang 13
52 matches
Mail list logo
