I do think there should be room for individual discretion here. If
you have a trivial change, just commit it and be done. But in
general, I think the extra care of RTC is usually worth it for us. I
see reviews becoming a lot more perfunctory / not happening at all if
we just commit
I think we have a handle on this now. All changes are put on Jira for
review and are not committed until there is at least one +1 from a
reviewer. (I personally prefer post-commit review because manually
attaching and applying patches is tedious but we don't have enough
people following the
(2) This is something that I have said many times over. Certain things are
the way they are for a reason. For example when I say ConcurrentHashMap is a
memory hog I say it because we have seen this in practice. How does it
manifest itself? I obviously do not recall since all this was over
