Re: [Catalyst] Duplicate session ids

2007-07-08 Thread Bill Moseley
On Sat, May 26, 2007 at 03:49:23PM -0700, mla wrote: Try changing Catalyst::Plugin::Session::finalize() to this: sub finalize { my $c = shift; $c-NEXT::finalize(@_); $c-finalize_session; } Just flipped the calls so it finalizes last. Seems to fix it. That's what .16 now

Re: [Catalyst] Duplicate session ids

2007-05-26 Thread Perrin Harkins
On 5/26/07, Bill Moseley [EMAIL PROTECTED] wrote: Perhaps an easier way to show the problem with duplicate created sessions would help. Do you mean duplicate or multiple? The session ID generation code in Catalyst::Plugin::Session does look like it could generate duplicates to me, but that

Re: [Catalyst] Duplicate session ids

2007-05-26 Thread Perrin Harkins
On 5/26/07, Jonathan Rockway [EMAIL PROTECTED] wrote: Please keep in mind that by rare, he means that you would have to generate 2317195645184714165087019331424 sessions per second for 100 years in order to have a 50% chance of colliding with an existing session. Or you could have it

Re: [Catalyst] Duplicate session ids

2007-05-26 Thread mla
mla wrote: Bill Moseley wrote: On Sat, May 26, 2007 at 04:08:48PM -0400, Perrin Harkins wrote: On 5/26/07, Bill Moseley [EMAIL PROTECTED] wrote: Perhaps an easier way to show the problem with duplicate created sessions would help. Do you mean duplicate or multiple? The session ID generation

Re: [Catalyst] Duplicate session ids

2007-05-26 Thread Bill Moseley
On Sat, May 26, 2007 at 03:00:31PM -0700, mla wrote: The problem is that the finalize() process calls the Catalyst::Plugin::Session-finalize_session before finalize_cookies() is called. And finalize_session() calls $c-_clear_session_instance_data after saving. So by the time your

[Catalyst] Duplicate session ids

2007-05-25 Thread Bill Moseley
I fired up an older application today and couldn't log in. I've recently updated this machine, so not sure that's related. Running Cat 5.7007 with current plugins: 'Session', 'Session::Store::FastMmap', 'Session::State::Cookie', If I have this in my base class: sub