Re: [Catalyst] + in GET param

2007-09-13 Thread Gavin Henry
quote who=Tatsuhiko Miyagawa As discussed on IRC, this seems to be a bug introduced around Catalyst 5.708. I got a commit bit from Jay (thanks!) and committed the fix with test suite. http://dev.catalystframework.org/svnweb/Catalyst/revision/?rev=6873 Yeah, thanks. For others, the bug was

Re: [Catalyst] + in GET param

2007-09-12 Thread Gavin Henry
Matt Rosin wrote: I wonder if this is similar to something bug I saw a few months ago. I tried to pass a GET url into a TT2 field but the question mark in the url kept getting url-encoded to %3F. I was wondering if it was a Unicode problem, but it may have been wrong url_for syntax. Here

Re: [Catalyst] + in GET param

2007-09-12 Thread Gavin Henry
Tatsuhiko Miyagawa wrote: I tested but couldn't reproduce. So I wouldn't say this is a Cat bug. % catalyst.pl TestApp % cd TestApp % vi lib/TestApp/Controller/Root.pm sub default : Private { my ( $self, $c ) = @_; # Hello World $c-response-body(Hello .

Re: [Catalyst] + in GET param

2007-09-12 Thread Jonathan Rockway
Gavin Henry wrote: Tatsuhiko Miyagawa wrote: I tested but couldn't reproduce. So I wouldn't say this is a Cat bug. And the same result as before: Hello first.last [EMAIL PROTECTED] Would you guys be so kind as to run scandeps.pl (from Module::ScanDeps on CPAN) and report the versions

Re: [Catalyst] + in GET param

2007-09-12 Thread Gavin Henry
Jonathan Rockway wrote: Gavin Henry wrote: Tatsuhiko Miyagawa wrote: I tested but couldn't reproduce. So I wouldn't say this is a Cat bug. And the same result as before: Hello first.last [EMAIL PROTECTED] Would you guys be so kind as to run scandeps.pl (from Module::ScanDeps on

Re: [Catalyst] + in GET param

2007-09-12 Thread Gavin Henry
Jonathan Rockway wrote: Gavin Henry wrote: Tatsuhiko Miyagawa wrote: I tested but couldn't reproduce. So I wouldn't say this is a Cat bug. And the same result as before: Hello first.last [EMAIL PROTECTED] Would you guys be so kind as to run scandeps.pl (from Module::ScanDeps on

Re: [Catalyst] + in GET param

2007-09-11 Thread Gavin Henry
Looks like it is a problem with the debug printing code or the some unescape code somewhere. That is the proper escape for +. Yes. and the problem is Catalyst is unescaping it to early, so its seeing it as a literal +, which then gets converted to a space according to the HTTP RFC. It

Re: [Catalyst] + in GET param

2007-09-11 Thread Gavin Henry
quote who=[EMAIL PROTECTED] That's what uri_for is already doing (I forgot to mention I'd checked already). uri_for: http://myserver.com/blah/?username=first.last%2Bme%40gmail.com URI::Escape: perl -MURI::Escape -e print uri_escape('[EMAIL PROTECTED]');

Re: [Catalyst] + in GET param

2007-09-11 Thread Jonathan Rockway
Gavin Henry wrote: quote who=[EMAIL PROTECTED] That's what uri_for is already doing (I forgot to mention I'd checked already). uri_for: http://myserver.com/blah/?username=first.last%2Bme%40gmail.com I haven't looked into this at all, but try using a chained action instead. I think

Re: [Catalyst] + in GET param

2007-09-11 Thread Tatsuhiko Miyagawa
I tested but couldn't reproduce. So I wouldn't say this is a Cat bug. % catalyst.pl TestApp % cd TestApp % vi lib/TestApp/Controller/Root.pm sub default : Private { my ( $self, $c ) = @_; # Hello World $c-response-body(Hello . ($c-req-param('username') || (default))); } %

Re: [Catalyst] + in GET param

2007-09-11 Thread Matt Rosin
I wonder if this is similar to something bug I saw a few months ago. I tried to pass a GET url into a TT2 field but the question mark in the url kept getting url-encoded to %3F. I was wondering if it was a Unicode problem, but it may have been wrong url_for syntax. Here is a snippet from the old