Re: [PATCH] rbd: fix I/O error propagation for reads

2013-08-27 Thread Josh Durgin
On 08/26/2013 08:27 PM, Mike Dawson wrote: Josh, The original bug is marked as krbd, but could this bug could affect rbd volumes mounted via qemu as well? If so, could you describe how it might block a qemu guest? No, this is just a patch for the kernel rbd driver, which doesn't affect qemu

[PATCH] cleanup: removed last references to g_conf from auth

2013-08-27 Thread Roald van Loon
Trivial cleanup. There were still 3 references to g_conf in CephxKeyServer. Replaced them in favor of cct-_conf. Signed-off-by: Roald J. van Loon roaldvanl...@gmail.com --- diff --git a/src/auth/cephx/CephxKeyServer.cc b/src/auth/cephx/CephxKeyServer.cc index e0c8174..e57b557 100644 ---

[PATCH] cleanup: removed last references to g_conf from auth

2013-08-27 Thread Roald J. van Loon
Trivial cleanup. There were still 3 references to g_conf in CephxKeyServer. Replaced them in favor of cct-_conf. Signed-off-by: Roald J. van Loon roaldvanl...@gmail.com --- src/auth/cephx/CephxKeyServer.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] cleanup: removed last references to g_conf from auth

2013-08-27 Thread Roald van Loon
Sorry, the format-patch of the first email was screwed up (tried to copy/paste the email because git was compiled without perl and hence had no send-email support... should have known that would go haywire) Roald On Tue, Aug 27, 2013 at 11:49 AM, Roald J. van Loon roaldvanl...@gmail.com wrote:

trivial bug in aio_write

2013-08-27 Thread James Harper
In internal.cc function aio_write, the ldout(cct, ...) statement writes out buf instead of buf. I assume this is not intentional. James -- To unsubscribe from this list: send the line unsubscribe ceph-devel in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] rbd: fix I/O error propagation for reads

2013-08-27 Thread Alex Elder
On 08/26/2013 08:34 PM, Josh Durgin wrote: When a request returns an error, the driver needs to report the entire extent of the request as completed. Writes already did this, since You're right. The block layer needs to consume the bytes in this portion of the image request whether or not

Re: [PATCH 02/15] rbd: convert bus code to use bus_groups

2013-08-27 Thread Alex Elder
On 08/23/2013 04:24 PM, Greg Kroah-Hartman wrote: The bus_attrs field of struct bus_type is going away soon, dev_groups should be used instead. This converts the RBD bus code to use the correct field. Cc: Yehuda Sadeh yeh...@inktank.com Cc: Sage Weil s...@inktank.com Cc: Alex Elder

Re: is it possible to set up debug env for ceph?

2013-08-27 Thread Sage Weil
[adding ceph-devel] On Tue, 27 Aug 2013, ?? wrote: hi, sage,   Sorry to trouble you, recently I started to use ceph to deploy a TB cluster, and it works with 10 osds and I love the S3 APIs! Thank god for your job and hope this project long live! I wonder if it is possible to set up a env to

Re: [PATCH] cleanup: removed last references to g_conf from auth

2013-08-27 Thread Sage Weil
Applied, thanks! BTW the patch whitespace was mangled; I had to tweak it to make it apply. Gmail is a common culprit here. sage On Tue, 27 Aug 2013, Roald van Loon wrote: Trivial cleanup. There were still 3 references to g_conf in CephxKeyServer. Replaced them in favor of cct-_conf.

Re: [ceph-users] Ceph + Xen - RBD io hang

2013-08-27 Thread Sage Weil
Hi James, Can you post the contents of the hung task warning so we can see where it is stuck? Thanks! sage On Tue, 27 Aug 2013, James Dingwall wrote: Hi, I am doing some experimentation with Ceph and Xen (on the same host) and I'm experiencing some problems with the rbd device that I'm

Re: trivial bug in aio_write

2013-08-27 Thread Sage Weil
It's not; I've pushed a fix. Thanks! sage On Tue, 27 Aug 2013, James Harper wrote: In internal.cc function aio_write, the ldout(cct, ...) statement writes out buf instead of buf. I assume this is not intentional. James -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] rbd: fix I/O error propagation for reads

2013-08-27 Thread Sage Weil
On Tue, 27 Aug 2013, Alex Elder wrote: On 08/26/2013 08:34 PM, Josh Durgin wrote: When a request returns an error, the driver needs to report the entire extent of the request as completed. Writes already did this, since You're right. The block layer needs to consume the bytes in this

Re: [PATCH] rbd: fix I/O error propagation for reads

2013-08-27 Thread Alex Elder
On 08/27/2013 10:36 AM, Sage Weil wrote: On Tue, 27 Aug 2013, Alex Elder wrote: On 08/26/2013 08:34 PM, Josh Durgin wrote: When a request returns an error, the driver needs to report the entire extent of the request as completed. Writes already did this, since You're right. The block layer

Re: linux-next: Tree for Aug 27 (ceph)

2013-08-27 Thread Randy Dunlap
On 08/27/13 03:30, Stephen Rothwell wrote: Hi all, I should know better than to take time off around -rc7 :-) Changes since 20130822: on i386: fs/built-in.o: In function `ceph_fallocate': file.c:(.text+0x20b171): undefined reference to `__divdi3' -- ~Randy -- To unsubscribe from this

Re: linux-next: Tree for Aug 27 (ceph)

2013-08-27 Thread Sage Weil
On Tue, 27 Aug 2013, Randy Dunlap wrote: On 08/27/13 03:30, Stephen Rothwell wrote: Hi all, I should know better than to take time off around -rc7 :-) Changes since 20130822: on i386: fs/built-in.o: In function `ceph_fallocate': file.c:(.text+0x20b171): undefined reference

[PATCH] rbd: fix buffer size for writes to images with snapshots

2013-08-27 Thread Josh Durgin
rbd_osd_req_create() needs to know the snapshot context size to create a buffer large enough to send it with the message front. It gets this from the img_request, which was not set for the obj_request yet. This resulted in trying to write past the end of the front payload, hitting this BUG:

Re: [PATCH] reinstate ceph cluster_snap support

2013-08-27 Thread Sage Weil
Hi, On Sat, 24 Aug 2013, Alexandre Oliva wrote: On Aug 23, 2013, Sage Weil s...@inktank.com wrote: FWIW Alexandre, this feature was never really complete. For it to work, we also need to snapshot the monitors, and roll them back as well. That depends on what's expected from the

Re: Blueprint: Add LevelDB support to ceph cluster backend store

2013-08-27 Thread Sage Weil
Hi Haomai, I just wanted to check in to see if things have progressed at all since we talked at CDS. If you have any questions or there is anything I can help with, let me know! I'd love to see this alternative backend make it into Emperor. Thanks! sage -- To unsubscribe from this list:

[PATCH 0/2] Fscache cleanup and fix

2013-08-27 Thread Milosz Tanski
Sage, These are the changes you requested. I eliminated the use of ifdefs in the C code. It's all self contained in cache.[ch] and in the case of it being disabled becomes a nop. Also, I found a small bug where we would not free the invalidate queue on unmount. It's split into it's own commit.

[PATCH 2/2] ceph: fscache cleanup

2013-08-27 Thread Milosz Tanski
Remove all ifdefs from ceph c source files and push that code into both cache.[ch] files. Signed-off-by: Milosz Tanski mil...@adfin.com --- fs/ceph/cache.c | 90 ++--- fs/ceph/cache.h | 68 +++

[PATCH 1/2] ceph: Do not leak fscache workqueue

2013-08-27 Thread Milosz Tanski
Previously I was not cleanup up the ceph fscache validate workqueue on filesystem unmount. Signed-off-by: Milosz Tanski mil...@adfin.com --- fs/ceph/super.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ceph/super.c b/fs/ceph/super.c index a56baab..a14b13a 100644 --- a/fs/ceph/super.c

Re: [PATCH 0/2] Fscache cleanup and fix

2013-08-27 Thread Sage Weil
Thanks, Milosz! I've pulled these into the testing branch and squashed them into the existing commits. David, I'm still not sure whether the fscache patches should go in through the Ceph tree or via your tree; either way I think they need your ACK.

Re: [PATCH v5] Ceph: Punch hole support for kernel client

2013-08-27 Thread Andrew Morton
On Thu, 15 Aug 2013 11:51:44 +0800 Li Wang liw...@ubuntukylin.com wrote: This patch implements fallocate and punch hole support for Ceph kernel client. i386 allmodconfig: ERROR: __divdi3 [fs/ceph/ceph.ko] undefined! make[1]: *** [__modpost] Error 1 make: *** [modules] Error 2 Due to a 64-bit

Re: [PATCH v5] Ceph: Punch hole support for kernel client

2013-08-27 Thread Sage Weil
On Tue, 27 Aug 2013, Andrew Morton wrote: On Thu, 15 Aug 2013 11:51:44 +0800 Li Wang liw...@ubuntukylin.com wrote: This patch implements fallocate and punch hole support for Ceph kernel client. i386 allmodconfig: ERROR: __divdi3 [fs/ceph/ceph.ko] undefined! make[1]: *** [__modpost]

Re: [PATCH] reinstate ceph cluster_snap support

2013-08-27 Thread Yan, Zheng
On Wed, Aug 28, 2013 at 6:21 AM, Sage Weil s...@inktank.com wrote: Hi, On Sat, 24 Aug 2013, Alexandre Oliva wrote: On Aug 23, 2013, Sage Weil s...@inktank.com wrote: FWIW Alexandre, this feature was never really complete. For it to work, we also need to snapshot the monitors, and roll

Re: [PATCH] reinstate ceph cluster_snap support

2013-08-27 Thread Sage Weil
On Wed, 28 Aug 2013, Yan, Zheng wrote: On Wed, Aug 28, 2013 at 6:21 AM, Sage Weil s...@inktank.com wrote: Hi, On Sat, 24 Aug 2013, Alexandre Oliva wrote: On Aug 23, 2013, Sage Weil s...@inktank.com wrote: FWIW Alexandre, this feature was never really complete. For it to work, we

RE: debugging librbd async

2013-08-27 Thread James Harper
Still having crashes with the rbd module for blktap. I think I can't get consistent debugging info out of librbd. When it writes to a file the logging is buffered so the tail is always missing. When it logs to syslog I thought I was getting everything but now I'm not so sure. What is the best

Re: [PATCH 02/15] rbd: convert bus code to use bus_groups

2013-08-27 Thread Greg Kroah-Hartman
On Tue, Aug 27, 2013 at 07:35:32AM -0500, Alex Elder wrote: On 08/23/2013 04:24 PM, Greg Kroah-Hartman wrote: The bus_attrs field of struct bus_type is going away soon, dev_groups should be used instead. This converts the RBD bus code to use the correct field. Cc: Yehuda Sadeh

patch rbd: convert bus code to use bus_groups added to driver-core tree

2013-08-27 Thread gregkh
This is a note to let you know that I've just added the patch titled rbd: convert bus code to use bus_groups to my driver-core git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git in the driver-core-next branch. The patch will show up in