Re: [PATCH] rbd: drop an unsafe assertion

2014-03-29 Thread Ilya Dryomov
On Sat, Mar 29, 2014 at 3:46 AM, Alex Elder el...@linaro.org wrote: On 03/28/2014 07:41 PM, Sage Weil wrote: Hi Alex, Ilya, I've added this and the previous patch to a for-linus branch to send to Linux for 3.14. The net of the two patches is simply removing the assert, however... the first

Re: [PATCH] rbd: drop an unsafe assertion

2014-03-29 Thread Sage Weil
On Sat, 29 Mar 2014, Ilya Dryomov wrote: On Sat, Mar 29, 2014 at 3:46 AM, Alex Elder el...@linaro.org wrote: On 03/28/2014 07:41 PM, Sage Weil wrote: Hi Alex, Ilya, I've added this and the previous patch to a for-linus branch to send to Linux for 3.14. The net of the two patches is

Re: [PATCH] rbd: drop an unsafe assertion

2014-03-29 Thread Ilya Dryomov
On Sat, Mar 29, 2014 at 6:23 PM, Sage Weil s...@inktank.com wrote: On Sat, 29 Mar 2014, Ilya Dryomov wrote: On Sat, Mar 29, 2014 at 3:46 AM, Alex Elder el...@linaro.org wrote: On 03/28/2014 07:41 PM, Sage Weil wrote: Hi Alex, Ilya, I've added this and the previous patch to a for-linus

Re: [PATCH] rbd: drop an unsafe assertion

2014-03-29 Thread Sage Weil
On Sat, 29 Mar 2014, Ilya Dryomov wrote: On Sat, Mar 29, 2014 at 6:23 PM, Sage Weil s...@inktank.com wrote: On Sat, 29 Mar 2014, Ilya Dryomov wrote: On Sat, Mar 29, 2014 at 3:46 AM, Alex Elder el...@linaro.org wrote: On 03/28/2014 07:41 PM, Sage Weil wrote: Hi Alex, Ilya, I've

Re: [PATCH] rbd: drop an unsafe assertion

2014-03-29 Thread Ilya Dryomov
On Sat, Mar 29, 2014 at 7:43 PM, Sage Weil s...@inktank.com wrote: On Sat, 29 Mar 2014, Ilya Dryomov wrote: On Sat, Mar 29, 2014 at 6:23 PM, Sage Weil s...@inktank.com wrote: On Sat, 29 Mar 2014, Ilya Dryomov wrote: On Sat, Mar 29, 2014 at 3:46 AM, Alex Elder el...@linaro.org wrote: On

Re: [PATCH] rbd: drop an unsafe assertion

2014-03-28 Thread Sage Weil
Hi Alex, Ilya, I've added this and the previous patch to a for-linus branch to send to Linux for 3.14. The net of the two patches is simply removing the assert, however... the first changes several lines that then get changed back. Should we squash them? Thanks! sage On Wed, 26 Mar 2014,

Re: [PATCH] rbd: drop an unsafe assertion

2014-03-28 Thread Alex Elder
On 03/28/2014 07:41 PM, Sage Weil wrote: Hi Alex, Ilya, I've added this and the previous patch to a for-linus branch to send to Linux for 3.14. The net of the two patches is simply removing the assert, however... the first changes several lines that then get changed back. Should we

[PATCH] rbd: drop an unsafe assertion

2014-03-26 Thread Alex Elder
Olivier Bonvalet reported having repeated crashes due to a failed assertion he was hitting in rbd_img_obj_callback(): Assertion failure in rbd_img_obj_callback() at line 2165: rbd_assert(which == img_request-next_completion); With a lot of help from Olivier with reproducing the