[PATCH v3 5/5] rbd: fix error handling from rbd_snap_name()

2013-09-09 Thread Josh Durgin
rbd_snap_name() calls rbd_dev_v{1,2}_snap_name() depending on the format of the image. The format 1 version returns NULL on error, which is handled by the caller. The format 2 version returns an ERR_PTR, which the caller of rbd_snap_name() does not expect. Fortunately this is unlikely to occur in

Re: [PATCH v3 5/5] rbd: fix error handling from rbd_snap_name()

2013-09-09 Thread Alex Elder
On 09/09/2013 02:17 AM, Josh Durgin wrote: rbd_snap_name() calls rbd_dev_v{1,2}_snap_name() depending on the format of the image. The format 1 version returns NULL on error, which is handled by the caller. The format 2 version returns an ERR_PTR, which the caller of rbd_snap_name() does not