On Nov 4, 2012, at 10:19 AM, Fariborz Jahanian wrote:
Author: fjahanian
Date: Sun Nov 4 12:19:40 2012
New Revision: 167374
URL: http://llvm.org/viewvc/llvm-project?rev=167374view=rev
Log:
Fixes liftime of captured block variables in mrr mode, per John's feedback, as
well as couple of
On Nov 7, 2012, at 8:50 AM, David Chisnall wrote:
Author: theraven
Date: Wed Nov 7 10:50:40 2012
New Revision: 167534
URL: http://llvm.org/viewvc/llvm-project?rev=167534view=rev
Log:
Fix the Objective-C exception rethrow from cleanups (GNU runtimes). Note that
a bug in the inliner still
On Nov 10, 2012, at 10:53 AM, Jordan Rose wrote:
Should we maybe put that in a comment, so that this won't happen again? We're
out of bits now. :-(
Only pending the GNU runtime moving to a 16-bit refcount, which David Chisnall
has agreed to do.
John.
On Nov 12, 2012, at 6:53 PM, David Chisnall csda...@swan.ac.uk wrote:
On 11 Nov 2012, at 00:41, John McCall wrote:
If you're going to do this, you need to have two different EH-resume blocks.
The way it's written right now, whichever you ask for first is going to be
what
you get, even
On Nov 12, 2012, at 9:50 PM, David Chisnall david.chisn...@cl.cam.ac.uk wrote:
On 12 Nov 2012, at 20:10, John McCall wrote:
On Nov 12, 2012, at 6:53 PM, David Chisnall csda...@swan.ac.uk wrote:
On 11 Nov 2012, at 00:41, John McCall wrote:
If you're going to do this, you need to have two
Author: rjmccall
Date: Tue Nov 13 18:49:39 2012
New Revision: 167896
URL: http://llvm.org/viewvc/llvm-project?rev=167896view=rev
Log:
Accept and pass arguments to __unknown_anytype in argument
positions of Objective-C methods.
It is possible to recover a lot of type information about
Objective-C
Author: rjmccall
Date: Wed Nov 14 03:08:34 2012
New Revision: 167925
URL: http://llvm.org/viewvc/llvm-project?rev=167925view=rev
Log:
Move some GNUStep-specific code out of CGObjCGNU.
Patch by Jonathan Schleifer.
Modified:
cfe/trunk/lib/CodeGen/CGObjCGNU.cpp
Modified:
Author: rjmccall
Date: Wed Nov 14 11:48:31 2012
New Revision: 167935
URL: http://llvm.org/viewvc/llvm-project?rev=167935view=rev
Log:
The ObjC++-to-C++ personality trick is only necessary on NeXT runtimes,
which is not coincidentally the only place it works, either (because
of how it tests for
On Nov 14, 2012, at 5:04 PM, Richard Trieu rtr...@google.com wrote:
On Mon, Aug 27, 2012 at 4:18 PM, Richard Trieu rtr...@google.com wrote:
On Tue, Jun 19, 2012 at 2:49 PM, Richard Trieu rtr...@google.com wrote:
On Fri, Jun 8, 2012 at 6:41 PM, John McCall rjmcc...@apple.com wrote:
On Jun 8
On Nov 14, 2012, at 7:37 PM, Richard Trieu rtr...@google.com wrote:
On Wed, Nov 14, 2012 at 7:17 PM, John McCall rjmcc...@apple.com wrote:
On Nov 14, 2012, at 5:04 PM, Richard Trieu rtr...@google.com wrote:
On Mon, Aug 27, 2012 at 4:18 PM, Richard Trieu rtr...@google.com wrote:
On Tue, Jun 19
On Nov 15, 2012, at 11:47 AM, Richard Trieu rtr...@google.com wrote:
On Thu, Nov 15, 2012 at 12:58 AM, John McCall rjmcc...@apple.com wrote:
On Nov 14, 2012, at 7:37 PM, Richard Trieu rtr...@google.com wrote:
On Wed, Nov 14, 2012 at 7:17 PM, John McCall rjmcc...@apple.com wrote:
On Nov 14
On Nov 15, 2012, at 5:43 PM, Richard Trieu rtr...@google.com wrote:
On Thu, Nov 15, 2012 at 11:55 AM, John McCall rjmcc...@apple.com wrote:
On Nov 15, 2012, at 11:47 AM, Richard Trieu rtr...@google.com wrote:
On Thu, Nov 15, 2012 at 12:58 AM, John McCall rjmcc...@apple.com wrote:
On Nov 14
On Nov 18, 2012, at 3:03 AM, Benjamin Kramer benny@gmail.com wrote:
On 17.11.2012, at 18:30, Benjamin Kramer benny@googlemail.com wrote:
Author: d0k
Date: Sat Nov 17 11:30:55 2012
New Revision: 168260
URL: http://llvm.org/viewvc/llvm-project?rev=168260view=rev
Log:
Enable inlining
On Nov 21, 2012, at 10:40 AM, Jonathan de Boyne Pollard
j.deboynepollard-newsgro...@ntlworld.com wrote:
On 2012-11-21 16:19, Chris Lattner wrote:
Definitely! Please send patches to the cfe-commits mailing list!
The output of svn diff turns out to be larger, at 28KiB, than the file
itself,
On Nov 27, 2012, at 7:45 PM, Richard Smith richard-l...@metafoo.co.uk wrote:
Author: rsmith
Date: Tue Nov 27 21:45:24 2012
New Revision: 168769
URL: http://llvm.org/viewvc/llvm-project?rev=168769view=rev
Log:
C++ core issue 1344, PR10618: promote addition of default argument makes this
a
On Nov 28, 2012, at 3:47 AM, NAKAMURA Takumi geek4ci...@gmail.com wrote:
John, I propose you please to approve r168303 for release_32.
It's a suppression to two tests for Windows x64 (and possibly
mingw-w64 x64) to pass clang tests.
See also; http://llvm.org/bugs/show_bug.cgi?id=8833
On Nov 28, 2012, at 6:43 AM, Timur Iskhodzhanov timur...@google.com wrote:
Hi Nico,
[John FYI-only if Nico's review is enough]
Can you please review this small patch?
This fixes most of the template mangling problems I've observed while
building DumpRenderTree (which is a huge target!).
I
On Nov 28, 2012, at 4:10 AM, Jean-Daniel Dupas devli...@shadowlab.org wrote:
Le 28 nov. 2012 à 01:37, John McCall rjmcc...@apple.com a écrit :
On Nov 21, 2012, at 10:40 AM, Jonathan de Boyne Pollard
j.deboynepollard-newsgro...@ntlworld.com wrote:
On 2012-11-21 16:19, Chris Lattner wrote
On Nov 15, 2012, at 8:43 AM, Timur Iskhodzhanov timur...@google.com wrote:
Can you please review the attached patch?
Sorry about the delay.
With this patch, I can compile and run simple single-inheritance tests;
even method calls from Clang-generated obj files to CL-generated
methods work
On Nov 29, 2012, at 1:11 AM, Charles Davis cdavi...@gmail.com wrote:
On Nov 28, 2012, at 10:09 PM, Timur Iskhodzhanov wrote:
Thanks for the review!
On Thu, Nov 29, 2012 at 2:52 AM, John McCall rjmcc...@apple.com wrote:
+ // FIXME: Should probably add a layer of abstraction for vtable
Author: rjmccall
Date: Fri Dec 7 01:03:17 2012
New Revision: 169588
URL: http://llvm.org/viewvc/llvm-project?rev=169588view=rev
Log:
Fix the required args count for variadic blocks.
We were emitting calls to blocks as if all arguments were
required --- i.e. with signature (A,B,C,D,...) rather
On Dec 10, 2012, at 7:52 PM, endlessroad1...@gmail.com
endlessroad1...@gmail.com wrote:
Hi all, I've rewritten the __declspec(property) implementation,using
PseudoObject.
If you're comfortable with this patch, I'll work on tests, code-style, and
post it to cfe-commits.
Posting to
On Dec 7, 2012, at 3:08 PM, Michael Han fragmentshad...@gmail.com wrote:
This small patch forbids C++11 attributes on explicit template
instantiations, as required by C++11 [dcl.attr.grammar] p4.
Hmm. It's easy to imagine attributes that are useful on explicit template
instantiations. We
On Dec 11, 2012, at 9:39 PM, Michael Han fragmentshad...@gmail.com wrote:
Thanks for the info. Do you happen to know why C++11 has this rule?
I got into this as I noted the same was implemented in gcc 4.8 [1] while
working on attributes. There are several options:
- Forbid C++11 attributes
Author: rjmccall
Date: Wed Dec 12 16:21:47 2012
New Revision: 170034
URL: http://llvm.org/viewvc/llvm-project?rev=170034view=rev
Log:
Rewrite calls to bitcast unprototyped functions when emitting a definition.
My variadics patch, r169588, changed these calls to typically be
bitcasts rather than
On Dec 12, 2012, at 2:40 PM, Eli Friedman eli.fried...@gmail.com wrote:
On Wed, Dec 12, 2012 at 2:21 PM, John McCall rjmcc...@apple.com wrote:
Author: rjmccall
Date: Wed Dec 12 16:21:47 2012
New Revision: 170034
URL: http://llvm.org/viewvc/llvm-project?rev=170034view=rev
Log:
Rewrite
On Dec 12, 2012, at 11:45 PM, endlessroad1...@gmail.com wrote:
Thanks, that's a very detailed and thorough comment.
MSDN page for __declspec(property):
http://msdn.microsoft.com/en-us/library/yhfk0thd.aspx
we can declare array-like property:
__declspec(property(get=GetX,
On Dec 17, 2012, at 5:17 PM, WenHan Gu (谷汶翰) wenhan...@mediatek.com wrote:
Actually, I have thought this assertion issue before modifying it.
However, I think, checking destruct-able in one callee is much simple and
clear than checking it in *all* caller, right?
If this has some design
On Dec 16, 2012, at 3:32 AM, Dmitri Gribenko griboz...@gmail.com wrote:
On Sun, Dec 16, 2012 at 2:38 AM, Sean Silva sil...@purdue.edu wrote:
This completely breaks the front page toctree structure since each of
the sections of this document appear as top-level entities there (I
already fixed
On Dec 14, 2012, at 10:41 AM, Eric Christopher echri...@gmail.com wrote:
Sure, but I just don't see that providing much value. The point of adding a
warning was to help catch things like typos in the sysroot path. What are
the chances that someone is going to mis-type the sysroot and also
On Dec 16, 2012, at 11:55 AM, Dmitri Gribenko griboz...@gmail.com wrote:
On Sun, Dec 16, 2012 at 9:21 PM, Sean Silva sil...@purdue.edu wrote:
btw I just noticed that you introduced new roles :arc-term:,
:revision:, :when-revised:. That's a really good idea!
This is to preserve the semantic
On Dec 17, 2012, at 11:14 AM, David Chisnall csda...@swan.ac.uk wrote:
On 17 Dec 2012, at 19:11, Rafael Espíndola wrote:
static bool hasAtomicCopyHelperAPI(const ObjCRuntime runtime) {
- // For now, only NeXT has these APIs.
- return runtime.isNeXTFamily();
+ return
On Dec 17, 2012, at 8:42 PM, Eric Christopher echri...@gmail.com wrote:
On Mon, Dec 17, 2012 at 7:14 PM, John McCall rjmcc...@apple.com wrote:
On Dec 14, 2012, at 10:41 AM, Eric Christopher echri...@gmail.com wrote:
Sure, but I just don't see that providing much value. The point of adding
On Dec 18, 2012, at 9:11 AM, Jordan Rose jordan_r...@apple.com wrote:
On Dec 17, 2012, at 18:41 , John McCall rjmcc...@apple.com wrote:
On Dec 16, 2012, at 3:32 AM, Dmitri Gribenko griboz...@gmail.com wrote:
On Sun, Dec 16, 2012 at 2:38 AM, Sean Silva sil...@purdue.edu wrote:
This completely
On Dec 18, 2012, at 2:31 AM, Joerg Sonnenberger jo...@britannica.bec.de wrote:
On Mon, Dec 17, 2012 at 07:14:41PM -0800, John McCall wrote:
In what reality is early in a system bootstrap a fairly standard use case?
system bootstrap as in building the system, not as in booting it.
Right, I
Author: rjmccall
Date: Wed Dec 19 20:45:14 2012
New Revision: 170639
URL: http://llvm.org/viewvc/llvm-project?rev=170639view=rev
Log:
Robustify the @encode code and add support for _Atomic.
Fixes PR14628.
Modified:
cfe/trunk/lib/AST/ASTContext.cpp
On Dec 20, 2012, at 11:27 AM, Bill Wendling isanb...@gmail.com wrote:
Author: void
Date: Thu Dec 20 13:27:06 2012
New Revision: 170722
URL: http://llvm.org/viewvc/llvm-project?rev=170722view=rev
Log:
Rename llvm::Attributes to llvm::Attribute.
Thanks, Bill, this is much better.
John.
On Dec 20, 2012, at 11:06 AM, John Marino dr...@marino.st wrote:
On 12/20/2012 20:02, Rafael Espíndola wrote:
I am willing to work with you to improve dragonfly.c test, but I'm not
willing to split the patch. It's just absurd and it should not be split.
I will update the patchset to fix
On Dec 20, 2012, at 12:13 PM, John McCall rjmcc...@apple.com wrote:
On Dec 20, 2012, at 11:06 AM, John Marino dr...@marino.st wrote:
On 12/20/2012 20:02, Rafael Espíndola wrote:
I am willing to work with you to improve dragonfly.c test, but I'm not
willing to split the patch. It's just
On Dec 20, 2012, at 12:55 PM, Ted Kremenek kreme...@apple.com wrote:
Author: kremenek
Date: Thu Dec 20 14:55:03 2012
New Revision: 170763
URL: http://llvm.org/viewvc/llvm-project?rev=170763view=rev
Log:
Warn if a __weak variable is initialized with an Objective-C object literal.
Such
On Dec 20, 2012, at 2:31 PM, Ted Kremenek kreme...@apple.com wrote:
Author: kremenek
Date: Thu Dec 20 16:31:27 2012
New Revision: 170777
URL: http://llvm.org/viewvc/llvm-project?rev=170777view=rev
Log:
Revert Warn if a __weak variable is initialized with an Objective-C object
literal.
On Dec 23, 2012, at 5:48 PM, NAKAMURA Takumi geek4ci...@gmail.com wrote:
Author: chapuni
Date: Sun Dec 23 19:48:59 2012
New Revision: 171013
URL: http://llvm.org/viewvc/llvm-project?rev=171013view=rev
Log:
CGDecl.cpp: Prune three descriptions in two methods,
On Dec 29, 2012, at 10:39 PM, Jordan Rose jordan_r...@apple.com wrote:
The array cases actually make logical sense, since the arrayBegin and the
arrayEndPointer parameters together represent a single logical parameter.
However, can we just convert these to (Mutable)ArrayRef and fix that?
No,
On Jan 3, 2013, at 5:10 PM, Dmitri Gribenko griboz...@gmail.com wrote:
On Fri, Jan 4, 2013 at 2:58 AM, John McCall rjmcc...@apple.com wrote:
On Dec 23, 2012, at 5:48 PM, NAKAMURA Takumi geek4ci...@gmail.com wrote:
Author: chapuni
Date: Sun Dec 23 19:48:59 2012
New Revision: 171013
URL
On Dec 20, 2012, at 11:25 PM, Saleem Abdulrasool compn...@compnerd.org wrote:
Add a new driver-only option `--supported-targets` which enumerates the
supported targets to stdout. This is an often requested feature, allowing
for a quick inspection of supported target architectures supported
On Jan 4, 2013, at 3:32 PM, Fariborz Jahanian fjahan...@apple.com wrote:
Author: fjahanian
Date: Fri Jan 4 17:32:24 2013
New Revision: 171555
URL: http://llvm.org/viewvc/llvm-project?rev=171555view=rev
Log:
objective-C arc: in copy helper function for
__strong __block variables, perform
On Jan 4, 2013, at 4:34 PM, Fariborz Jahanian fjahan...@apple.com wrote:
On Jan 4, 2013, at 3:56 PM, John McCall wrote:
On Jan 4, 2013, at 3:32 PM, Fariborz Jahanian fjahan...@apple.com wrote:
Author: fjahanian
Date: Fri Jan 4 17:32:24 2013
New Revision: 171555
URL: http://llvm.org/viewvc
On Sep 12, 2012, at 1:34 PM, Fariborz Jahanian wrote:
Author: fjahanian
Date: Wed Sep 12 15:34:47 2012
New Revision: 163738
URL: http://llvm.org/viewvc/llvm-project?rev=163738view=rev
Log:
objective-C arc: don't issue no explicit ownership warning when
__autoreleasing is explicitely added
On Sep 13, 2012, at 12:22 AM, Chandler Carruth wrote:
With all that discussion, here is an updated patch. I've included most of the
tricky test cases described here (where they seemed valuable) along with lots
of comments to help document some of this discussion and the conclusions.
+ //
On Sep 13, 2012, at 10:31 AM, jahanian wrote:
On Sep 12, 2012, at 5:02 PM, John McCall wrote:
On Sep 12, 2012, at 1:34 PM, Fariborz Jahanian wrote:
Author: fjahanian
Date: Wed Sep 12 15:34:47 2012
New Revision: 163738
URL: http://llvm.org/viewvc/llvm-project?rev=163738view=rev
Log
On Sep 13, 2012, at 10:29 AM, Fariborz Jahanian wrote:
Modified: cfe/trunk/lib/Sema/SemaType.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaType.cpp?rev=163813r1=163812r2=163813view=diff
==
---
On Sep 13, 2012, at 11:53 AM, Fariborz Jahanian wrote:
Author: fjahanian
Date: Thu Sep 13 13:53:14 2012
New Revision: 163824
URL: http://llvm.org/viewvc/llvm-project?rev=163824view=rev
Log:
Move back the stuff about missing ownership attribute warning
to SemaDeclObjC and apply some
://llvm.org/viewvc/llvm-project?rev=164143view=rev
Log:
c: warn when an integer value comparison with an
integral expression have the obvious result.
Patch reviewed by John McCall off line.
// rdar://12202422
Added:
cfe/trunk/test/Sema/outof-range-constant-compare.c
Modified:
cfe/trunk
On Sep 21, 2012, at 12:59 PM, Rafael Espíndola wrote:
Currently clang doesn't call SetLLVMFunctionAttributesForDefinition
for thunks, so they are missing the uwtable attribute which in turn
causes problems when stack walking is passing them.
Is the attached patch OK?
Yes, it looks fine.
Author: rjmccall
Date: Tue Sep 25 01:56:03 2012
New Revision: 164589
URL: http://llvm.org/viewvc/llvm-project?rev=164589view=rev
Log:
During jump-scope checking, build an ExprWithCleanups immediately
into the enclosing scope; this is a more accurate model but is
(I believe) unnecessary in my
Author: rjmccall
Date: Tue Sep 25 02:32:49 2012
New Revision: 164591
URL: http://llvm.org/viewvc/llvm-project?rev=164591view=rev
Log:
Add the Microsoft __is_interface_class type trait.
Patch by Andy Gibbs!
Modified:
cfe/trunk/docs/LanguageExtensions.html
Author: rjmccall
Date: Tue Sep 25 02:32:39 2012
New Revision: 164590
URL: http://llvm.org/viewvc/llvm-project?rev=164590view=rev
Log:
Fix for r163013 regression and further __interface enhancement.
Patch by Andy Gibbs!
Added:
cfe/trunk/test/CodeGenCXX/microsoft-interface.cpp
On Sep 20, 2012, at 11:39 AM, Andy Gibbs wrote:
On Monday, September 17, 2012 8:41 PM, Andy Gibbs wrote:
On Wednesday, September 12, 2012 10:15 PM, John McCall wrote:
On Sep 12, 2012, at 1:00 PM, Andy Gibbs wrote:
I had a few seconds before leaving: and I can confirm Aaron's testing
Author: rjmccall
Date: Tue Sep 25 03:00:39 2012
New Revision: 164592
URL: http://llvm.org/viewvc/llvm-project?rev=164592view=rev
Log:
In the MS ABI, ctors return 'this'. Patch by Dmitry Sokolov.
Modified:
cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp
On Sep 12, 2012, at 4:40 AM, SENTHIL KUMAR THANGAVELU wrote:
Hello all, John McCall,
I have attached a patch for the issue we discussed previously
http://clang-developers.42468.n3.nabble.com/Throwing-exceptions-from-temporary-object-s-destructor-td4026498.html;
specifically targetting
Author: rjmccall
Date: Tue Sep 25 04:10:17 2012
New Revision: 164593
URL: http://llvm.org/viewvc/llvm-project?rev=164593view=rev
Log:
Implement Mike Herrick's proposed noexcept mangling.
Modified:
cfe/trunk/lib/AST/ItaniumMangle.cpp
cfe/trunk/test/CodeGenCXX/mangle-exprs.cpp
Modified:
Author: rjmccall
Date: Tue Sep 25 05:10:39 2012
New Revision: 164597
URL: http://llvm.org/viewvc/llvm-project?rev=164597view=rev
Log:
When performing a ::delete of an object with a virtual destructor,
be sure to delete the complete object pointer, not the original
pointer. This is necessary if
On Sep 12, 2012, at 12:11 PM, r4start wrote:
On 12/09/12 20:19, John McCall wrote:
On Sep 12, 2012, at 3:51 AM, r4start wrote:
This patch is fix for this bug http://llvm.org/bugs/show_bug.cgi?id=13761.
+ static bool NeedThisReturn(GlobalDecl GD);
Please name this 'needsThisReturn'.
Done
On Sep 21, 2012, at 4:57 PM, Chad Rosier wrote:
Ping.
fno-fast-math.diff
Okay.
John.
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
value comparison with an
integral expression have the obvious result.
Patch reviewed by John McCall off line.
// rdar://12202422
This triggers a couple of warnings in Chromium. (We're tracking it at
http://crbug.com/151927) Most look like bugs, but this one doesn't
really:
/usr/local
On Sep 27, 2012, at 3:06 AM, Dmitri Gribenko wrote:
On Thu, Sep 27, 2012 at 12:57 PM, Sylvestre Ledru sylves...@debian.org
wrote:
Author: sylvestre
Date: Thu Sep 27 04:57:10 2012
New Revision: 164766
URL: http://llvm.org/viewvc/llvm-project?rev=164766view=rev
Log:
Fix a typo 'iff' =
On Sep 27, 2012, at 3:06 AM, Dmitri Gribenko wrote:
On Thu, Sep 27, 2012 at 12:57 PM, Sylvestre Ledru sylves...@debian.org
wrote:
Author: sylvestre
Date: Thu Sep 27 04:57:10 2012
New Revision: 164766
URL: http://llvm.org/viewvc/llvm-project?rev=164766view=rev
Log:
Fix a typo 'iff' =
On Oct 9, 2012, at 11:17 AM, Jeffrey Yasskin wrote:
On Tue, Oct 9, 2012 at 10:55 AM, Tijl Coosemans t...@coosemans.org wrote:
On 09-10-2012 19:27, Jeffrey Yasskin wrote:
On Tue, Oct 9, 2012 at 9:55 AM, Tijl Coosemans t...@coosemans.org wrote:
On 08-10-2012 01:34, Jeffrey Yasskin wrote:
On
On Oct 11, 2012, at 4:07 PM, Eric Christopher wrote:
-.toCharUnitsFromBits(target.getPointerSizeInBits());
+.toCharUnitsFromBits(target.getPointerSizeInBits(0));
addr.push_back(llvm::ConstantInt::get(Int64Ty, offset.getQuantity()));
On Oct 11, 2012, at 4:17 PM, Villmow, Micah wrote:
How is this handled in clang for OpenCL address spaces like
Local/Global/Constant? Maybe we can follow that same convention.
They don't map to any predictable LLVM address space — it's
implementation-specific.
John.
On Oct 13, 2012, at 2:56 PM, Nico Weber wrote:
Author: nico
Date: Sat Oct 13 16:56:05 2012
New Revision: 165885
URL: http://llvm.org/viewvc/llvm-project?rev=165885view=rev
Log:
Simplify. Suggestion by Sean Silva.
Modified:
cfe/trunk/lib/CodeGen/CodeGenModule.cpp
Modified:
available for this to work).
The use of __cxa_deleted_function needs to be guarded by some sort of
check; it isn't present on any released version of OS X, so generating
it there will lead to a guaranteed link error.
[+John McCall]
How else would we like to implement vtables for deleted
On Oct 16, 2012, at 4:24 PM, David Blaikie wrote:
On Tue, Oct 16, 2012 at 4:19 PM, John McCall rjmcc...@apple.com wrote:
On Oct 16, 2012, at 4:12 PM, David Blaikie wrote:
On Tue, Oct 16, 2012 at 4:09 PM, Eli Friedman eli.fried...@gmail.com
wrote:
On Tue, Oct 16, 2012 at 3:56 PM, David
Author: rjmccall
Date: Tue Oct 16 21:28:37 2012
New Revision: 166085
URL: http://llvm.org/viewvc/llvm-project?rev=166085view=rev
Log:
At -O0, prefer objc_storeStrong with a null new value to the
combination of a load+objc_release; this is generally better
for tools that try to track why values
Author: rjmccall
Date: Tue Oct 16 23:53:23 2012
New Revision: 166087
URL: http://llvm.org/viewvc/llvm-project?rev=166087view=rev
Log:
Organize and rename the magic constants for class flags.
No functionality change.
Modified:
cfe/trunk/lib/CodeGen/CGObjCMac.cpp
Modified:
Author: rjmccall
Date: Tue Oct 16 23:53:31 2012
New Revision: 166088
URL: http://llvm.org/viewvc/llvm-project?rev=166088view=rev
Log:
Set a special flag in class metadata when an Objective-C class
has ivars that require destruction, but none that require anything
except zero-initialization. This
On Oct 24, 2012, at 5:32 PM, Bill Wendling wrote:
Author: void
Date: Wed Oct 24 19:32:44 2012
New Revision: 166655
URL: http://llvm.org/viewvc/llvm-project?rev=166655view=rev
Log:
Revert r166647 to rethink the patch...
FWIW, Eli's review just means that you shouldn't ever add a warning
On Oct 24, 2012, at 7:06 PM, Bill Wendling wrote:
Yeah. I realize the text of the warning wasn't super. I'm rethinking the
whole patch though. As it turns out, people write bad ASM all the time, like
asm(foo %0, =r :);
I don't know if it's profitable to warn in this situation or the
On Oct 24, 2012, at 10:47 PM, Bill Wendling wrote:
On Oct 24, 2012, at 7:37 PM, John McCall rjmcc...@apple.com wrote:
On Oct 24, 2012, at 7:06 PM, Bill Wendling wrote:
Yeah. I realize the text of the warning wasn't super. I'm rethinking the
whole patch though. As it turns out, people write
On Oct 28, 2012, at 11:50 PM, Nick Lewycky wrote:
This patch is the AST-changing bit broken out of the patch proposed here:
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20121008/065734.html
to change how using-directives are stored, and remove them from the land of
NamedDecl.
On Oct 29, 2012, at 5:34 AM, Konstantin Tokarev wrote:
26.10.2012, 13:33, Konstantin Tokarev annu...@yandex.ru:
Attached patch with added unit test.
Ping
There's no need to constrain this to only static methods — it should apply to
any sort of non-instance declaration (e.g. a static data
On Oct 30, 2012, at 8:43 AM, Axel Naumann wrote:
We'd like to make use of the RAIIs that make using the Parser so much
safer. The attached patch publishes them; it also combines
DestroyTemplateIdAnnotationsRAIIObj with the other RAIIs.
Note that the patch contains the result of svn diff
On Oct 30, 2012, at 5:28 PM, Rafael Espíndola wrote:
We have some old benchmark results in www/timing-data/. Are they still
relevant? If no, can we remove them?
Go ahead.
John.
___
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
On Oct 25, 2012, at 1:39 PM, Lang Hames wrote:
Tim Northover pointed out that there's a flaw in my recent FP_CONTRACT patch
(r166383). That patch restricted FP_CONTRACT (or rather
tok::annot_pragma_fp_contract) to appearing as the first token in a compound
statement. The problem with my
On Nov 2, 2012, at 3:05 PM, Nico Weber wrote:
This regressed v8 garbage collection performance by 10%. Not sure if
the optimizations you're alluding to would help. I filed PR14206 for
this.
A profile would help a lot. Your code is assigning PODs somewhere,
and we can almost do a certainly
On Nov 2, 2012, at 3:51 PM, Fariborz Jahanian wrote:
Author: fjahanian
Date: Fri Nov 2 17:51:18 2012
New Revision: 167331
URL: http://llvm.org/viewvc/llvm-project?rev=167331view=rev
Log:
objective-C mrr block. Block variable layout metadata in
mrr mode.
Added:
On Jul 18, 2012, at 2:28 AM, Chandler Carruth wrote:
On Tue, Jul 17, 2012 at 11:47 PM, Richard Smith rich...@metafoo.co.uk wrote:
On Tue, Jul 17, 2012 at 11:26 PM, Chandler Carruth chandl...@google.com
wrote:
I find the definition of APInt's operator== deeply troubling. Why *assert* if
the
On Jul 18, 2012, at 5:37 PM, Tanya Lattner wrote:
On Jul 18, 2012, at 5:08 AM, Benyei, Guy wrote:
Hi Tanya,
Looks good and usefull, but I'm not sure if it should be clang's decision if
storing and loading vec4s is better than vec3.
The idea was to have Clang generate code that the
On Jul 18, 2012, at 6:23 PM, Sean Silva wrote:
I know vectors aren't part of C11/C++11, but doesn't this violate the
memory model? In particular, doesn't it introduce spurious stores?
Forgive me if there's some context behind this that I'm missing which
makes this concern irrelevant.
I
On Jul 19, 2012, at 4:44 AM, Timur Iskhodzhanov wrote:
On Thu, Jul 19, 2012 at 3:37 PM, João Matos ripzonetri...@gmail.com wrote:
Not sure who is responsible for the MS mangler, the LLVM code owner
list doesn't list anyone directly responsible for non-codegen Windows
stuff. It would be nice to
On Jul 19, 2012, at 5:33 AM, Jonathan Schleifer wrote:
Anything wrong with that patch? I got no feedback at all, neither from you
nor anybode else.
Could anybody tell me if this is correct and if so apply it? Because I
already have the next patch ready ;).
Could you explain why you're
On Jul 19, 2012, at 2:59 PM, Chandler Carruth wrote:
On Thu, Jul 19, 2012 at 2:16 PM, John McCall rjmcc...@apple.com wrote:
On Jul 19, 2012, at 1:39 PM, Timur Iskhodzhanov wrote:
Otherwise it seems very, very ad-hoc,
I do think this is more of a general rule as the same ABCD encoding
On Jul 20, 2012, at 8:48 AM, Douglas Gregor wrote:
On Jul 19, 2012, at 10:00 AM, Alexander Kornienko ale...@google.com wrote:
On Tue, Jul 17, 2012 at 7:55 PM, Douglas Gregor dgre...@apple.com wrote:
Okay, that's fair; but this could trivially be added as a parameter to the
existing XML
On Jul 22, 2012, at 11:33 AM, Jonathan Sauer wrote:
turns out the fix is even simpler: As the whole POD for the purpose of
layout-business is
already taken care of by the layout builder (albeit without considering
bitfields ATM), there
is no need to duplicate the logic in the new
On Jul 23, 2012, at 7:53 AM, Timur Iskhodzhanov wrote:
Can you please review this patch?
It fixes the mangling ( http://llvm.org/bugs/show_bug.cgi?id=13207 ),
adds some comments as well as adding a lot of tests for the mangler.
I've intentionally added a few extra namespaces to the test to
On Jul 23, 2012, at 4:52 AM, Timur Iskhodzhanov wrote:
Hi Charles, John,
Can you please see
http://llvm.org/bugs/show_bug.cgi?id=13434
?
It seems like this case has never been tested before.
I've written some tests and made a simple fix to the code.
It's not thoroughly tested on all
On Jul 20, 2012, at 7:16 AM, Timur Iskhodzhanov wrote:
See attached:
I've generated some more test cases for more coverage - all are OK
with the bug_13389_2 patch.
Also slightly re-factored the code to be ... well, a bit more readable.
Some thoughts:
I've noticed there are a few places in
On Jul 24, 2012, at 2:38 AM, Timur Iskhodzhanov wrote:
On Mon, Jul 23, 2012 at 9:27 PM, John McCall rjmcc...@apple.com wrote:
On Jul 23, 2012, at 7:53 AM, Timur Iskhodzhanov wrote:
Can you please review this patch?
It fixes the mangling ( http://llvm.org/bugs/show_bug.cgi?id=13207 ),
adds
On Jul 25, 2012, at 9:15 AM, Timur Iskhodzhanov wrote:
On Mon, Jul 23, 2012 at 10:00 PM, John McCall rjmcc...@apple.com wrote:
On Jul 20, 2012, at 7:16 AM, Timur Iskhodzhanov wrote:
See attached:
I've generated some more test cases for more coverage - all are OK
with the bug_13389_2 patch
On Jul 26, 2012, at 7:47 AM, Timur Iskhodzhanov wrote:
On Thu, Jul 26, 2012 at 5:59 PM, Timur Iskhodzhanov timur...@google.com
wrote:
I've started with a small r160783 that ...
On Mon, Jul 23, 2012 at 9:37 PM, John McCall rjmcc...@apple.com wrote:
It would be good to at least come up
1 - 100 of 2908 matches
Mail list logo
