Author: rikka
Date: Mon Nov 12 17:48:05 2012
New Revision: 167783
URL: http://llvm.org/viewvc/llvm-project?rev=167783view=rev
Log:
Enable C++11 attribute syntax for warn_unused_result and allow it to be
applied to CXXRecordDecls, where functions with that return type will
inherit the
Author: rikka
Date: Mon Nov 12 18:18:47 2012
New Revision: 167791
URL: http://llvm.org/viewvc/llvm-project?rev=167791view=rev
Log:
A couple of small fixes to r167783
Modified:
cfe/trunk/include/clang/Basic/Attr.td
cfe/trunk/lib/Sema/SemaDeclAttr.cpp
On Mon, Nov 12, 2012 at 3:56 PM, Richard Smith rich...@metafoo.co.ukwrote:
On Mon, Nov 12, 2012 at 3:48 PM, Kaelyn Uhrain ri...@google.com wrote:
Author: rikka
Date: Mon Nov 12 17:48:05 2012
New Revision: 167783
URL: http://llvm.org/viewvc/llvm-project?rev=167783view=rev
Log
Author: rikka
Date: Tue Nov 13 15:23:31 2012
New Revision: 167873
URL: http://llvm.org/viewvc/llvm-project?rev=167873view=rev
Log:
For classes that have the warn_unused_result attribute, don't apply the
attribute to the class' methods even when they return an instance of the
class (e.g.
'.
…except for operator on streams. Hm.
Jordan
On Nov 13, 2012, at 13:23 , Kaelyn Uhrain ri...@google.com wrote:
Author: rikka
Date: Tue Nov 13 15:23:31 2012
New Revision: 167873
URL: http://llvm.org/viewvc/llvm-project?rev=167873view=rev
Log:
For classes that have
Author: rikka
Date: Mon Nov 19 12:49:53 2012
New Revision: 168317
URL: http://llvm.org/viewvc/llvm-project?rev=168317view=rev
Log:
When adding a NamedDecl to a correction, add the underlying Decl (via
getUnderlyingDecl()) so that derivatives of
CorrectionCandidateCallback::ValidateCandidate(...)
Author: rikka
Date: Thu Oct 25 14:43:57 2012
New Revision: 166711
URL: http://llvm.org/viewvc/llvm-project?rev=166711view=rev
Log:
Move the input files for test/PCH/badpch.c under test/PCH/Inputs/.
Added:
cfe/trunk/test/PCH/Inputs/badpch-dir.h.gch/
Author: rikka
Date: Tue Jan 17 23:58:54 2012
New Revision: 148382
URL: http://llvm.org/viewvc/llvm-project?rev=148382view=rev
Log:
Convert DiagnoseEmptyLookup to use correction callbacks.
No new unit tests yet as there is no behavioral change
(except for slightly more specific filtering in
Author: rikka
Date: Wed Jan 18 15:41:41 2012
New Revision: 148420
URL: http://llvm.org/viewvc/llvm-project?rev=148420view=rev
Log:
Convert SemaDecl.cpp to pass callback objects to CorrectTypo.
Includes tests highlighting the cases where accuracy has improved
(there is one call that does no
Author: rikka
Date: Wed Jan 18 18:33:34 2012
New Revision: 148441
URL: http://llvm.org/viewvc/llvm-project?rev=148441view=rev
Log:
Remove the now-unused CorrectTypoContext enum.
Modified:
cfe/trunk/include/clang/Sema/Sema.h
cfe/trunk/lib/Sema/SemaLookup.cpp
Modified:
On Thu, Jan 19, 2012 at 9:56 AM, Kostya Serebryany k...@google.com wrote:
On Thu, Jan 19, 2012 at 1:18 AM, Anton Korobeynikov
an...@korobeynikov.info wrote:
Hi Kostya,
The patches are attached, the llvm patch is also published
here: http://codereview.appspot.com/5544058/
What is the
On Thu, Jan 19, 2012 at 10:16 AM, Kostya Serebryany k...@google.com wrote:
On Thu, Jan 19, 2012 at 10:14 AM, Kaelyn Uhrain ri...@google.com wrote:
On Thu, Jan 19, 2012 at 9:56 AM, Kostya Serebryany k...@google.comwrote:
On Thu, Jan 19, 2012 at 1:18 AM, Anton Korobeynikov
Author: rikka
Date: Mon Jan 23 14:18:59 2012
New Revision: 148720
URL: http://llvm.org/viewvc/llvm-project?rev=148720view=rev
Log:
In CorrectTypo, use the cached correction as a starting point instead.
Previously, for unqualified lookups, a positive cache hit is used as the
only non-keyword
Please ignore this review request. I screwed up the patch upload AND the
description (after returning from lunch, I'd forgotten I hadn't submitted
the changes I meant to have reviewed to my local git repo yet).
Thanks,
Kaelyn
On Mon, Jan 23, 2012 at 12:39 PM, ri...@google.com wrote:
Reviewers:
Author: rikka
Date: Tue Jan 24 13:45:35 2012
New Revision: 148850
URL: http://llvm.org/viewvc/llvm-project?rev=148850view=rev
Log:
Small code cleanup/simplification in Sema::ClassifyName.
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
Modified: cfe/trunk/lib/Sema/SemaDecl.cpp
URL:
Author: rikka
Date: Wed Jan 25 12:37:44 2012
New Revision: 148962
URL: http://llvm.org/viewvc/llvm-project?rev=148962view=rev
Log:
Add custom callback object for typo correction in BuildRecoveryCallExpr.
The new callback, in addition to limiting which keywords to include in
the pool of typo
Ping? I'd at least like someone more familiar with the parser to give this
patch a once-over before committing it.
Thanks,
Kaelyn
On Mon, Jan 23, 2012 at 12:45 PM, ri...@google.com wrote:
Reviewers: kyrtzidis_apple.com,
Description:
Pass a typo correction callback object from ParseCastExpr
Author: rikka
Date: Wed Jan 25 14:49:08 2012
New Revision: 148973
URL: http://llvm.org/viewvc/llvm-project?rev=148973view=rev
Log:
Avoid correcting unknown identifiers to types where types aren't allowed.
Pass a typo correction callback object from ParseCastExpr to
Sema::ActOnIdExpression to be
Author: rikka
Date: Wed Jan 25 15:11:35 2012
New Revision: 148979
URL: http://llvm.org/viewvc/llvm-project?rev=148979view=rev
Log:
Allow typo correction to be disabled in BuildOverloadedCallExpr variant.
This suppresses typo correction for auto-generated call expressions such
as to 'begin' or
Author: rikka
Date: Tue Jan 31 17:49:25 2012
New Revision: 149451
URL: http://llvm.org/viewvc/llvm-project?rev=149451view=rev
Log:
Make the callback object to Sema::CorrectTypo mandatory.
Modified:
cfe/trunk/include/clang/Sema/Sema.h
cfe/trunk/lib/Sema/SemaCXXScopeSpec.cpp
Author: rikka
Date: Mon Feb 6 19:32:58 2012
New Revision: 149953
URL: http://llvm.org/viewvc/llvm-project?rev=149953view=rev
Log:
Remove the unused TypoCorrectionConsumer::MaxEditDistance.
MaxEditDistance was effectively unused as it being initialized to the max
unsigned valued but never
Replace the simple Levenshtein edit distance for typo correction
candidates--and the hacky way adding namespace qualifiers would affect
the edit distance--with a synthetic edit distance comprised of several
factors and their relative weights. This also allows the typo correction
callback object
Author: rikka
Date: Tue Feb 14 12:56:48 2012
New Revision: 150495
URL: http://llvm.org/viewvc/llvm-project?rev=150495view=rev
Log:
Use several weighted factors to determine typo candidate viablity.
Replace the simple Levenshtein edit distance for typo correction
candidates--and the hacky way
Author: rikka
Date: Wed Feb 15 16:14:18 2012
New Revision: 150622
URL: http://llvm.org/viewvc/llvm-project?rev=150622view=rev
Log:
Improve typo correction involving nested name specifiers.
Snooping in other namespaces when the identifier being corrected is
already qualified (i.e. a valid
Author: rikka
Date: Wed Feb 15 16:59:03 2012
New Revision: 150629
URL: http://llvm.org/viewvc/llvm-project?rev=150629view=rev
Log:
Silence a valgrind warning, and remove an unused var.
Modified:
cfe/trunk/lib/Sema/SemaLookup.cpp
Modified: cfe/trunk/lib/Sema/SemaLookup.cpp
URL:
Author: rikka
Date: Thu Feb 16 16:40:59 2012
New Revision: 150735
URL: http://llvm.org/viewvc/llvm-project?rev=150735view=rev
Log:
Avoid infinite mutual recursion in DiagnoseInvalidRedeclaration.
Don't try to typo-correct a method redeclaration to declarations not in
the current record as it
Author: rikka
Date: Tue Feb 21 19:03:07 2012
New Revision: 151112
URL: http://llvm.org/viewvc/llvm-project?rev=151112view=rev
Log:
Fix typo correction of template arguments to once again allow type names.
Modified:
cfe/trunk/include/clang/Parse/Parser.h
cfe/trunk/lib/Parse/ParseExpr.cpp
Author: rikka
Date: Fri May 18 18:42:49 2012
New Revision: 157085
URL: http://llvm.org/viewvc/llvm-project?rev=157085view=rev
Log:
Suggest adding 'typename' when it would make the compiler
accept the template argument expression as a type.
Modified:
Author: rikka
Date: Thu May 31 18:32:58 2012
New Revision: 157781
URL: http://llvm.org/viewvc/llvm-project?rev=157781view=rev
Log:
In TypoCorrectionConsumer, BestResults to CorrectionResults to lessen
the confusion among all of the uses of Best* in relation to the set of
possible typo correction
Author: rikka
Date: Fri Jun 1 13:11:16 2012
New Revision: 157823
URL: http://llvm.org/viewvc/llvm-project?rev=157823view=rev
Log:
Don't allow multiple correction candidates that have the same identifier
but different nested name specifiers to quietly clobber each other so
only one remains if
Author: rikka
Date: Wed Jun 6 15:54:51 2012
New Revision: 158109
URL: http://llvm.org/viewvc/llvm-project?rev=158109view=rev
Log:
Allow CorrectTypo to add/modify nested name qualifiers to typos that
are otherwise too short to try to correct.
The TODOs added to two of the tests are for existing
Author: rikka
Date: Thu Jun 7 18:57:08 2012
New Revision: 158177
URL: http://llvm.org/viewvc/llvm-project?rev=158177view=rev
Log:
Ignore corrections to functions with bodies when deciding which
correction to use for an invalid function redeclaration.
Modified:
Author: rikka
Date: Thu Jun 7 18:57:12 2012
New Revision: 158178
URL: http://llvm.org/viewvc/llvm-project?rev=158178view=rev
Log:
Teach the FixIt in DiagnoseInvalidRedeclaration how to replace the written
nested name specifiers in addition to the function's identifier when the
correction has a
Author: rikka
Date: Thu Jun 7 20:07:26 2012
New Revision: 158185
URL: http://llvm.org/viewvc/llvm-project?rev=158185view=rev
Log:
Fix up the 'typename' suggestion logic introduced in r157085, based on
feedback from Doug Gregor.
Modified:
cfe/trunk/lib/Sema/SemaTemplate.cpp
On Thu, Jun 7, 2012 at 3:47 PM, Douglas Gregor dgre...@apple.com wrote:
On May 18, 2012, at 4:42 PM, Kaelyn Uhrain wrote:
Author: rikka
Date: Fri May 18 18:42:49 2012
New Revision: 157085
URL: http://llvm.org/viewvc/llvm-project?rev=157085view=rev
Log:
Suggest adding 'typename
On Thu, Jun 7, 2012 at 5:15 PM, Douglas Gregor dgre...@apple.com wrote:
On Jun 7, 2012, at 4:57 PM, Kaelyn Uhrain wrote:
Author: rikka
Date: Thu Jun 7 18:57:12 2012
New Revision: 158178
URL: http://llvm.org/viewvc/llvm-project?rev=158178view=rev
Log:
Teach the FixIt
Author: rikka
Date: Wed Jun 13 12:05:13 2012
New Revision: 158406
URL: http://llvm.org/viewvc/llvm-project?rev=158406view=rev
Log:
Remove the trailing backslash from the comment to remove the warning about
a multi-line comment, fixing builds with e.g. -Werror=comment enabled.
Modified:
Author: rikka
Date: Fri Jun 15 18:45:51 2012
New Revision: 158572
URL: http://llvm.org/viewvc/llvm-project?rev=158572view=rev
Log:
Move isCXXSimpleTypeSpecifier from Parser to Sema and tweak it for wider use.
Modified:
cfe/trunk/include/clang/Parse/Parser.h
Author: rikka
Date: Fri Jun 15 18:45:58 2012
New Revision: 158573
URL: http://llvm.org/viewvc/llvm-project?rev=158573view=rev
Log:
Recover when correcting an unknown type name to a keyword like struct.
Modified:
cfe/trunk/include/clang/Sema/Sema.h
cfe/trunk/lib/Parse/ParseDecl.cpp
Author: rikka
Date: Mon Jun 18 19:37:47 2012
New Revision: 158691
URL: http://llvm.org/viewvc/llvm-project?rev=158691view=rev
Log:
Improve the error message when a function overload candidate is rejected
because it expects a reference and receives a non-l-value.
For example, given:
int
Author: rikka
Date: Tue Jun 19 13:38:00 2012
New Revision: 158733
URL: http://llvm.org/viewvc/llvm-project?rev=158733view=rev
Log:
Remove some debugging code that snuck into r158691.
Modified:
cfe/trunk/lib/Sema/SemaOverload.cpp
Modified: cfe/trunk/lib/Sema/SemaOverload.cpp
URL:
Author: rikka
Date: Tue Jun 19 19:36:03 2012
New Revision: 158772
URL: http://llvm.org/viewvc/llvm-project?rev=158772view=rev
Log:
Add the PCH file name to the message about not being able to read the PCH.
Also add a couple of unit tests to check the invalid-PCH error messages
to satisfy PR4568
,
The test cfe/trunk/test/PCH/badpch.c fails on builder
http://lab.llvm.org:8011/builders/clang-X86_64-freebsd/builds/3155
Please have a look at this?
Thanks
Galina
On Tue, Jun 19, 2012 at 5:36 PM, Kaelyn Uhrain ri...@google.com wrote:
Author: rikka
Date: Tue Jun 19 19:36:03 2012
New
This should be fixed in r158841
On Wed, Jun 20, 2012 at 11:25 AM, Kaelyn Uhrain ri...@google.com wrote:
This looks like a difference in how the calls clang uses to open and read
pch files behave under FreeBSD vs Linux when operating on a directory
instead of a normal file. I'm looking deeper
Author: rikka
Date: Fri Jun 22 18:37:05 2012
New Revision: 159046
URL: http://llvm.org/viewvc/llvm-project?rev=159046view=rev
Log:
Perform typo correction for base class specifiers.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
cfe/trunk/lib/Parse/ParseDeclCXX.cpp
Author: rikka
Date: Fri Jun 29 16:30:39 2012
New Revision: 159464
URL: http://llvm.org/viewvc/llvm-project?rev=159464view=rev
Log:
In Sema::ClassifyName, try to avoid nonsensical corrections to
keywords when doing type correction.
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
On Fri, Jun 29, 2012 at 2:36 PM, David Blaikie dblai...@gmail.com wrote:
On Fri, Jun 29, 2012 at 2:30 PM, Kaelyn Uhrain ri...@google.com wrote:
Author: rikka
Date: Fri Jun 29 16:30:39 2012
New Revision: 159464
URL: http://llvm.org/viewvc/llvm-project?rev=159464view=rev
Log:
In Sema
This patch is a rough draft of my attempt to replace the
Sema::CorrectTypoContext enum with a callback object for performing finer
grained validation of potential typo corrections. This version just
includes a wrapper for Sema::CorrectTypo to translate a CorrectTypoContext
value into a
Way too early in the morning... originally hit Reply instead of Reply
All and then when I resent the email to the mailing list I forgot to
attach the patch. D'oh!
On Wed, Jan 11, 2012 at 9:53 AM, Kaelyn Uhrain ri...@google.com wrote:
On Tue, Jan 10, 2012 at 8:23 PM, Douglas Gregor dgre
On Tue, Jan 10, 2012 at 8:23 PM, Douglas Gregor dgre...@apple.com wrote:
On Jan 10, 2012, at 5:06 PM, Kaelyn Uhrain wrote:
This patch is a rough draft of my attempt to replace the
Sema::CorrectTypoContext enum with a callback object for performing finer
grained validation of potential typo
Author: rikka
Date: Wed Jan 11 13:37:46 2012
New Revision: 147962
URL: http://llvm.org/viewvc/llvm-project?rev=147962view=rev
Log:
Add initial callback object support to Sema::CorrectTypo.
Also includes two examples of the callback: a wrapper/replacement for
the CorrectTypoContext enum, and a
On Wed, Jan 11, 2012 at 11:49 AM, Chandler Carruth chandl...@gmail.comwrote:
A few comments inline...
On Wed, Jan 11, 2012 at 11:37 AM, Kaelyn Uhrain ri...@google.com wrote:
Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema
Author: rikka
Date: Wed Jan 11 15:17:51 2012
New Revision: 147968
URL: http://llvm.org/viewvc/llvm-project?rev=147968view=rev
Log:
Fix the caching in CorrectTypo so that other non-keyword identifiers
are still added if the cached correction fails validation.
Also fix a copy-and-paste error in a
Author: rikka
Date: Thu Jan 12 13:27:05 2012
New Revision: 148037
URL: http://llvm.org/viewvc/llvm-project?rev=148037view=rev
Log:
Convert SemaInit.cpp to pass a callback object to CorrectTypo.
And once again improve the typo correction results in certain
situations just by moving the existing
Author: rikka
Date: Thu Jan 12 16:32:39 2012
New Revision: 148052
URL: http://llvm.org/viewvc/llvm-project?rev=148052view=rev
Log:
Convert SemaCXXScopeSpec.cpp to pass a callback object to CorrectTypo,
improvng the typo correction results in certain situations.
Modified:
Author: rikka
Date: Thu Jan 12 19:32:50 2012
New Revision: 148085
URL: http://llvm.org/viewvc/llvm-project?rev=148085view=rev
Log:
Fix up the calls to CorrectTypo in Sema*ObjC.cpp to use callback
objects, and add a basic CorrectionCandidateCallback template class
to simplify the fixups.
On Thu, Jan 12, 2012 at 5:47 PM, Chandler Carruth chandl...@google.comwrote:
On Thu, Jan 12, 2012 at 5:32 PM, Kaelyn Uhrain ri...@google.com wrote:
Author: rikka
Date: Thu Jan 12 19:32:50 2012
New Revision: 148085
URL: http://llvm.org/viewvc/llvm-project?rev=148085view=rev
Log:
Fix up
Author: rikka
Date: Fri Jan 13 15:28:55 2012
New Revision: 148140
URL: http://llvm.org/viewvc/llvm-project?rev=148140view=rev
Log:
Convert SemaExprMember.cpp to pass a callback object to CorrectTypo,
improving the typo correction results in certain situations.
This is also the first typo
Author: rikka
Date: Fri Jan 13 17:10:36 2012
New Revision: 148155
URL: http://llvm.org/viewvc/llvm-project?rev=148155view=rev
Log:
Convert SemaTemplate*.cpp to pass a callback object to CorrectTypo.
The change to SemaTemplateVariadic.cpp improves the typo correction
results in certain
On Sun, Mar 4, 2012 at 9:48 PM, Argyrios Kyrtzidis akyr...@gmail.comwrote:
Author: akirtzidis
Date: Sun Mar 4 23:48:09 2012
New Revision: 152017
URL: http://llvm.org/viewvc/llvm-project?rev=152017view=rev
Log:
[preprocessor] Enhance the preprocessor callbacks:
-Add location parameter
Doug,
This band-aid looks good to me, though adding another special flag to the
correction callback object somehow seems... dirty. I've added tackling the
FIXMEs for actually performing the correction to my queue of things to
address once I'm working on clang itself again. ;)
Thanks for taking
Author: rikka
Date: Tue Apr 3 13:20:11 2012
New Revision: 153962
URL: http://llvm.org/viewvc/llvm-project?rev=153962view=rev
Log:
Replace the workaround from r153445 with a proper fix.
Infinite recursion was happening when DiagnoseInvalidRedeclaration
called ActOnFunctionDeclarator to check if
Author: rikka
Date: Tue Apr 10 17:27:27 2012
New Revision: 154443
URL: http://llvm.org/viewvc/llvm-project?rev=154443view=rev
Log:
Fix quoting to allow shell expansion to occur for shell variables
introduced by the test harness' expansion of %t.
Modified:
Hi,
This warning is to help make code like:
class Foo {
public:
enum Bar { X, Y };
void SetBar(Bar bar); // Setter
Bar Bar() // Getter
private:
Bar bar_;
};
void Foo::SetBar(Bar bar) { bar_ = bar; }
Foo::Bar Foo::Bar() { return bar_; }
be a bit easier to diagnose. Currently clang
Ping.
Unless I hear something, I'll go ahead and commit the patch tomorrow
morning.
On Wed, Apr 11, 2012 at 1:44 PM, Kaelyn Uhrain ri...@google.com wrote:
Hi,
This warning is to help make code like:
class Foo {
public:
enum Bar { X, Y };
void SetBar(Bar bar); // Setter
Bar Bar
in the current lexical context, reducing the number of
other unit test failures from 27 to 20. I also switched the warning to
DefaultIgnore to take care of the remaining 20 failures (since the tests
otherwise work as expected).
Cheers,
/Manuel
On Thu, Apr 12, 2012 at 10:05 PM, Kaelyn Uhrain ri
of unit tests that fail with the flag default-enabled to 13.
Cheers,
Kaelyn
On Fri, Apr 13, 2012 at 11:29 AM, Kaelyn Uhrain ri...@google.com wrote:
Thanks for the review Manuel!
On Fri, Apr 13, 2012 at 9:13 AM, Manuel Klimek kli...@google.com wrote:
+ function %0 shadows %1 %0; uses of %1 %0
On Sat, Apr 14, 2012 at 3:44 AM, Manuel Klimek kli...@google.com wrote:
On Fri, Apr 13, 2012 at 7:57 PM, Kaelyn Uhrain ri...@google.com wrote:
I just realized that this check probably only applies to C++ code since
(unless things changed in a recent standard) C doesn't allow struct/enum
Funny you should be making this change, as it is how I originally had the
TypoEditDistanceMap. In r134009 last June, Doug changed TypoEditDistanceMap
to [d]ynamically allocate the StringMaps used in typo correction so that
we don't rely on the existence of a copy constructor.
For the record, I
Author: rikka
Date: Thu Apr 19 18:17:45 2012
New Revision: 155163
URL: http://llvm.org/viewvc/llvm-project?rev=155163view=rev
Log:
In Parser::isCXXDeclarationSpecifier, consider a non-type identifier
followed by an identifier as declaration specificer (except for ObjC).
This allows e.g. an
Author: rikka
Date: Thu Apr 19 18:26:12 2012
New Revision: 155165
URL: http://llvm.org/viewvc/llvm-project?rev=155165view=rev
Log:
Re-add the closing '}' for the namespace I accidentally deleted when
removing a (new) duplicate test whose only difference was the tag type
being an enum instead of a
On Thu, Apr 19, 2012 at 4:54 PM, David Blaikie dblai...@gmail.com wrote:
On Thu, Apr 19, 2012 at 4:17 PM, Kaelyn Uhrain ri...@google.com wrote:
Author: rikka
Date: Thu Apr 19 18:17:45 2012
New Revision: 155163
URL: http://llvm.org/viewvc/llvm-project?rev=155163view=rev
Log
This patch adds a suggestion and related fixit for when a member reference
using '.' such as foo.bar() fails because bar() is not a member of foo,
but foo defines an operator- and bar() is a member of the object returned
by foo's operator-. A more concrete case where this is helpful is with
On Tue, Apr 24, 2012 at 2:37 PM, David Blaikie dblai...@gmail.com wrote:
On Tue, Apr 24, 2012 at 2:28 PM, Kaelyn Uhrain ri...@google.com wrote:
This patch adds a suggestion and related fixit for when a member
reference
using '.' such as foo.bar() fails because bar() is not a member of foo
Author: rikka
Date: Wed Apr 25 14:49:54 2012
New Revision: 155580
URL: http://llvm.org/viewvc/llvm-project?rev=155580view=rev
Log:
Add an error message with fixit hint for changing '.' to '-'.
This is mainly for attempting to recover in cases where a class provides
a custom operator- and a '.'
Author: rikka
Date: Thu Apr 26 18:36:17 2012
New Revision: 155677
URL: http://llvm.org/viewvc/llvm-project?rev=155677view=rev
Log:
Add note to help explain why a tag such as 'struct' is needed to refer
to a given type, when the reason is that there is a non-type decl with
the same name.
Author: rikka
Date: Fri Apr 27 13:26:49 2012
New Revision: 155723
URL: http://llvm.org/viewvc/llvm-project?rev=155723view=rev
Log:
Imrpove the note text for when a non-type decl hides a tag type
Modified:
cfe/trunk/include/clang/Basic/DiagnosticCommonKinds.td
On Thu, Apr 26, 2012 at 6:08 PM, David Blaikie dblai...@gmail.com wrote:
On Thu, Apr 26, 2012 at 5:37 PM, Richard Smith rich...@metafoo.co.uk
wrote:
On Thu, Apr 26, 2012 at 4:54 PM, David Blaikie dblai...@gmail.com
wrote:
On Thu, Apr 26, 2012 at 4:36 PM, Kaelyn Uhrain ri...@google.com
Author: rikka
Date: Mon Apr 30 20:16:25 2012
New Revision: 155870
URL: http://llvm.org/viewvc/llvm-project?rev=155870view=rev
Log:
A couple of very small tweaks suggested by Doug in reply to r155580 and r155163.
Modified:
cfe/trunk/lib/Parse/ParseTentative.cpp
Author: rikka
Date: Mon Apr 30 20:17:53 2012
New Revision: 155871
URL: http://llvm.org/viewvc/llvm-project?rev=155871view=rev
Log:
Let's use the correct bool this time.
Modified:
cfe/trunk/lib/Sema/SemaExprMember.cpp
Modified: cfe/trunk/lib/Sema/SemaExprMember.cpp
URL:
On Mon, Apr 30, 2012 at 5:18 PM, Douglas Gregor dgre...@apple.com wrote:
On Apr 25, 2012, at 12:49 PM, Kaelyn Uhrain ri...@google.com wrote:
Author: rikka
Date: Wed Apr 25 14:49:54 2012
New Revision: 155580
URL: http://llvm.org/viewvc/llvm-project?rev=155580view=rev
Log:
Add
Author: rikka
Date: Tue May 1 19:11:40 2012
New Revision: 155965
URL: http://llvm.org/viewvc/llvm-project?rev=155965view=rev
Log:
Try harder to recognize hidden tag type names in potential declarations instead
of giving unhelpful errors about undeclared identifers and missing semicolons.
Author: rikka
Date: Thu May 3 14:46:38 2012
New Revision: 156091
URL: http://llvm.org/viewvc/llvm-project?rev=156091view=rev
Log:
Silence unused-variable warning when assertions are disabled.
Modified:
cfe/trunk/lib/Sema/AnalysisBasedWarnings.cpp
Modified:
bounding size for the set?
Thanks,
Kaelyn
On Mon, Mar 14, 2011 at 10:28 AM, Douglas Gregor dgre...@apple.com wrote:
On Mar 9, 2011, at 11:35 AM, Kaelyn Uhrain wrote:
I just finished up a new version of my patch earlier this week, which no
longer uses the RecursiveASTVisitor (per chandlerc's
On Mon, Mar 14, 2011 at 10:28 AM, Douglas Gregor dgre...@apple.com wrote:
1) Don't walk the namespaces at all; let the check against all of
the identifiers in the translation unit winnow the list down to the best
candidates based on name alone. We don't know which of these candidates
Hello Doug,
On Wed, Jun 1, 2011 at 9:56 AM, Douglas Gregor dgre...@apple.com wrote:
Hello Kaelyn,
Sorry for the slw response.
It's no problem. After all, life has a nasty habit of getting in the way of
coding. ;)
On May 20, 2011, at 4:17 PM, Kaelyn Uhrain wrote:
Here's a WIP
On Mon, Jun 6, 2011 at 9:23 PM, Douglas Gregor dgre...@apple.com wrote:
On Jun 6, 2011, at 6:13 PM, Kaelyn Uhrain wrote:
Hello Doug,
On Wed, Jun 1, 2011 at 9:56 AM, Douglas Gregor dgre...@apple.com wrote:
Hello Kaelyn,
Sorry for the slw response.
It's no problem. After all, life
On Wed, Jun 1, 2011 at 9:56 AM, Douglas Gregor dgre...@apple.com wrote:
+// Only perform the qualified lookups for C++
+// FIXME: this breaks
test/CXX/basic/basic.lookup/basic.lookup.argdep/p4.cpp
+if (getLangOptions().CPlusPlus) {
+ TmpRes.suppressDiagnostics();
+
On Fri, Jun 10, 2011 at 9:18 AM, Douglas Gregor dgre...@apple.com wrote:
On Jun 9, 2011, at 6:18 PM, Kaelyn Uhrain wrote:
On Wed, Jun 1, 2011 at 9:56 AM, Douglas Gregor dgre...@apple.com wrote:
+// Only perform the qualified lookups for C++
+// FIXME: this breaks
test/CXX/basic
On Thu, Jun 9, 2011 at 6:34 PM, Chandler Carruth chandl...@google.comwrote:
On Thu, Jun 9, 2011 at 6:18 PM, Kaelyn Uhrain ri...@google.com wrote:
Quick question about doing this: would it be more cost effective to use a
std::multimap to allow iterating through the namespaces in ascending
AM, Kaelyn Uhrain ri...@google.com wrote:
On Thu, Jun 9, 2011 at 6:34 PM, Chandler Carruth chandl...@google.comwrote:
On Thu, Jun 9, 2011 at 6:18 PM, Kaelyn Uhrain ri...@google.com wrote:
Quick question about doing this: would it be more cost effective to use
a std::multimap to allow
at 10:14 AM, Kaelyn Uhrain ri...@google.com wrote:
Managed to not reply to all... which is okay as the patch was against the
clang git tree as of a couple weeks ago and recent changes causes a couple
of minor merge conflicts. Here's the patch based on the current git HEAD.
On Mon, Jun 20, 2011
This patch implements checking available C++ namespaces when trying to find
typo corrections for unknown identifiers. There are currently 4 broken unit
tests (CXX/basic/basic.lookup/basic.lookup.argdep/p4.cpp,
CXX/class/class.local/p1.cpp, FixIt/typo.cpp, and
SemaObjC/synth-provisional-ivars.m)
-provisional-ivars.m tests are failing, and for those two I'm
not entirely sure which parts of the behavior are correct/acceptable and
which might be a bug in my changes.
Cheers,
Kaelyn
On Tue, Mar 8, 2011 at 7:46 PM, Douglas Gregor dgre...@apple.com wrote:
On Feb 22, 2011, at 11:21 AM, Kaelyn Uhrain
On Wed, Jun 22, 2011 at 1:23 PM, Douglas Gregor dgre...@apple.com wrote:
On Jun 22, 2011, at 10:48 AM, Kaelyn Uhrain wrote:
So in the interest of keeping the overall changes a bit more digestible,
I've split my dev branch in two. The first part, for which I've attached the
latest diff
+// FIXME: Don't do the lookups if argument dependent lookup is
required as
+// this will break
test/CXX/basic/basic.lookup/basic.lookup.argdep/p4.cpp
Is this FIXME still relevant, given that we're doing the appropriate
requiresADL check?
I've found a problem with the simple ADL
,
Kaelyn
On Thu, Jun 23, 2011 at 5:11 PM, Kaelyn Uhrain ri...@google.com wrote:
+// FIXME: Don't do the lookups if argument dependent lookup is
required as
+// this will break
test/CXX/basic/basic.lookup/basic.lookup.argdep/p4.cpp
Is this FIXME still relevant, given that we're doing
The attached patch enhances the existing array bounds checking to include
support for bounds checking on pointer arithmetic when possible (e.g. Foo
+ 5 or somearray - 7 when the size of somearray is known). It also fixes the
bounds checking to work with unary operators like and *; without this
Looks like the indenting on the FIXME you added needs to be fixed so that
the start of both lines of the comment are equal to each other and to the
surrounding code, but otherwise the code changes look fine. One big issue
regarding the unit test though: the test does not test clang's -fixit
code
Thanks for the heads-up, Doug. :)
On Tue, Jul 12, 2011 at 6:30 PM, Douglas Gregor dgre...@apple.com wrote:
On Jun 27, 2011, at 5:07 PM, Kaelyn Uhrain wrote:
And here is the second half, which changes the rest of the callers of
CorrectTypo, expands the unit test, adds a new test case
1 - 100 of 241 matches
Mail list logo
