https://github.com/coopp approved this pull request.
Looks great! I like how clean this change is!
https://github.com/llvm/llvm-project/pull/93847
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/coopp approved this pull request.
Looks good to me.
https://github.com/llvm/llvm-project/pull/93314
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/coopp approved this pull request.
Looks good to me.
https://github.com/llvm/llvm-project/pull/92793
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/coopp approved this pull request.
This looks good to me.
https://github.com/llvm/llvm-project/pull/92207
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,53 @@
+=
+HLSL Availability Diagnostics
+=
+
+.. contents::
+ :local:
+
+Introduction
+
+
+HLSL availability diagnostics emits errors or warning when unavailable shader
APIs are used. Unavailable
@@ -0,0 +1,53 @@
+=
+HLSL Availability Diagnostics
+=
+
+.. contents::
+ :local:
+
+Introduction
+
+
+HLSL availability diagnostics emits errors or warning when unavailable shader
APIs are used. Unavailable
@@ -0,0 +1,53 @@
+=
+HLSL Availability Diagnostics
+=
+
+.. contents::
+ :local:
+
+Introduction
+
+
+HLSL availability diagnostics emits errors or warning when unavailable shader
APIs are used. Unavailable
@@ -0,0 +1,53 @@
+=
+HLSL Availability Diagnostics
+=
+
+.. contents::
+ :local:
+
+Introduction
+
+
+HLSL availability diagnostics emits errors or warning when unavailable shader
APIs are used. Unavailable
https://github.com/coopp approved this pull request.
Looks fine to me. I assume this doesn't impact other test passes right? Now
there is work being done when before it was doing an early out for template
instantiations.
https://github.com/llvm/llvm-project/pull/91699
https://github.com/coopp edited https://github.com/llvm/llvm-project/pull/91699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -177,16 +177,19 @@ void justAtAvailable(void) {
#ifdef OBJCPP
-int f(char) AVAILABLE_10_12;
+int f(char) AVAILABLE_10_12; // #f_char_def
int f(int);
template int use_f() {
- // FIXME: We should warn here!
- return f(T());
+ // expected-warning@#f_call {{'f' is
https://github.com/coopp approved this pull request.
Looks good. Took me a while to go through all of the tests. Looks like
everything is covered!
https://github.com/llvm/llvm-project/pull/90222
___
cfe-commits mailing list
https://github.com/coopp approved this pull request.
Just a small nit from me about switch( ) statement formatting in existing code.
Not the new code. Looks good to me.
https://github.com/llvm/llvm-project/pull/90694
___
cfe-commits mailing list
@@ -1612,15 +1612,7 @@ const llvm::fltSemantics
::getFloatTypeSemantics(QualType T) const {
case BuiltinType::Float16:
return Target->getHalfFormat();
case BuiltinType::Half:
-// For HLSL, when the native half type is disabled, half will be treat as
-// float.
https://github.com/coopp approved this pull request.
Looks good
https://github.com/llvm/llvm-project/pull/89309
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4890,15 +4890,16 @@ class SpellingList {
}
void add(const Record , FlattenedSpelling Spelling) {
-SpellingKind Kind = StringSwitch(Spelling.variety())
-.Case("GNU", SpellingKind::GNU)
-.Case("CXX11",
https://github.com/coopp approved this pull request.
Looks good to me.
https://github.com/llvm/llvm-project/pull/88004
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -146,6 +146,15 @@ struct BinOpInfo {
return UnOp->getSubExpr()->getType()->isFixedPointType();
return false;
}
+
+ /// Check if the RHS has a signed integer representation.
coopp wrote:
Extra '/' in comment line.
https://github.com/coopp commented:
Looks good
https://github.com/llvm/llvm-project/pull/88939
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/coopp approved this pull request.
Looks good to me.
https://github.com/llvm/llvm-project/pull/88976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/coopp approved this pull request.
Looks good to me
https://github.com/llvm/llvm-project/pull/88401
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/coopp approved this pull request.
WOW.. This was pretty big. I went through it twice and didn't see anything
that jumped out. Looks good to me.
https://github.com/llvm/llvm-project/pull/79382
___
cfe-commits mailing list
https://github.com/coopp approved this pull request.
Looks good to me for what I can see in the code.
I took special care to make sure places where noticed the old size accessor
(CAT->getSize().getZExtValue() ) being called, was now using
(CAT->getZExtSize()).
https://github.com/coopp approved this pull request.
SPIRV in the house!
https://github.com/llvm/llvm-project/pull/86323
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,186 @@
+//===- DXILIntrinsicExpansion.cpp - Prepare LLVM Module for DXIL
encoding--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/coopp approved this pull request.
Looks good to me for what I can understand.
https://github.com/llvm/llvm-project/pull/84526
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/coopp edited https://github.com/llvm/llvm-project/pull/84526
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
coopp wrote:
> What is the output before this change? It would be nice to add more
> information to the PR description.
I added a description that shows a before/after output for this change.
https://github.com/llvm/llvm-project/pull/81030
___
https://github.com/coopp edited https://github.com/llvm/llvm-project/pull/81030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/coopp edited https://github.com/llvm/llvm-project/pull/81030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/coopp edited https://github.com/llvm/llvm-project/pull/81030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/coopp edited https://github.com/llvm/llvm-project/pull/81030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/coopp updated https://github.com/llvm/llvm-project/pull/81030
>From eb6c7e6e9d4ccaf6e63714d2d94a518cc00bcc82 Mon Sep 17 00:00:00 2001
From: Cooper Partin
Date: Wed, 7 Feb 2024 11:32:56 -0800
Subject: [PATCH 1/2] [DirectX] Fix HLSL bitshifts to leverage the OpenCL
pipeline
https://github.com/coopp created https://github.com/llvm/llvm-project/pull/81030
None
>From eb6c7e6e9d4ccaf6e63714d2d94a518cc00bcc82 Mon Sep 17 00:00:00 2001
From: Cooper Partin
Date: Wed, 7 Feb 2024 11:32:56 -0800
Subject: [PATCH] [DirectX] Fix HLSL bitshifts to leverage the OpenCL pipeline
34 matches
Mail list logo
