linux4life798 wrote:
> @linux4life798 Can you review the last update?
This change LGTM (I don't actually have reviewer rights).
https://github.com/llvm/llvm-project/pull/77269
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
linux4life798 wrote:
> Added flush before calling `writeMainFileToStdOut`.
I think that's reasonable.
> Personally I didn't find this function particularly useful: I was hoping to
> perform rewriting without creating new files, but seems like capturing stdout
> from a shared library requires
linux4life798 wrote:
I don't think this needs to block this change, but another concern I have about
this API is that it is writing to stdout from C++ intermixed with Python
writing to its own buffered stdout. This means that the user may see
inconsistent output. This is somewhat a deficiency
linux4life798 wrote:
> @linux4life798 Nice catch! I see that so far only CompilationDatabase and
> CompletionChunk expose functions in camelCase. It would be nice to change
> them, too, but those are decade-old APIs that I think we promise stability
> for, so it might not be possible.
Yep.
linux4life798 wrote:
Thanks!
https://github.com/llvm/llvm-project/pull/77269
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
linux4life798 wrote:
Hi all, sorry for jumping in late. Minor nit here.
It looks like this change is introducing camelCase methods, but the majority of
the existing Python file uses snake_case, even though the underlying libclang
interface is camelCase. For consistency, can we make these
linux4life798 wrote:
Thanks all! @boomanaiden154 or @tru, could you merge this PR?
https://github.com/llvm/llvm-project/pull/77228
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
linux4life798 wrote:
> This should just bump to 3.8 IMO. Anything below that is end-of-life and a
> waste of time to support.
I agree and my personal plan is still to bump the version to 3.7 or 3.8, but it
was more important to me to make progress towards adding any usable type
annotations
@@ -30,10 +30,15 @@ jobs:
check-clang-python:
# Build libclang and then run the libclang Python binding's unit tests.
name: Build and run Python unit tests
+strategy:
+ fail-fast: false
+ matrix:
+python-version: ["3.7", "3.11"]
https://github.com/linux4life798 edited
https://github.com/llvm/llvm-project/pull/77219
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/linux4life798 edited
https://github.com/llvm/llvm-project/pull/77219
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/linux4life798 updated
https://github.com/llvm/llvm-project/pull/77219
>From 34492a5aea953be59cf84450862143cbcf53ea6e Mon Sep 17 00:00:00 2001
From: Craig Hesling
Date: Sat, 30 Dec 2023 01:17:57 -0500
Subject: [PATCH 1/3] [GitHub] Add python_version input to
https://github.com/linux4life798 created
https://github.com/llvm/llvm-project/pull/77228
Remove Python 2 support and clean up code that conditions based on version.
Issue #76664.
>From 1ce6508ee1052c46c44a0f8f5dfd424df83ce209 Mon Sep 17 00:00:00 2001
From: Craig Hesling
Date: Sat, 2 Dec 2023
linux4life798 wrote:
@tbaederr, thanks for the review! Can you merge the change or should I reach
out to another reviewer?
Best,
Craig
https://github.com/llvm/llvm-project/pull/76301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/linux4life798 edited
https://github.com/llvm/llvm-project/pull/76301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/linux4life798 created
https://github.com/llvm/llvm-project/pull/76301
Add the required CMAKE_BUILD_TYPE to the cmake configuration line.
>From 6c3466f88cb9746e3b94d7dd1c0e1e33a26c8bb3 Mon Sep 17 00:00:00 2001
From: Craig Hesling
Date: Sat, 23 Dec 2023 16:13:46 -0500
https://github.com/linux4life798 edited
https://github.com/llvm/llvm-project/pull/74292
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/linux4life798 edited
https://github.com/llvm/llvm-project/pull/74292
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/linux4life798 edited
https://github.com/llvm/llvm-project/pull/74292
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/linux4life798 created
https://github.com/llvm/llvm-project/pull/74292
None
>From 22b357ace6de02e537b5fbc217febe8cd59ae40a Mon Sep 17 00:00:00 2001
From: Craig Hesling
Date: Sun, 3 Dec 2023 15:59:00 -0800
Subject: [PATCH 1/2] [libclang/python] Update README.txt path
Update
20 matches
Mail list logo
