[clang] [clang][nullability] Propagate storage location / value of `++`/`--` operators. (PR #94217)

2024-06-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (martinboehme) Changes To avoid generating unnecessary values, we don't create a new value but instead leave it to the specific analysis to do this if desired. --- Full diff: https://github.com/llvm/llvm-project/pull/94217.diff 2

[clang] [clang][nullability] Propagate storage location / value of `++`/`--` operators. (PR #94217)

2024-06-03 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/94217 To avoid generating unnecessary values, we don't create a new value but instead leave it to the specific analysis to do this if desired. >From dc88f5ddb98ebfb738fe26ae268d9d1f42a1957a Mon Sep 17 00:00:00

[clang] [clang] Fix loss of `dllexport` for exported template specialization (PR #93302)

2024-06-03 Thread via cfe-commits
zmodem wrote: > Ok, I have confirmed that the getMostRecentDecl() fix does indeed work on the > main branch. Great! > However, this fix also causes a dllimport test to fail too, so perhaps that > was the "failure" that I encountered, I just don't remember. Was this about `@_ZdlPv` in

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-03 Thread via cfe-commits
Sirraide wrote: > Also, what do you think about the fix-it hint wording for errors such as > `assignment to cast is illegal, lvalue casts are not supported`? Don’t remember what that was for off the top of my head, but just the same fix-it should be fine imo

[clang] Support [[guarded_by(mutex)]] attribute inside C struct (PR #94216)

2024-06-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Pierre d'Herbemont (pdherbemont) Changes Today, it's only supported inside C++ classes or top level C/C++ declaration. I mostly copied and adapted over the code from the [[counted_by(value)]] lookup. --- Full diff:

[clang] Support [[guarded_by(mutex)]] attribute inside C struct (PR #94216)

2024-06-03 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you,

[clang] Support [[guarded_by(mutex)]] attribute inside C struct (PR #94216)

2024-06-03 Thread Pierre d'Herbemont via cfe-commits
https://github.com/pdherbemont created https://github.com/llvm/llvm-project/pull/94216 Today, it's only supported inside C++ classes or top level C/C++ declaration. I mostly copied and adapted over the code from the [[counted_by(value)]] lookup. >From 7b5c9e566c326a16d192ae478c806cbc

[clang] [Clang] Fix crash on improper use of __array_extent (PR #94173)

2024-06-03 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/94173 >From b4f5d6d43d369649711cece6057c8fe2758a5a89 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 3 Jun 2024 00:22:02 +0300 Subject: [PATCH 1/2] fix(80474): use expression error on incomplete

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread David Spickett via cfe-commits
DavidSpickett wrote: > First Windows CI results: LLDB unit tests do not even build. Linaro's Windows bot uses clang-cl, but I do remember something like this there too. I will do a local build with msvc and see what I can do. https://github.com/llvm/llvm-project/pull/94208

[clang] feat(92583): [C++23] update constexpr diagnostics for missing return statements per P2448 (PR #94123)

2024-06-03 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk edited https://github.com/llvm/llvm-project/pull/94123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] New optin.taint.TaintAlloc checker for catching unbounded memory allocation calls (PR #92420)

2024-06-03 Thread Daniel Krupp via cfe-commits
dkrupp wrote: In the latest commit I fixed all remaining review comments. GenericTaintchecker should be a dependency as mentioned in the FIXME, but it cannot be one until the checker is not a modeling checker. This separation will be done in a later follow-up patch. Until then, the

[clang] [clang][ASTImport] fix issue on anonymous enum import (PR #93923)

2024-06-03 Thread Balázs Kéri via cfe-commits
https://github.com/balazske commented: The change looks good, only the test can be made more exact. https://github.com/llvm/llvm-project/pull/93923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][ASTImport] fix issue on anonymous enum import (PR #93923)

2024-06-03 Thread Balázs Kéri via cfe-commits
@@ -9674,6 +9674,40 @@ TEST_P(ASTImporterOptionSpecificTestBase, ImportInstantiatedFromMember) { EXPECT_TRUE(ImportedPartialSpecialization->getInstantiatedFromMember()); } +AST_MATCHER_P(EnumDecl, hasEnumConstName, StringRef, ConstName) { + for (EnumConstantDecl *D :

[clang] [clang][ASTImport] fix issue on anonymous enum import (PR #93923)

2024-06-03 Thread Balázs Kéri via cfe-commits
@@ -9674,6 +9674,40 @@ TEST_P(ASTImporterOptionSpecificTestBase, ImportInstantiatedFromMember) { EXPECT_TRUE(ImportedPartialSpecialization->getInstantiatedFromMember()); } +AST_MATCHER_P(EnumDecl, hasEnumConstName, StringRef, ConstName) { + for (EnumConstantDecl *D :

[clang] [clang][ASTImport] fix issue on anonymous enum import (PR #93923)

2024-06-03 Thread Balázs Kéri via cfe-commits
https://github.com/balazske edited https://github.com/llvm/llvm-project/pull/93923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] New optin.taint.TaintAlloc checker for catching unbounded memory allocation calls (PR #92420)

2024-06-03 Thread Daniel Krupp via cfe-commits
https://github.com/dkrupp updated https://github.com/llvm/llvm-project/pull/92420 >From f6fdd544a90b865e5e0e530930db87cad405216e Mon Sep 17 00:00:00 2001 From: Daniel Krupp Date: Tue, 30 Apr 2024 15:20:52 +0200 Subject: [PATCH 1/6] [analyzer] Adding taint analysis capability to unix.Malloc

[clang-tools-extra] [clang-tidy] Fix assert in modernize-use-std-format/print (PR #94104)

2024-06-03 Thread Mike Crowe via cfe-commits
@@ -351,6 +351,10 @@ Changes in existing checks ` check to also handle calls to ``compare`` method. +- Improved :doc:`modernize-use-std-format` and mikecrowe wrote: I spotted that just too late... https://github.com/llvm/llvm-project/pull/94104

[clang] [clang] Move CWG2390 test into `cwg23xx.cpp` (PR #94206)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: It'd be nice to have an approval from @tbaederr as the author of the original test. https://github.com/llvm/llvm-project/pull/94206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: @DavidSpickett I made the changes you suggested. Let's see how this Linux run fares. Any thoughts on https://github.com/llvm/llvm-project/pull/94208#issuecomment-2144949637 ? https://github.com/llvm/llvm-project/pull/94208 ___

[clang-tools-extra] [clangd] Allow "move function body out-of-line" in non-header files (PR #69704)

2024-06-03 Thread Christian Kandeler via cfe-commits
https://github.com/ckandeler closed https://github.com/llvm/llvm-project/pull/69704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 955c223 - [clangd] Allow "move function body out-of-line" in non-header files (#69704)

2024-06-03 Thread via cfe-commits
Author: Christian Kandeler Date: 2024-06-03T14:48:53+02:00 New Revision: 955c2237629ae252bed44177f0b65a8805051add URL: https://github.com/llvm/llvm-project/commit/955c2237629ae252bed44177f0b65a8805051add DIFF:

[clang-tools-extra] [clangd] Allow "move function body out-of-line" in non-header files (PR #69704)

2024-06-03 Thread Christian Kandeler via cfe-commits
ckandeler wrote: I'm going to merge this without explicit format approval based on the following: - There was a general LGTM. - I addressed the remaining issues. - There was no further feedback for more than half a year. https://github.com/llvm/llvm-project/pull/69704

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/94208 >From 5c757153a3f462d40663add6a9ae7caf42272913 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Mon, 3 Jun 2024 13:33:36 +0300 Subject: [PATCH 1/3] Enable LLDB tests in pre-submit CI ---

[clang-tools-extra] [clang-tidy] Fix assert in modernize-use-std-format/print (PR #94104)

2024-06-03 Thread Mike Crowe via cfe-commits
https://github.com/mikecrowe updated https://github.com/llvm/llvm-project/pull/94104 >From 2972062997ca582100b5797cd548c4dc2f80c69a Mon Sep 17 00:00:00 2001 From: Mike Crowe Date: Fri, 31 May 2024 21:27:03 +0100 Subject: [PATCH 1/3] [clang-tidy] Fix assert in modernize-use-std-format/print

[clang] [analyzer] New optin.taint.TaintAlloc checker for catching unbounded memory allocation calls (PR #92420)

2024-06-03 Thread Daniel Krupp via cfe-commits
https://github.com/dkrupp edited https://github.com/llvm/llvm-project/pull/92420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > You can either install it with pip I'll do that, but I think LLDB should follow the example of MLIR here, so that pipeline scripts don't have hard-coded dependencies for individual projects:

[clang-tools-extra] [clang-tidy] Fix assert in modernize-use-std-format/print (PR #94104)

2024-06-03 Thread Piotr Zegar via cfe-commits
@@ -351,6 +351,10 @@ Changes in existing checks ` check to also handle calls to ``compare`` method. +- Improved :doc:`modernize-use-std-format` and PiotrZSL wrote: remove modernize-use-std-format from here, as it's new check, only leave std-print

[clang] [clang] Make sure all C++ DR tests are running with `-pedantic-errors` (PR #94203)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/94203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a58dd0e - [clang] Make sure all C++ DR tests are running with `-pedantic-errors` (#94203)

2024-06-03 Thread via cfe-commits
Author: Vlad Serebrennikov Date: 2024-06-03T16:39:20+04:00 New Revision: a58dd0e948040b75266b2ee02292a16ed7b2afd5 URL: https://github.com/llvm/llvm-project/commit/a58dd0e948040b75266b2ee02292a16ed7b2afd5 DIFF:

[clang-tools-extra] [clang-tidy] Fix assert in modernize-use-std-format/print (PR #94104)

2024-06-03 Thread Mike Crowe via cfe-commits
https://github.com/mikecrowe updated https://github.com/llvm/llvm-project/pull/94104 >From 2972062997ca582100b5797cd548c4dc2f80c69a Mon Sep 17 00:00:00 2001 From: Mike Crowe Date: Fri, 31 May 2024 21:27:03 +0100 Subject: [PATCH 1/3] [clang-tidy] Fix assert in modernize-use-std-format/print

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread David Spickett via cfe-commits
DavidSpickett wrote: And I would bet that a majority of the unresolved are due to: ``` ModuleNotFoundError: No module named 'pexpect' ``` You can either install it with `pip` or pass `-DLLDB_TEST_USER_ARGS=--skip-category=pexpect` to CMake. https://github.com/llvm/llvm-project/pull/94208

[clang-tools-extra] [clang-tidy] Fix assert in modernize-use-std-format/print (PR #94104)

2024-06-03 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 16397e8ec7ffbee2907dfec698356f67672086e8 574cc6ad99c622381eb0ba0e35f55efba52d32c9 --

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread David Spickett via cfe-commits
DavidSpickett wrote: > lldb-shell :: SymbolFile/DWARF/x86/module-ownership.mm This is due to https://github.com/llvm/llvm-project/pull/92083, it's been reverted now. https://github.com/llvm/llvm-project/pull/94208 ___ cfe-commits mailing list

[clang-tools-extra] [clang-tidy] Fix assert in modernize-use-std-format/print (PR #94104)

2024-06-03 Thread Mike Crowe via cfe-commits
https://github.com/mikecrowe updated https://github.com/llvm/llvm-project/pull/94104 >From 2972062997ca582100b5797cd548c4dc2f80c69a Mon Sep 17 00:00:00 2001 From: Mike Crowe Date: Fri, 31 May 2024 21:27:03 +0100 Subject: [PATCH 1/3] [clang-tidy] Fix assert in modernize-use-std-format/print

[clang] [llvm] [IR] Avoid creating icmp/fcmp constant expressions (PR #92885)

2024-06-03 Thread via cfe-commits
mikaelholmen wrote: > @mikaelholmen Thanks for the report, should be fixed by > [bda8d1a](https://github.com/llvm/llvm-project/commit/bda8d1ad72fc72f21f6c536692594376d00db8b6). Yep, thanks! That was fast! :) https://github.com/llvm/llvm-project/pull/92885

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: Linux results are ready. `SymbolFile/DWARF/x86/module-ownership.mm` is crashing. While unresolved tests are not considered failed, if you grep for `FAILED`, they add a lot of noise that would make harder for people to realize what the actual reason for CI failure. All in all, I

[clang] [llvm] [IR] Avoid creating icmp/fcmp constant expressions (PR #92885)

2024-06-03 Thread Nikita Popov via cfe-commits
nikic wrote: @mikaelholmen Thanks for the report, should be fixed by https://github.com/llvm/llvm-project/commit/bda8d1ad72fc72f21f6c536692594376d00db8b6. https://github.com/llvm/llvm-project/pull/92885 ___ cfe-commits mailing list

[clang-tools-extra] [clang-tidy] Fix assert in modernize-use-std-format/print (PR #94104)

2024-06-03 Thread Mike Crowe via cfe-commits
@@ -20,6 +20,11 @@ namespace clang::tidy::modernize { namespace { AST_MATCHER(StringLiteral, isOrdinary) { return Node.isOrdinary(); } +AST_MATCHER(QualType, isSimpleChar) { + const auto ActualType = Node.getTypePtr(); + return

[clang] [clang][analyzer] Move unix.BlockInCriticalSection out of alpha (PR #93815)

2024-06-03 Thread Endre Fülöp via cfe-commits
https://github.com/gamesh411 closed https://github.com/llvm/llvm-project/pull/93815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6ef785c - [clang][analyzer] Move unix.BlockInCriticalSection out of alpha (#93815)

2024-06-03 Thread via cfe-commits
Author: Endre Fülöp Date: 2024-06-03T14:23:58+02:00 New Revision: 6ef785c9517e8e44ddda8263e5f319b44f56cff8 URL: https://github.com/llvm/llvm-project/commit/6ef785c9517e8e44ddda8263e5f319b44f56cff8 DIFF: https://github.com/llvm/llvm-project/commit/6ef785c9517e8e44ddda8263e5f319b44f56cff8.diff

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > > @Michael137 This is for Linux. Windows works the same way just below those > > lines: > > https://github.com/llvm/llvm-project/blob/9a7bd8a60f03595be5d42315790df6d409f81091/.ci/generate-buildkite-pipeline-premerge#L253-L255 > > Ah, so what would the issue be with just adding

[clang] [clang] Make sure all C++ DR tests are running with `-pedantic-errors` (PR #94203)

2024-06-03 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/94203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Make sure all C++ DR tests are running with `-pedantic-errors` (PR #94203)

2024-06-03 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/94203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Make sure all C++ DR tests are running with `-pedantic-errors` (PR #94203)

2024-06-03 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/94203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Teach clang-repl how to load PCHs. (PR #94166)

2024-06-03 Thread Aaron Ballman via cfe-commits
@@ -282,6 +288,8 @@ namespace { } void HandleTranslationUnit(ASTContext ) override { + IRGenFinished = true; AaronBallman wrote: shouldn't this be set at the end of `HandleTranslationUnit` rather than the beginning?

[clang] [clang-repl] Teach clang-repl how to load PCHs. (PR #94166)

2024-06-03 Thread Aaron Ballman via cfe-commits
@@ -138,6 +138,8 @@ namespace { assert(!M && "Replacing existing Module?"); M.reset(new llvm::Module(ExpandModuleName(ModuleName, CodeGenOpts), C)); + IRGenFinished = false; AaronBallman wrote: Why is IR gen *finished* when we're just

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread Michael Buch via cfe-commits
Michael137 wrote: > @Michael137 This is for Linux. Windows works the same way just below those > lines: > > https://github.com/llvm/llvm-project/blob/9a7bd8a60f03595be5d42315790df6d409f81091/.ci/generate-buildkite-pipeline-premerge#L253-L255 Ah, so what would the issue be with just adding

[clang] [llvm] [IR] Avoid creating icmp/fcmp constant expressions (PR #92885)

2024-06-03 Thread via cfe-commits
mikaelholmen wrote: Hi @nikic The following starts crashing with this patch: ``` opt ic2.ll -S -o /dev/null -passes=instcombine ``` It hits ``` opt: ../include/llvm/Support/Casting.h:578: decltype(auto) llvm::cast(From *) [To = llvm::TruncInst, From = llvm::Value]: Assertion `isa(Val) &&

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-03 Thread Rajveer Singh Bharadwaj via cfe-commits
Rajveer100 wrote: Tests which fail currently: Clang :: Sema/exprs.c Clang :: Sema/va_arg_x86_32.c Clang :: SemaObjCXX/sel-address.mm Also, what do you think about the fix-it hint wording for errors such as `assignment to cast is illegal, lvalue casts are not supported`?

[clang] [llvm] [clang][CodeGen] Global constructors/destructors are globals (PR #93914)

2024-06-03 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/93914 >From 34b9646a38c6bdd0419dd9d2eb1bc847c4d16596 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Tue, 28 May 2024 20:09:15 +0100 Subject: [PATCH 1/8] Fix `emitUsed` to place `used` globals in the Global AS.

[clang] [ExtractAPI,test] fix filecheck annotation (PR #92231)

2024-06-03 Thread via cfe-commits
https://github.com/klensy updated https://github.com/llvm/llvm-project/pull/92231 >From 910a674252a7f0968db46c9ed09879ae58e90d3b Mon Sep 17 00:00:00 2001 From: klensy Date: Wed, 15 May 2024 12:14:56 +0300 Subject: [PATCH] [ExtractAPI,test] fix filecheck annotation ---

[clang] [analyzer] Refine invalidation caused by `fread` (PR #93408)

2024-06-03 Thread Balazs Benics via cfe-commits
steakhal wrote: Fixed most NFC typos and suggestions. Let's continue the discussion. https://github.com/llvm/llvm-project/pull/93408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] New optin.taint.TaintAlloc checker for catching unbounded memory allocation calls (PR #92420)

2024-06-03 Thread Daniel Krupp via cfe-commits
@@ -1730,6 +1721,21 @@ def UnixAPIPortabilityChecker : Checker<"UnixAPI">, } // end optin.portability + +//===--===// +// Taint checkers.

[clang] [analyzer] Refine invalidation caused by `fread` (PR #93408)

2024-06-03 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/93408 >From f9e841ddaa865d529c806b2d115d5ddbc7109243 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Sun, 26 May 2024 11:40:01 +0200 Subject: [PATCH 1/6] [analyzer] Refine invalidation caused by `fread` This

[clang] [analyzer] Refine invalidation caused by `fread` (PR #93408)

2024-06-03 Thread Balazs Benics via cfe-commits
@@ -717,18 +717,71 @@ const ExplodedNode *StreamChecker::getAcquisitionSite(const ExplodedNode *N, return nullptr; } +/// Invalidate only the requested elements instead of the whole buffer. +/// This is basically a refinement of the more generic 'escapeArgs' or +/// the

[clang] [Clang][Sema] Tweak tryCaptureVariable for unevaluated lambdas (PR #93206)

2024-06-03 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/93206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Tweak tryCaptureVariable for unevaluated lambdas (PR #93206)

2024-06-03 Thread via cfe-commits
https://github.com/cor3ntin commented: I think it makes sense. I kinda wish there would be a more generic way to skip over requires expressions but I also can't think of other contexts we'd want to skip over, so this looks fine. Thanks for fixing a large number of issues

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: @Michael137 This is for Linux. Windows works the same way just below those lines: https://github.com/llvm/llvm-project/blob/9a7bd8a60f03595be5d42315790df6d409f81091/.ci/generate-buildkite-pipeline-premerge#L253-L255 https://github.com/llvm/llvm-project/pull/94208

[clang] [analyzer] Refine invalidation caused by `fread` (PR #93408)

2024-06-03 Thread Balazs Benics via cfe-commits
@@ -937,8 +990,21 @@ void StreamChecker::evalFreadFwrite(const FnDescription *Desc, // At read, invalidate the buffer in any case of error or success, // except if EOF was already present. - if (IsFread && !E.isStreamEof()) -State = escapeArgs(State, C, Call, {0});

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread Michael Buch via cfe-commits
Michael137 wrote: > > Should we just run the tests for the LLDB C++ language plugin (i.e., the > > part of LLDB that invokes Clang and the JIT). And then we could expand the > > set of tests from there later? > > In the bash script that currently handles this, "targets that we need to >

[clang] [Clang] Implement resolution for CWG1835 (PR #92957)

2024-06-03 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: This does seem to cause an error in libstdc++: ``` include/c++/11/bits/shared_ptr.h:365:10: error: use 'template' keyword to treat '__shared_ptr' as a dependent template name this->__shared_ptr<_Tp>::operator=(__r); ^ ``` Since `this` is dependent (it's of

[clang] remove goma support from clang (PR #93942)

2024-06-03 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/93942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9a7bd8a - remove goma support from clang (#93942)

2024-06-03 Thread via cfe-commits
Author: Takuto Ikuta Date: 2024-06-03T07:30:14-04:00 New Revision: 9a7bd8a60f03595be5d42315790df6d409f81091 URL: https://github.com/llvm/llvm-project/commit/9a7bd8a60f03595be5d42315790df6d409f81091 DIFF: https://github.com/llvm/llvm-project/commit/9a7bd8a60f03595be5d42315790df6d409f81091.diff

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: First Windows CI results: LLDB unit tests do not even build. ``` FAILED: tools/lldb/unittests/Process/gdb-remote/CMakeFiles/ProcessGdbRemoteTests.dir/GDBRemoteCommunicationClientTest.cpp.obj sccache C:\BuildTools\VC\Tools\MSVC\14.29.30133\bin\Hostx64\x64\cl.exe /nologo /TP

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > Should we just run the tests for the LLDB C++ language plugin (i.e., the part > of LLDB that invokes Clang and the JIT). And then we could expand the set of > tests from there later? In the bash script that currently handles this, "targets that we need to check if lldb is

[clang] [serialization] no transitive decl change (PR #92083)

2024-06-03 Thread Michael Buch via cfe-commits
Michael137 wrote: I.e., also broke the macOS LLDB buildbots: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/2637/execution/node/97/log/ ``` Assertion failed: (!((*IDAddress) >> 48) && "We should only set the module ID once"), function setOwningModuleID, file DeclBase.cpp,

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread Michael Buch via cfe-commits
Michael137 wrote: Worth a shot i guess. Though it could be somewhat disruptive if we do in fact have flaky tests. I don't think we need to run *all* tests. Should we just run the tests for the LLDB C++ language plugin (i.e., the part of LLDB that invokes Clang and the JIT). And then we could

[clang] [clang] Move CWG2390 test into `cwg23xx.cpp` (PR #94206)

2024-06-03 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/94206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [serialization] no transitive decl change (PR #92083)

2024-06-03 Thread Mitch Phillips via cfe-commits
hctim wrote: Hi from the sanitizer buildbot mainter, thanks for the fast revert! For full reproduction, you can use https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild and `buildbot_fast.sh`. But, you can reproduce it quicker by using `-DCMAKE_C_FLAGS="-fsanitize=undefined"

[clang] [serialization] no transitive decl change (PR #92083)

2024-06-03 Thread David Spickett via cfe-commits
DavidSpickett wrote: This also broke an lldb test: https://lab.llvm.org/buildbot/#/builders/96/builds/58449 `lldb-test: ../llvm-project/clang/lib/AST/DeclBase.cpp:132: void clang::Decl::setOwningModuleID(unsigned int): Assertion `!((*IDAddress) >> 48) && "We should only set the module ID

[clang] [clang][analyzer] Move unix.BlockInCriticalSection out of alpha (PR #93815)

2024-06-03 Thread Balazs Benics via cfe-commits
Endre =?utf-8?q?F=C3=BCl=C3=B6p?= Message-ID: In-Reply-To: https://github.com/steakhal approved this pull request. https://github.com/llvm/llvm-project/pull/93815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 6b30180 - Revert "[serialization] no transitive decl change (#92083)"

2024-06-03 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2024-06-03T18:49:18+08:00 New Revision: 6b30180b663e1fe4de32046398581a374c8a54f2 URL: https://github.com/llvm/llvm-project/commit/6b30180b663e1fe4de32046398581a374c8a54f2 DIFF: https://github.com/llvm/llvm-project/commit/6b30180b663e1fe4de32046398581a374c8a54f2.diff

[clang] [serialization] no transitive decl change (PR #92083)

2024-06-03 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: I'll close it as there are some crashes. --- The crash log: ``` ** TEST 'Clang :: Modules/redecl-ivars.m' FAILED Exit Code: 1 Command Output (stderr): -- RUN: at line 2: rm -rf

[clang] [clang][analyzer] Improved PointerSubChecker (PR #93676)

2024-06-03 Thread Donát Nagy via cfe-commits
NagyDonat wrote: > With the current version I have the following observations: > > * There is a warning for `( + 1) - ` and `( - 1) - `. Should this > be fixed? The expression `( + 1) - ` is valid and should not produce a warning. It could appear e.g. in code that's structured like ```

[clang] [clang][analyzer] Move unix.BlockInCriticalSection out of alpha (PR #93815)

2024-06-03 Thread Endre Fülöp via cfe-commits
https://github.com/gamesh411 updated https://github.com/llvm/llvm-project/pull/93815 From 1da3d4dc3c74f1240e7d921c97b0c7eea2a53e33 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Endre=20F=C3=BCl=C3=B6p?= Date: Wed, 29 May 2024 00:38:07 +0200 Subject: [PATCH 1/2] [clang][analyzer] Move

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vlad Serebrennikov (Endilll) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/94208.diff 2 Files Affected: - (modified) .ci/generate-buildkite-pipeline-premerge (+1-3) - (modified)

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/94208 None >From 5c757153a3f462d40663add6a9ae7caf42272913 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Mon, 3 Jun 2024 13:33:36 +0300 Subject: [PATCH 1/2] Enable LLDB tests in pre-submit CI ---

[clang] [clang] Move CWG2390 test into `cwg23xx.cpp` (PR #94206)

2024-06-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes This patch refactors an existing test for [CWG2390](https://cplusplus.github.io/CWG/issues/2390.html) "Is the argument of `__has_cpp_attribute` macro-expanded?" to use `#error` instead of emitting a

[clang] [clang] Make sure all C++ DR tests are running with `-pedantic-errors` (PR #94203)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/94203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Move CWG2390 test into `cwg23xx.cpp` (PR #94206)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/94206 This patch refactors an existing test for [CWG2390](https://cplusplus.github.io/CWG/issues/2390.html) "Is the argument of `__has_cpp_attribute` macro-expanded?" to use `#error` instead of emitting a variable

[clang] [clang-format] Add DiagHandler for getStyle function (PR #91317)

2024-06-03 Thread via cfe-commits
pointhex wrote: Done: https://github.com/llvm/llvm-project/issues/94205 https://github.com/llvm/llvm-project/pull/91317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[Clang][CWG1815] Support lifetime extension of temporary created by aggregate initialization using a default member initializer" (PR #92527)

2024-06-03 Thread via cfe-commits
bgra8 wrote: heads-up @yronglin: we've bisected many compilation breakages to this patch. We're working on a reproducer. https://github.com/llvm/llvm-project/pull/92527 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][analyzer] Improved PointerSubChecker (PR #93676)

2024-06-03 Thread Donát Nagy via cfe-commits
@@ -0,0 +1,74 @@ +// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.core.PointerSub -verify %s + +void f1(void) { + int x, y, z[10]; + int d = - // expected-warning{{Subtraction of two pointers that do not point into the same array is undefined behavior}} + d = z - //

[clang] [analyzer][NFC] Fix comparison to True/False (PR #94038)

2024-06-03 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat commented: This change follows both the letter and the spirit of PEP8. (Note that `True` and `False` are not "singletons like `None`" because the type `bool` has two possible values -- but different rules still claim that the original code was bad and the new code

[clang] [clang] Make sure all C++ DR tests are running with `-pedantic-errors` (PR #94203)

2024-06-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes In #94167 I found out that `cwg28xx.cpp` has been running without `-pedantic-errors` and fixed that. This patch fixes that for the rest of the test suite. Only one tests as affected with a trivial fix

[clang] [clang] Make sure all C++ DR tests are running with `-pedantic-errors` (PR #94203)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/94203 In #94167 I found out that `cwg28xx.cpp` has been running without `-pedantic-errors` and fixed that. This patch fixes that for the rest of the test suite. Only one tests as affected with a trivial fix (warning

[clang] [llvm] [OpenMP] OpenMP 5.1 "assume" directive parsing support (PR #92731)

2024-06-03 Thread Julian Brown via cfe-commits
https://github.com/jtb20 updated https://github.com/llvm/llvm-project/pull/92731 >From 4337a97fb8982addfd6740db2ff08dfb0398842e Mon Sep 17 00:00:00 2001 From: Julian Brown Date: Wed, 1 May 2024 06:35:59 -0500 Subject: [PATCH] [OpenMP] OpenMP 5.1 "assume" directive parsing support This is a

[clang] [clang][analyzer] Move PutenvStackArrayChecker out of alpha package (PR #93980)

2024-06-03 Thread Balazs Benics via cfe-commits
=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?= Message-ID: In-Reply-To: https://github.com/steakhal approved this pull request. https://github.com/llvm/llvm-project/pull/93980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][analyzer] Move PutenvStackArrayChecker out of alpha package (PR #93980)

2024-06-03 Thread Balazs Benics via cfe-commits
=?utf-8?q?Balázs_Kéri?= Message-ID: In-Reply-To: https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/93980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Tweak tryCaptureVariable for unevaluated lambdas (PR #93206)

2024-06-03 Thread Younan Zhang via cfe-commits
zyn0217 wrote: @cor3ntin I have reduced the test cases (removed duplicate ones) and hopefully they look better. Can you please take another look? thanks! https://github.com/llvm/llvm-project/pull/93206 ___ cfe-commits mailing list

[clang] [clang-format] Add DiagHandler for getStyle function (PR #91317)

2024-06-03 Thread via cfe-commits
https://github.com/mydeveloperday edited https://github.com/llvm/llvm-project/pull/91317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Handle AttributeMacros in parseRecord() (PR #94189)

2024-06-03 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/94189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Tweak tryCaptureVariable for unevaluated lambdas (PR #93206)

2024-06-03 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/93206 >From 658e9d46adf6dd79aa6aef03a1817444a880348a Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Thu, 23 May 2024 22:35:11 +0800 Subject: [PATCH 1/3] [Clang][Sema] Tweak tryCaptureVariable for unevaluated

[clang] [Clang][Sema] Tweak tryCaptureVariable for unevaluated lambdas (PR #93206)

2024-06-03 Thread Younan Zhang via cfe-commits
@@ -1576,7 +1576,10 @@ ExprResult Parser::ParseLambdaExpressionAfterIntroducer( TrailingReturnTypeLoc, ), std::move(Attributes), DeclEndLoc); -Actions.ActOnLambdaClosureQualifiers(Intro, MutableLoc); +// We have called

[clang] [ClangFormat] Add DiagHandler for getStyle function (PR #91317)

2024-06-03 Thread via cfe-commits
mydeveloperday wrote: Please log an issue explaining the problem you are trying solve, its not clear to me what problem led you to this. https://github.com/llvm/llvm-project/pull/91317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Add tests for some CWG issues from 2024-05-31 telecon (PR #94167)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/94167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4f2dba3 - [clang] Add tests for some CWG issues from 2024-05-31 telecon (#94167)

2024-06-03 Thread via cfe-commits
Author: Vlad Serebrennikov Date: 2024-06-03T13:47:28+04:00 New Revision: 4f2dba3c0b4e5f11b968a840b5f70070f5288cfe URL: https://github.com/llvm/llvm-project/commit/4f2dba3c0b4e5f11b968a840b5f70070f5288cfe DIFF:

[clang] [llvm] [RISCV] Remove experimental from Zabha (PR #93831)

2024-06-03 Thread via cfe-commits
github-actions[bot] wrote: @AlexGhiti Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a

[clang] [llvm] [RISCV] Remove experimental from Zabha (PR #93831)

2024-06-03 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw closed https://github.com/llvm/llvm-project/pull/93831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6b74449 - [RISCV] Remove experimental from Zabha (#93831)

2024-06-03 Thread via cfe-commits
Author: AlexGhiti Date: 2024-06-03T17:27:02+08:00 New Revision: 6b7444964a8d028989beee554a1f5c61d16a1cac URL: https://github.com/llvm/llvm-project/commit/6b7444964a8d028989beee554a1f5c61d16a1cac DIFF: https://github.com/llvm/llvm-project/commit/6b7444964a8d028989beee554a1f5c61d16a1cac.diff

  1   2   3   4   5   6   7   8   9   10   >