aaupov wrote:
Final update:
- [clang-hip-vega20](https://lab.llvm.org/buildbot/#/builders/165): green
https://lab.llvm.org/buildbot/#/builders/165/builds/48052
https://github.com/llvm/llvm-project/pull/69133
___
cfe-commits mailing list
aaupov wrote:
Status update:
- [sanitizer-windows](https://lab.llvm.org/buildbot/#/builders/127): back to
green starting with https://lab.llvm.org/buildbot/#/builders/127/builds/61505
-
[libc-aarch64-ubuntu-fullbuild-dbg](https://lab.llvm.org/buildbot/#/builders/223):
green
aaupov wrote:
This issue with incremental builds is explicitly mentioned in
[HowToAddABuilder](https://llvm.org/docs/HowToAddABuilder.html):
> Use CCache and NOT incremental builds
Using ccache materially improves average build times. Incremental builds can be
slightly faster, but introduce
aaupov wrote:
Status of the builders that reported breakage:
- [reverse-iteration](https://lab.llvm.org/buildbot/#/builders/54):
https://lab.llvm.org/buildbot/#/builders/54/builds/8671 broken,
https://lab.llvm.org/buildbot/#/builders/54/builds/8672 green, breakage was
unrelated (unresolved
lntue wrote:
> These are all annotated builders. I tried triggering rebuilds with clean
> build dir through buildbot UI but it didn't have an effect. I don't think
> it's a reasonable expectation that every change must configure cleanly from
> an existing build directory.
I'm sorry but I
jplehr wrote:
Hi @aaupov I think this did break the AMD Hip build bot (another annotated
builder).
Are you looking into the potential issue?
https://github.com/llvm/llvm-project/pull/69133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aaupov wrote:
These are all annotated builders. I tried triggering rebuilds with clean build
dir through buildbot UI but it didn't have an effect. I don't think it's a
reasonable expectation that every change must configure cleanly from an
existing build directory.
aaupov wrote:
Reverted. Strangely I couldn't repro from
https://lab.llvm.org/buildbot/#/builders/225/builds/29950/ the failure locally.
But will get to the bottom of it.
https://github.com/llvm/llvm-project/pull/69133
___
cfe-commits mailing list
nickdesaulniers wrote:
I think the libc buildbots are now failing as a result of this change. @aaupov
can you PTAL?
- https://lab.llvm.org/buildbot/#/builders/223/builds/34823
- https://lab.llvm.org/buildbot/#/builders/225/builds/29950
https://github.com/llvm/llvm-project/pull/69133
@@ -850,23 +850,38 @@ if (CLANG_ENABLE_BOOTSTRAP)
endforeach()
endif()
-if (CLANG_BOLT_INSTRUMENT AND NOT LLVM_BUILD_INSTRUMENTED)
+set(CLANG_BOLT "INSTRUMENT" CACHE STRING "Apply BOLT optimization to Clang. \
DavidSpickett wrote:
Wild guess, this defaults
DavidSpickett wrote:
https://lab.llvm.org/buildbot/#/builders/245/builds/19468
```
CMake Error at
/home/tcwg-buildbot/worker/clang-armv8-quick/llvm/clang/utils/perf-training/CMakeLists.txt:105
(add_custom_target):
Error evaluating generator expression:
$
No target "merge-fdata"
```
DavidSpickett wrote:
I think because bots don't always clean their cmake files, revert incoming.
https://github.com/llvm/llvm-project/pull/69133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
dyung wrote:
@aaupov I believe this change is somehow causing cmake failures on several bots
I oversee, although I cannot explain why it passed when building your commit.
For example:
https://lab.llvm.org/buildbot/#/builders/139/builds/57628
```
CMake Error at
https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/69133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/69133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aaupov updated
https://github.com/llvm/llvm-project/pull/69133
>From 1ca9ce9ef3e90e3d24aea3945ae2d5129682621d Mon Sep 17 00:00:00 2001
From: Amir Aupov
Date: Mon, 16 Oct 2023 01:08:28 +0200
Subject: [PATCH 1/3] [Clang][CMake] Support perf, LBR, and Instrument
CLANG_BOLT
https://github.com/aaupov updated
https://github.com/llvm/llvm-project/pull/69133
>From 96e644279ccec1970c42cca89c05aac186b872e6 Mon Sep 17 00:00:00 2001
From: Amir Aupov
Date: Mon, 16 Oct 2023 01:08:28 +0200
Subject: [PATCH 1/3] [Clang][CMake] Support perf, LBR, and Instrument
CLANG_BOLT
aaupov wrote:
@petrhosek – thank you for a review!
https://github.com/llvm/llvm-project/pull/69133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aaupov updated
https://github.com/llvm/llvm-project/pull/69133
>From 96e644279ccec1970c42cca89c05aac186b872e6 Mon Sep 17 00:00:00 2001
From: Amir Aupov
Date: Mon, 16 Oct 2023 01:08:28 +0200
Subject: [PATCH 1/2] [Clang][CMake] Support perf, LBR, and Instrument
CLANG_BOLT
@@ -850,23 +850,38 @@ if (CLANG_ENABLE_BOOTSTRAP)
endforeach()
endif()
-if (CLANG_BOLT_INSTRUMENT AND NOT LLVM_BUILD_INSTRUMENTED)
+set(CLANG_BOLT "INSTRUMENT" CACHE STRING "Apply BOLT optimization to Clang. \
+ May be specified as Instrument or Perf or LBR to use a
@@ -67,6 +67,67 @@ def merge_fdata(args):
return 0
+def perf(args):
+parser = argparse.ArgumentParser(
+prog="perf-helper perf", description="perf wrapper for BOLT profile
collection"
+)
+parser.add_argument(
+"--lbr", action="store_true",
https://github.com/petrhosek edited
https://github.com/llvm/llvm-project/pull/69133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -6,15 +6,52 @@ import lit.util
import os
import subprocess
-config.clang = os.path.realpath(lit.util.which('clang-bolt.inst',
config.clang_tools_dir)).replace('\\', '/')
+clang_binary = "clang"
+perf_wrapper = ""
+if config.clang_bolt_mode.lower() == "instrument":
+
https://github.com/aaupov updated
https://github.com/llvm/llvm-project/pull/69133
>From 96e644279ccec1970c42cca89c05aac186b872e6 Mon Sep 17 00:00:00 2001
From: Amir Aupov
Date: Mon, 16 Oct 2023 01:08:28 +0200
Subject: [PATCH] [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT
options
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
7f881a2abe2c3eceeae0272fc41ba0a237770450..3987088f1b6f6b895f7563ad70c97074b0d4ded0
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Amir Ayupov (aaupov)
Changes
Split up and refactor CLANG_BOLT_INSTRUMENT into support for
perf no-LBR and perf with LBR profiling modes.
Differential Revision: https://reviews.llvm.org/D143617
---
Full diff:
https://github.com/aaupov created
https://github.com/llvm/llvm-project/pull/69133
Split up and refactor CLANG_BOLT_INSTRUMENT into support for
perf no-LBR and perf with LBR profiling modes.
Differential Revision: https://reviews.llvm.org/D143617
>From 3987088f1b6f6b895f7563ad70c97074b0d4ded0
27 matches
Mail list logo
