justdan96 wrote:
No problem, I have wasi-sdk all working in a Docker container now with your
latest version of wasm-component-ld so I should be thanking you!
https://github.com/llvm/llvm-project/pull/84569
___
cfe-commits mailing list
alexcrichton wrote:
Oop no I did not, thank you for the heads up! I'll work on updating wasi-sdk
now.
https://github.com/llvm/llvm-project/pull/84569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
justdan96 wrote:
@alexcrichton Not sure if you've seen but this has been released as part of
LLVM 18.1.2:
https://github.com/llvm/llvm-project/tree/llvmorg-18.1.2/clang/lib/Driver/ToolChains
https://github.com/llvm/llvm-project/pull/84569
___
alexcrichton wrote:
Yes it's expected that wasi-sdk will need changes to incorporate this PR. I'm
waiting for this to be in an LLVM release before updating wasi-sdk.
https://github.com/llvm/llvm-project/pull/84569
___
cfe-commits mailing list
TerrorJack wrote:
@alexcrichton This is breaking `wasi-sdk` build with:
```
/workspace/wasi-sdk/build/install/opt/wasi-sdk/bin/clang --target=wasm32-wasip2
-nodefaultlibs -shared
--sysroot=/workspace/wasi-sdk/build/install/opt/wasi-sdk/share/wasi-sysroot \
-o
llvmbot wrote:
/pull-request llvm/llvm-project#85802
https://github.com/llvm/llvm-project/pull/84569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sunfishcode wrote:
/cherry-pick
https://github.com/llvm/llvm-project/commit/d66121d74a458e098511b9de920d815440acaa1b
https://github.com/llvm/llvm-project/pull/84569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/sunfishcode milestoned
https://github.com/llvm/llvm-project/pull/84569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
@alexcrichton Congratulations on having your first Pull Request (PR) merged
into the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a
https://github.com/sunfishcode closed
https://github.com/llvm/llvm-project/pull/84569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/alexcrichton updated
https://github.com/llvm/llvm-project/pull/84569
>From 99ca952b60344d2ff683d05d8baa423aa11da83a Mon Sep 17 00:00:00 2001
From: Alex Crichton
Date: Fri, 8 Mar 2024 13:36:18 -0800
Subject: [PATCH 1/2] [WebAssembly] Change the default linker for
https://github.com/sunfishcode approved this pull request.
Looks good!
https://github.com/llvm/llvm-project/pull/84569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 7d55b916a5e5091ff21d6fea4aaa54efe73535a7
d1a1b22da3e1361a34f2d4fa8a2f9ef361f109ee --
alexcrichton wrote:
At @sunfishcode's request I've pushed up a second commit which pass the path to
`wasm-ld` to `wasm-component-ld`, and in testing it I also added the ability
for `-fuse-ld=lld` to explicitly request that `wasm-ld` is used, regardless of
target.
https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/84569
>From 99ca952b60344d2ff683d05d8baa423aa11da83a Mon Sep 17 00:00:00 2001
From: Alex Crichton
Date: Fri, 8 Mar 2024 13:36:18 -0800
Subject: [PATCH 1/2] [WebAssembly] Change the default linker for
`wasm32-wasip2`
https://github.com/alexcrichton updated
https://github.com/llvm/llvm-project/pull/84569
>From 99ca952b60344d2ff683d05d8baa423aa11da83a Mon Sep 17 00:00:00 2001
From: Alex Crichton
Date: Fri, 8 Mar 2024 13:36:18 -0800
Subject: [PATCH 1/2] [WebAssembly] Change the default linker for
https://github.com/sbc100 approved this pull request.
https://github.com/llvm/llvm-project/pull/84569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexcrichton wrote:
ping @sbc100, happy to answer any more questions if you have them!
I was tentatively hoping this could get backported to an 18.1.x release so we
could get a wasi-sdk release with p1/p2/etc
https://github.com/llvm/llvm-project/pull/84569
alexcrichton wrote:
> So the core module + metadata is kind of isomorphic with that
> single-core-module-component?
Sort of and sort of not. At a high level you're correct, but at a technical
level this isn't correct. The subtle differences are:
* Most wasm binaries today using WASI probably
sbc100 wrote:
> Currently it accepts no extra inputs, but in the future I'd expect that it'll
> grow an option or two of its own
I was more asking about whether the file types is accepts are anything more
than object files and libraries. i.e. can you pass other core modules and have
sbc100 wrote:
I see, so `wasm-ld` builds "core module + metadata" and then
`wasm-component-ld` takes that metadata and uses it to wrap the core module
into a component (with exactly that one core module inside of it).
So the core module + metadata is kind of isomorphic with that
alexcrichton wrote:
Currently it accepts no extra inputs, but in the future I'd expect that it'll
grow an option or two of its own. Currently it [hand-codes the list of options
to forward to
sbc100 wrote:
Regarding WebAssembly/wasi-sdk and WebAssembly/wasi-libc, is there any reason
why simple programs wouldn't be core modules? Won't most C/C++ programs still
be build-able as just core modules?
https://github.com/llvm/llvm-project/pull/84569
https://github.com/sbc100 commented:
Does wasm-component-ld accept any other input types other than the ones that
wasm-ld accepts?
Does wasm-component-ld call wasm-ld internally?
Do we expect clang users to be building compound components using a single
clang command? i.e. will they be
alexcrichton wrote:
cc @sunfishcode and @sbc100
https://github.com/llvm/llvm-project/pull/84569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Alex Crichton (alexcrichton)
Changes
This commit changes the default linker in the WebAssembly toolchain for the
`wasm32-wasip2` target. This target is being added to the WebAssembly/wasi-sdk
and WebAssembly/wasi-libc projects to
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you,
https://github.com/alexcrichton created
https://github.com/llvm/llvm-project/pull/84569
This commit changes the default linker in the WebAssembly toolchain for the
`wasm32-wasip2` target. This target is being added to the WebAssembly/wasi-sdk
and WebAssembly/wasi-libc projects to target the
28 matches
Mail list logo
