[clang] [flang] [flang] Add MSC_VER and target arch defines when targeting the MSVC ABI (PR #73250)

https://github.com/DavidTruby closed https://github.com/llvm/llvm-project/pull/73250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Add MSC_VER and target arch defines when targeting the MSVC ABI (PR #73250)

https://github.com/DavidTruby updated https://github.com/llvm/llvm-project/pull/73250 >From 656463c6298b981cbd43d1d5042438eab700143b Mon Sep 17 00:00:00 2001 From: David Truby Date: Thu, 23 Nov 2023 15:32:57 + Subject: [PATCH 1/2] [flang] Add MSC_VER and target arch defines when targeting

[clang] [flang] [flang] Add MSC_VER and target arch defines when targeting the MSVC ABI (PR #73250)

@@ -204,6 +204,29 @@ void Flang::AddAArch64TargetArgs(const ArgList , } } +static void addVSDefines(const ToolChain , const ArgList , DavidTruby wrote: I named it this way to match processVSRuntimeLibs which I stole from clang :)

[clang] [flang] [flang] Add MSC_VER and target arch defines when targeting the MSVC ABI (PR #73250)

@@ -204,6 +204,29 @@ void Flang::AddAArch64TargetArgs(const ArgList , } } +static void addVSDefines(const ToolChain , const ArgList , + ArgStringList ) { + + unsigned ver = 0; + const VersionTuple vt = TC.computeMSVCVersion(nullptr, Args); + ver =

[clang] [flang] [flang] Add MSC_VER and target arch defines when targeting the MSVC ABI (PR #73250)

@@ -204,6 +204,29 @@ void Flang::AddAArch64TargetArgs(const ArgList , } } +static void addVSDefines(const ToolChain , const ArgList , + ArgStringList ) { + + unsigned ver = 0; + const VersionTuple vt = TC.computeMSVCVersion(nullptr, Args); + ver =

[clang] [flang] [flang] Add MSC_VER and target arch defines when targeting the MSVC ABI (PR #73250)

@@ -322,6 +345,7 @@ void Flang::addTargetOptions(const ArgList , if (Triple.isKnownWindowsMSVCEnvironment()) { processVSRuntimeLibrary(TC, Args, CmdArgs); +addVSDefines(TC, Args, CmdArgs); } // TODO: Add target specific flags, ABI, mtune option etc.

[clang] [flang] [flang] Add MSC_VER and target arch defines when targeting the MSVC ABI (PR #73250)

@@ -204,6 +204,29 @@ void Flang::AddAArch64TargetArgs(const ArgList , } } +static void addVSDefines(const ToolChain , const ArgList , + ArgStringList ) { + + unsigned ver = 0; + const VersionTuple vt = TC.computeMSVCVersion(nullptr, Args); + ver =

[clang] [flang] [flang] Add MSC_VER and target arch defines when targeting the MSVC ABI (PR #73250)

@@ -204,6 +204,29 @@ void Flang::AddAArch64TargetArgs(const ArgList , } } +static void addVSDefines(const ToolChain , const ArgList , banach-space wrote: ```suggestion static void addMSVCDefines(const ToolChain , const ArgList , ``` ?

[clang] [flang] [flang] Add MSC_VER and target arch defines when targeting the MSVC ABI (PR #73250)

bradking wrote: This file has CRLF newlines. Is that expected? https://github.com/llvm/llvm-project/pull/73250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [flang] [flang] Add MSC_VER and target arch defines when targeting the MSVC ABI (PR #73250)

pbo-linaro wrote: I'll let @bradking check this, as he implemented this. https://github.com/llvm/llvm-project/pull/73250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits