[libunwind] [libunwind] Compile the asm as well as the C++ source (PR #86351)

2024-03-23 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > I'm sorry to hear that. Reading through > https://libcxx.llvm.org/BuildingLibcxx.html now to see if I can make > ENABLE_RUNTIMES behave itself under cross compilation. I'm familiar with this > in the context of the "bootstrapping" build from the docs, the build clang >

[libunwind] [libunwind] Compile the asm as well as the C++ source (PR #86351)

2024-03-22 Thread Jon Chesterfield via cfe-commits
JonChesterfield wrote: I'm sorry to hear that. I've only used the ENABLE_RUNTIMES in the context of compiling clang first, and then compiling the libraries under runtime with that clang. The recursive invocation drops (most) arguments passed to cmake which has been obstructive in the past.

[libunwind] [libunwind] Compile the asm as well as the C++ source (PR #86351)

2024-03-22 Thread Alexander Richardson via cfe-commits
arichardson wrote: It might make sense to restore the `message(FATAL_ERROR)` since that is any easy mistake to make considering it used to be the default way of building libunwind. https://github.com/llvm/llvm-project/pull/86351 ___ cfe-commits

[libunwind] [libunwind] Compile the asm as well as the C++ source (PR #86351)

2024-03-22 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: This build configuration was explicitly made disallowed in 6f17768e11480063f4c2bcbeea559505fee3ea19, with an error message explaining the situation. However that error message was later removed in 0a22dfcb11c05cbd4f654c8ef1868a4bc6085140.

[libunwind] [libunwind] Compile the asm as well as the C++ source (PR #86351)

2024-03-22 Thread via cfe-commits
github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the Python code formatter. https://github.com/llvm/llvm-project/pull/86351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libunwind] [libunwind] Compile the asm as well as the C++ source (PR #86351)

2024-03-22 Thread via cfe-commits
github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the C/C++ code formatter. https://github.com/llvm/llvm-project/pull/86351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libunwind] [libunwind] Compile the asm as well as the C++ source (PR #86351)

2024-03-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libunwind Author: Jon Chesterfield (JonChesterfield) Changes When a CMakeLists.txt is missing a 'project' statement you get the default supported languages of C and CXX. https://cmake.org/cmake/help/latest/command/project.html. The help says ASM

[libunwind] [libunwind] Compile the asm as well as the C++ source (PR #86351)

2024-03-22 Thread Jon Chesterfield via cfe-commits
https://github.com/JonChesterfield created https://github.com/llvm/llvm-project/pull/86351 When a CMakeLists.txt is missing a 'project' statement you get the default supported languages of C and CXX. https://cmake.org/cmake/help/latest/command/project.html. The help says ASM should be listed