[clang] [llvm] [mlir] Move several vector intrinsics out of experimental namespace (PR #88748)

2024-04-29 Thread Maciej Gabka via cfe-commits
https://github.com/mgabka closed https://github.com/llvm/llvm-project/pull/88748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] Move several vector intrinsics out of experimental namespace (PR #88748)

2024-04-29 Thread Maciej Gabka via cfe-commits
mgabka wrote: I needed to adjust one more test after another rebase: llvm/test/Transforms/LoopVectorize/AArch64/reduction-recurrence-costs-sve.ll I am merging it know without waiting for the pre commit validation, otrherwise will most likely need to update another tests etc.

[clang] [llvm] [mlir] Move several vector intrinsics out of experimental namespace (PR #88748)

2024-04-26 Thread Paul Walker via cfe-commits
https://github.com/paulwalker-arm approved this pull request. https://github.com/llvm/llvm-project/pull/88748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] Move several vector intrinsics out of experimental namespace (PR #88748)

2024-04-26 Thread Cullen Rhodes via cfe-commits
@@ -0,0 +1,46 @@ +; RUN: opt -S < %s | FileCheck %s c-rhodes wrote: ah ok, that makes sense  https://github.com/llvm/llvm-project/pull/88748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [mlir] Move several vector intrinsics out of experimental namespace (PR #88748)

2024-04-26 Thread Maciej Gabka via cfe-commits
@@ -0,0 +1,46 @@ +; RUN: opt -S < %s | FileCheck %s mgabka wrote: I would prefer to keep it, as this is checking it the auto upgrade triggers when we have IR->IR transformation, while the other RUN line is about IR->bitcode->IR flow, and they could use same

[clang] [llvm] [mlir] Move several vector intrinsics out of experimental namespace (PR #88748)

2024-04-26 Thread Cullen Rhodes via cfe-commits
@@ -0,0 +1,46 @@ +; RUN: opt -S < %s | FileCheck %s c-rhodes wrote: this `opt` line can be removed? Likewise for other upgrade tests. https://github.com/llvm/llvm-project/pull/88748 ___ cfe-commits mailing list

[clang] [llvm] [mlir] Move several vector intrinsics out of experimental namespace (PR #88748)

2024-04-26 Thread Cullen Rhodes via cfe-commits
https://github.com/c-rhodes approved this pull request. one final comment, otherwise LGTM cheers. https://github.com/llvm/llvm-project/pull/88748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [mlir] Move several vector intrinsics out of experimental namespace (PR #88748)

2024-04-26 Thread Cullen Rhodes via cfe-commits
https://github.com/c-rhodes edited https://github.com/llvm/llvm-project/pull/88748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] Move several vector intrinsics out of experimental namespace (PR #88748)

2024-04-26 Thread Benjamin Maxwell via cfe-commits
MacDue wrote: > @c-rhodes the remaining failure is MLIR :: > Conversion/TosaToTensor/tosa-to-tensor.mlir but it also fails without my > changes. Very likely unrelated we only added `interleave2` for use in ArmSME. It's not used within high-level dialects like tosa & tensor.

[clang] [llvm] [mlir] Move several vector intrinsics out of experimental namespace (PR #88748)

2024-04-26 Thread Maciej Gabka via cfe-commits
mgabka wrote: @c-rhodes the remaining failure is MLIR :: Conversion/TosaToTensor/tosa-to-tensor.mlir but it also fails without my changes. https://github.com/llvm/llvm-project/pull/88748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org