[cgiapp] Re: Proposal for Error handling runmode

2004-08-27 Thread Mark Stosberg
On 2004-08-27, Kinyon, Rob [EMAIL PROTECTED] wrote: I apologize for sending the patch in the wrong format. Future patches will most certainly be sent the right way. Thanks for the tip! I wouldn't say it was wrong, just less preferable. :) If you don't receive and process many patches, it's

[cgiapp] RE: Proposal for Error handling runmode

2004-08-26 Thread Kinyon, Rob
I've attached a tar.gz of all the files I added and/or changed. I'm not sure of what format things are supposed to be in, so I just pulled all the new/modded files together in one directory and tar/gz'ed them up. Changed: lib/CGI/Application.pm MANIFEST Changes New:

[cgiapp] Re: Proposal for Error handling runmode

2004-08-26 Thread Mark Stosberg
On 2004-08-26, Kinyon, Rob [EMAIL PROTECTED] wrote: --_=_NextPart_001_01C48B6F.A54FA8DE Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable I've attached a tar.gz of all the files I added and/or changed. I'm not sure of what format things are

Re: [cgiapp] Re: Proposal for Error handling runmode

2004-08-26 Thread Stephen Howard
I agree it's a little self-defeating to eval the error run mode. What would you do with the caught exception other than die with $@ anyways? You certainly wouldn't try to run the error mode again. -Stephen Mark Stosberg wrote: On 2004-08-26, Kinyon, Rob [EMAIL PROTECTED] wrote:

[cgiapp] RE: Proposal for Error handling runmode

2004-08-25 Thread Kinyon, Rob
I would love to do so! Do you want me to send it to this list or to a specific set of people for review? Thanks, Rob -Original Message- From: Mark Stosberg [mailto:[EMAIL PROTECTED] Sent: Monday, August 23, 2004 7:15 PM To: [EMAIL PROTECTED] Subject: Re: Proposal for Error handling

[cgiapp] RE: Proposal for Error handling runmode

2004-08-23 Thread Kinyon, Rob
I initially tried to get Apache 2.0.50's ErrorDocument to work, but I wasn't able to pass a parameter to it. (ErrorDocument 500 /cgi-bin/main.cgi?mode=error didn't work, for some reason ...) So, I wanted to trap Perl runtime errors. Your suggestion of an error run-mode is orthogonal to my goal,

[cgiapp] Re: Proposal for Error handling runmode

2004-08-23 Thread Mark Stosberg
On 2004-08-23, Kinyon, Rob [EMAIL PROTECTED] wrote: I initially tried to get Apache 2.0.50's ErrorDocument to work, but I wasn't able to pass a parameter to it. (ErrorDocument 500 /cgi-bin/main.cgi?mode=error didn't work, for some reason ...) So, I wanted to trap Perl runtime errors. Your

Re: [cgiapp] Re: Proposal for Error handling runmode

2004-08-23 Thread Michael Peters
Mark Stosberg wrote: On 2004-08-23, Kinyon, Rob [EMAIL PROTECTED] wrote: Thanks for the response. Your counter-points are sound. While I understand your proposal would be backwards compatible, I have concerns that it could promote what I think is poor application design-- sending un-trapped perl

Re: [cgiapp] Re: Proposal for Error handling runmode

2004-08-23 Thread Bill Catlan
I have implemented a die handler for a group of modules that I have integrated. Just like I wanted them to all use the same config file and object, I wanted them to die the same way. This proved trickier than it sounds given mod_perl's special way of diing - using the Apache exit function.

Re: [cgiapp] Re: Proposal for Error handling runmode

2004-08-23 Thread Peter Masiar
Michael Peters wrote: Mark Stosberg wrote: On 2004-08-23, Kinyon, Rob [EMAIL PROTECTED] wrote: Thanks for the response. Your counter-points are sound. While I understand your proposal would be backwards compatible, I have concerns that it could promote what I think is poor application design--

RE: [cgiapp] Re: Proposal for Error handling runmode

2004-08-23 Thread Kleindenst, Fred
::A have seperately written this type functionality but that the code hasn't made its way to the wiki or to CPAN. Cheers --Fred -Original Message- From: Michael Peters [mailto:[EMAIL PROTECTED] Sent: Saturday, August 21, 2004 4:10 PM To: [EMAIL PROTECTED] Subject: Re: [cgiapp] Re: Proposal

RE: [cgiapp] Re: Proposal for Error handling runmode

2004-08-23 Thread Kinyon, Rob
or recursion that goes too deep. Not everyone can use Apache's ErrorDocument. Rob -Original Message- From: Michael Peters [mailto:[EMAIL PROTECTED] Sent: Saturday, August 21, 2004 7:10 PM To: [EMAIL PROTECTED] Subject: Re: [cgiapp] Re: Proposal for Error handling runmode Mark Stosberg

[cgiapp] Re: Proposal for Error handling runmode

2004-08-23 Thread Mark Stosberg
Rob -- On 2004-08-23, Kinyon, Rob [EMAIL PROTECTED] wrote: I would change that slightly. What I have is the following: my $body; eval { if ($self-can($rmeth)) { $body = $autoload_mode ? $self-$rmeth($rm) : $self-$rmeth(); } else { $body = eval {

[cgiapp] Re: Proposal for Error handling runmode

2004-08-21 Thread Mark Stosberg
On 2004-08-19, Kinyon, Rob [EMAIL PROTECTED] wrote: What do folks think about allowing an error-handling runmode within CGI::Application. Do something like: sub setup { my $self = shift; $self-error_mode( 'error_in_page' ); $self-SUPER::setup( @_ ); }

[cgiapp] Re: Proposal for Error handling runmode

2004-08-21 Thread Lance A. Brown
Mark Stosberg wrote: It's so simple that I have to wonder whether it's even worth adding to CGI::App, even as a plug-in. But having it out there, even as a plug-in, makes it easier to find and use it, or to expand upon. It's a nice little bit of code. --[Lance] -- Celebrate The Circle: