Re: [Chicken-hackers] [PATCH] Fix #765 and a small can of worms related to error handling under Windows

2013-12-11 Thread Christian Kellermann
* Peter Bex peter@xs4all.nl [131122 21:46]: Hi all, See the attached patch, it kind of speaks for itself. Thanks to arthurmaciel for testing this on XP, I have verified it does not break anything on windows 7 / 8. Thanks for the patch, Peter! Pushed. -- In the world, there is nothing

Re: [Chicken-hackers] [PATCH] Fix #765 and a small can of worms related to error handling under Windows

2013-12-01 Thread Peter Bex
On Thu, Nov 28, 2013 at 09:11:15PM +0100, Peter Bex wrote: On Fri, Nov 22, 2013 at 09:43:31PM +0100, Peter Bex wrote: The error handling in Windows was completely broken; the errmap loop updated map, but looked at errmap. This whole error handling shit needs to get reworked to make the

Re: [Chicken-hackers] [PATCH] Fix #765 and a small can of worms related to error handling under Windows

2013-11-28 Thread Peter Bex
On Fri, Nov 22, 2013 at 09:43:31PM +0100, Peter Bex wrote: The error handling in Windows was completely broken; the errmap loop updated map, but looked at errmap. On Wed, Nov 20, 2013 at 11:20:57PM +0100, Peter Bex wrote: Hi all, Due to Shanmuhanathan's report I looked into Spiffy on

Re: [Chicken-hackers] [PATCH] Fix #765 and a small can of worms related to error handling under Windows

2013-11-23 Thread Peter Bex
On Fri, Nov 22, 2013 at 09:05:54PM -0600, Jim Ursetto wrote: Can you confirm it works under XP as well? If so I'll apply it to stability. I'd be grateful if someone could verify this for me. The XP images from modern.ie don't seem to work on Qemu, and I've spent more than enough time in

Re: [Chicken-hackers] [PATCH] Fix #765 and a small can of worms related to error handling under Windows

2013-11-23 Thread Jim Ursetto
I do have an XP install somewhere -- how do I verify the fix? (Other than making sure it compiles cleanly.) On Nov 23, 2013, at 11:06, Peter Bex peter@xs4all.nl wrote: On Fri, Nov 22, 2013 at 09:05:54PM -0600, Jim Ursetto wrote: Can you confirm it works under XP as well? If so I'll

Re: [Chicken-hackers] [PATCH] Fix #765 and a small can of worms related to error handling under Windows

2013-11-23 Thread Peter Bex
On Sat, Nov 23, 2013 at 11:12:41AM -0600, Jim Ursetto wrote: I do have an XP install somewhere -- how do I verify the fix? (Other than making sure it compiles cleanly.) The process one is simple, see #765. Just run the new posix-tests.scm, that's why I've added some tests there. You can also

[Chicken-hackers] [PATCH] Fix #765 and a small can of worms related to error handling under Windows

2013-11-22 Thread Peter Bex
Hi all, See the attached patch, it kind of speaks for itself. I don't know why, but looks like Win7 doesn't allow cloning a handle from the current process and then setting its access to INHERIT. I guess this is a security measure, but it should be just fine if we clone it and keep the current

Re: [Chicken-hackers] [PATCH] Fix #765 and a small can of worms related to error handling under Windows

2013-11-22 Thread Jim Ursetto
Can you confirm it works under XP as well? If so I'll apply it to stability. Jim On Nov 22, 2013, at 2:43 PM, Peter Bex peter@xs4all.nl wrote: Hi all, See the attached patch, it kind of speaks for itself. I don't know why, but looks like Win7 doesn't allow cloning a handle from the