Re: [Chicken-hackers] [PATCH] Replace unsafe string functions with their safer counterparts

2014-02-07 Thread Mario Domenech Goulart
On Fri, 7 Feb 2014 21:45:34 +0100 Peter Bex wrote: > On Fri, Feb 07, 2014 at 09:27:04PM +0100, Peter Bex wrote: >> It works in Linux, and on Cygwin it now works up until the deploy tests. >> Those seem to be broken here, but I'm not sure why exactly. At least >> this patch doesn't make things wo

Re: [Chicken-hackers] [PATCH] Replace unsafe string functions with their safer counterparts

2014-02-07 Thread Peter Bex
On Fri, Feb 07, 2014 at 09:27:04PM +0100, Peter Bex wrote: > It works in Linux, and on Cygwin it now works up until the deploy tests. > Those seem to be broken here, but I'm not sure why exactly. At least > this patch doesn't make things worse so I think it should be applied. > We can then investi

Re: [Chicken-hackers] [PATCH] Replace unsafe string functions with their safer counterparts

2014-02-07 Thread Peter Bex
On Fri, Feb 07, 2014 at 12:52:50AM +, Mario Domenech Goulart wrote: > I quickly tested your patches. > > 0001-Prevent-problems-when-the-host... breaks Linux and mingw-msys > ("undefined reference to strlcat"). Doesn't seem to cause problems on > cygwin. Thanks for testing. I checked and it

Re: [Chicken-hackers] [PATCH] Replace unsafe string functions with their safer counterparts

2014-02-06 Thread Mario Domenech Goulart
Hi Peter, On Thu, 6 Feb 2014 10:04:08 +0100 Peter Bex wrote: > On Thu, Feb 06, 2014 at 02:21:07AM +, Mario Domenech Goulart wrote: >> On Wed, 05 Feb 2014 23:56:11 + Mario Domenech Goulart >> wrote: >> > The environment variable tests in posix-tests.scm caught the issue. >> > Here's an

Re: [Chicken-hackers] [PATCH] Replace unsafe string functions with their safer counterparts

2014-02-06 Thread Peter Bex
On Thu, Feb 06, 2014 at 02:21:07AM +, Mario Domenech Goulart wrote: > On Wed, 05 Feb 2014 23:56:11 + Mario Domenech Goulart > wrote: > > The environment variable tests in posix-tests.scm caught the issue. > > Here's an example: > > > > #;1> (use posix) > > ; loading c:/local/chicken-m

Re: [Chicken-hackers] [PATCH] Replace unsafe string functions with their safer counterparts

2014-02-05 Thread Mario Domenech Goulart
On Wed, 05 Feb 2014 23:56:11 + Mario Domenech Goulart wrote: > On Thu, 23 Jan 2014 12:28:01 +0100 Christian Kellermann > wrote: > >> I propose the following patch. It has been tested on OpenBSD and >> Linux. Should work without troubles on all other OSes as well. >> Please give it a try. >

Re: [Chicken-hackers] [PATCH] Replace unsafe string functions with their safer counterparts

2014-02-05 Thread Mario Domenech Goulart
Hi, On Thu, 23 Jan 2014 12:28:01 +0100 Christian Kellermann wrote: > I propose the following patch. It has been tested on OpenBSD and > Linux. Should work without troubles on all other OSes as well. > Please give it a try. Sorry for taking so long to give it a try on Windows. Unfortunately, i

Re: [Chicken-hackers] [PATCH] Replace unsafe string functions with their safer counterparts

2014-02-04 Thread Peter Bex
On Tue, Feb 04, 2014 at 11:05:48AM -0500, John Cowan wrote: > Peter Bex scripsit: > > > Yes, that's fine. I'm tired of arguing about this, and I know I can't > > win. I prefer getting the patch in over arguing about it, and nobody > > else seems to have an opinion about this. > > I do, actually.

Re: [Chicken-hackers] [PATCH] Replace unsafe string functions with their safer counterparts

2014-02-04 Thread John Cowan
Peter Bex scripsit: > Yes, that's fine. I'm tired of arguing about this, and I know I can't > win. I prefer getting the patch in over arguing about it, and nobody > else seems to have an opinion about this. I do, actually. The trouble with this code is that it copies a byte at a time, and so ma

Re: [Chicken-hackers] [PATCH] Replace unsafe string functions with their safer counterparts

2014-02-04 Thread Christian Kellermann
* Peter Bex [140203 22:30]: > On Thu, Jan 23, 2014 at 12:28:01PM +0100, Christian Kellermann wrote: > > Hi all, > > > > I propose the following patch. It has been tested on OpenBSD and > > Linux. Should work without troubles on all other OSes as well. > > Please give it a try. > > Hi Christian,

Re: [Chicken-hackers] [PATCH] Replace unsafe string functions with their safer counterparts

2014-02-04 Thread Peter Bex
On Tue, Feb 04, 2014 at 10:05:30AM +0100, Christian Kellermann wrote: > Hi Peter, > > please find my comments inline. > > * Peter Bex [140203 22:30]: > > After some reconsideration, I think this is probably a good idea. > > The big swath of OpenBSD license text for these rather small functions >

Re: [Chicken-hackers] [PATCH] Replace unsafe string functions with their safer counterparts

2014-02-04 Thread Christian Kellermann
* Christian Kellermann [140204 10:05]: > Hi Peter, > > please find my comments inline. > > * Peter Bex [140203 22:30]: > > After some reconsideration, I think this is probably a good idea. > > The big swath of OpenBSD license text for these rather small functions > > in our chicken.h really dis

Re: [Chicken-hackers] [PATCH] Replace unsafe string functions with their safer counterparts

2014-02-04 Thread Christian Kellermann
Hi Peter, please find my comments inline. * Peter Bex [140203 22:30]: > After some reconsideration, I think this is probably a good idea. > The big swath of OpenBSD license text for these rather small functions > in our chicken.h really disagreed with me (the license is barely smaller > than the

Re: [Chicken-hackers] [PATCH] Replace unsafe string functions with their safer counterparts

2014-02-03 Thread Peter Bex
On Thu, Jan 23, 2014 at 12:28:01PM +0100, Christian Kellermann wrote: > Hi all, > > I propose the following patch. It has been tested on OpenBSD and > Linux. Should work without troubles on all other OSes as well. > Please give it a try. Hi Christian, After some reconsideration, I think this is

Re: [Chicken-hackers] [PATCH] Replace unsafe string functions with their safer counterparts

2014-01-23 Thread .alyn.post.
I run OpenBSD as my primary development platform. I've updated to master, applied this patch, and rebuilt my eggs/development environment. After applying this patch, I no longer get linker errors building Chicken Scheme executables, and my local regression tests pass without error. -a On Thu, J

[Chicken-hackers] [PATCH] Replace unsafe string functions with their safer counterparts

2014-01-23 Thread Christian Kellermann
Hi all, I propose the following patch. It has been tested on OpenBSD and Linux. Should work without troubles on all other OSes as well. Please give it a try. Thanks, Christian -- In the world, there is nothing more submissive and weak than water. Yet for attacking that which is hard and strong