Re: [Chicken-hackers] [PATCH] Small improvement in Make's handling of variables, and a question about other common variables

2014-06-19 Thread Christian Kellermann
... also in the stability branch now. ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers

Re: [Chicken-hackers] [PATCH] Small improvement in Make's handling of variables, and a question about other common variables

2014-06-19 Thread Christian Kellermann
Thanks, I have pushed the patch. Christian ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers

Re: [Chicken-hackers] [PATCH] Small improvement in Make's handling of variables, and a question about other common variables

2014-06-17 Thread Aleksej Saushev
Hello, Peter Bex writes: > As I noticed in the pkgsrc script for building CHICKEN, we're being > somewhat inconsistent and incompatible with common UNIX practice in > our handling of user-settable variables in the Makefiles. > > Some like PREFIX, DESTDIR and PLATFORM but also C_COMPILER etc, c

Re: [Chicken-hackers] [PATCH] Small improvement in Make's handling of variables, and a question about other common variables

2014-06-14 Thread Oleg Kolosov
On 06/13/14 10:38, Peter Bex wrote: > On Fri, Jun 13, 2014 at 01:53:51AM +0400, Oleg Kolosov wrote: >> On 06/12/14 23:56, Peter Bex wrote: >> You can look for hints in commonly used build systems implementations. >> I'm not sure how autotools handle this, but CMake have quite elaborate >> rules, se

Re: [Chicken-hackers] [PATCH] Small improvement in Make's handling of variables, and a question about other common variables

2014-06-13 Thread Peter Bex
On Thu, Jun 12, 2014 at 09:56:50PM +0200, Peter Bex wrote: > But, like I said, it will probably break a shitload of scripts and > programs. To remedy that we can let C_COMPILER / C_COMPILER_OPTIONS > inherit from CC / CFLAGS by using "?=" judiciously: > > #

Re: [Chicken-hackers] [PATCH] Small improvement in Make's handling of variables, and a question about other common variables

2014-06-13 Thread Felix Winkelmann
From: Christian Kellermann Subject: Re: [Chicken-hackers] [PATCH] Small improvement in Make's handling of variables, and a question about other common variables Date: Fri, 13 Jun 2014 10:24:49 +0200 > Felix Winkelmann writes: > >>> Those two are a constant source of frustr

Re: [Chicken-hackers] [PATCH] Small improvement in Make's handling of variables, and a question about other common variables

2014-06-13 Thread Peter Bex
On Fri, Jun 13, 2014 at 10:14:51AM +0200, Felix Winkelmann wrote: > >> It might not be the best way but works so far. I'm no sure in particular > >> about -fno-strict-aliasing and -fwrapv. Maybe allowing user to override > >> these will break something subtly. > > > > Those two are a constant sour

Re: [Chicken-hackers] [PATCH] Small improvement in Make's handling of variables, and a question about other common variables

2014-06-13 Thread Christian Kellermann
Felix Winkelmann writes: >> Those two are a constant source of frustration :( I think we can best >> ignore them for now, as they're causing trouble either way: even providing >> them by default in the platform Makefiles can be problematic (see Haiku). > > Please note that these two options are

Re: [Chicken-hackers] [PATCH] Small improvement in Make's handling of variables, and a question about other common variables

2014-06-13 Thread Felix Winkelmann
> And, at Felix: what was the reason you didn't use CC but your own > C_COMPILER variable? Just to avoid getting in conflict with user settings, and perhaps also to make sure that these are chicken-specific. I agree that it probably makes more sense to use the "standard" variable names. felix _

Re: [Chicken-hackers] [PATCH] Small improvement in Make's handling of variables, and a question about other common variables

2014-06-13 Thread Felix Winkelmann
> >> It might not be the best way but works so far. I'm no sure in particular >> about -fno-strict-aliasing and -fwrapv. Maybe allowing user to override >> these will break something subtly. > > Those two are a constant source of frustration :( I think we can best > ignore them for now, as they'

Re: [Chicken-hackers] [PATCH] Small improvement in Make's handling of variables, and a question about other common variables

2014-06-12 Thread Peter Bex
On Fri, Jun 13, 2014 at 01:53:51AM +0400, Oleg Kolosov wrote: > On 06/12/14 23:56, Peter Bex wrote: > > > Anyway, long story short, I think it's a good idea to stick closer > > to commonly found conventions and to allow all the configurable > > directory prefixes to be copied from the environment.

Re: [Chicken-hackers] [PATCH] Small improvement in Make's handling of variables, and a question about other common variables

2014-06-12 Thread Oleg Kolosov
On 06/12/14 23:56, Peter Bex wrote: > Anyway, long story short, I think it's a good idea to stick closer > to commonly found conventions and to allow all the configurable > directory prefixes to be copied from the environment. You can look for hints in commonly used build systems implementations.

[Chicken-hackers] [PATCH] Small improvement in Make's handling of variables, and a question about other common variables

2014-06-12 Thread Peter Bex
[CCing Felix as he may have valuable historic insight and advice on this] Hi all, As I noticed in the pkgsrc script for building CHICKEN, we're being somewhat inconsistent and incompatible with common UNIX practice in our handling of user-settable variables in the Makefiles. Some like PREFIX, DE