[chromium-dev] Re: What's missing in my view?

2008-12-15 Thread Darin Fisher
Don't you still need to engage some of webkit's code to ensure that space is made for the resizer (when there is only a vertical scrollbar)? -Darin On Sun, Dec 14, 2008 at 10:27 PM, Marc-Andre Decoste m...@google.com wrote: Salut Darin, I know, I have investigated that route, but the

[chromium-dev] Re: What's missing in my view?

2008-12-15 Thread Peter Kasting
On Mon, Dec 15, 2008 at 8:06 AM, Darin Fisher da...@chromium.org wrote: Don't you still need to engage some of webkit's code to ensure that space is made for the resizer (when there is only a vertical scrollbar)? He's doing that. (I was confused on this point too.) This requires providing a

[chromium-dev] Re: What's missing in my view?

2008-12-15 Thread Peter Kasting
On Mon, Dec 15, 2008 at 10:12 AM, Peter Kasting pkast...@google.com wrote: The status bubble is overkill for this; it was a separate window mainly so it could move outside the main browser bounds as needed. Bah, I was wrong. Another issue is that the content area has its own HWND. If you

[chromium-dev] Re: What's missing in my view?

2008-12-15 Thread Ben Goodger (Google)
A few thoughts on implementing the resizer: - Windows supports a resizer hit test code return value from WM_NCHITTEST. I think it's something like HTBOTTOMRIGHT (it's actually not HTGROWBOX, that doesn't work). When you return this value for coordinates in the resizer area, Windows will do the

[chromium-dev] Re: What's missing in my view?

2008-12-15 Thread Darin Fisher
does the webkit resizer disappear when the download shelf appears? -darin On Mon, Dec 15, 2008 at 11:27 AM, Ben Goodger (Google) b...@chromium.orgwrote: A few thoughts on implementing the resizer: - Windows supports a resizer hit test code return value from WM_NCHITTEST. I think it's

[chromium-dev] Re: What's missing in my view?

2008-12-15 Thread Darin Fisher
sorry, s/does/should/ On Mon, Dec 15, 2008 at 11:44 AM, Darin Fisher da...@chromium.org wrote: does the webkit resizer disappear when the download shelf appears? -darin On Mon, Dec 15, 2008 at 11:27 AM, Ben Goodger (Google) b...@chromium.orgwrote: A few thoughts on implementing the

[chromium-dev] Re: What's missing in my view?

2008-12-15 Thread Ben Goodger (Google)
Yes that would be what would have to be done. The renderer would have to support showing/hiding it on demand. -Ben On Mon, Dec 15, 2008 at 11:44 AM, Darin Fisher da...@chromium.org wrote: does the webkit resizer disappear when the download shelf appears? -darin On Mon, Dec 15, 2008 at

[chromium-dev] Inline spell checking.

2008-12-15 Thread Aaron Boodman
It would be better if we could consult Google for spelling recommendations. It seems like I frequently misspell a word, get the red squiggly, get no recommendations from Chromium, then go to Google and it gets it exactly right. I know, this would be great for an extension. - a

[chromium-dev] Re: Inline spell checking.

2008-12-15 Thread Marc-Antoine Ruel
Use this as the example extension for the extension design? On Mon, Dec 15, 2008 at 3:14 PM, Aaron Boodman a...@chromium.org wrote: It would be better if we could consult Google for spelling recommendations. It seems like I frequently misspell a word, get the red squiggly, get no

[chromium-dev] Re: Inline spell checking.

2008-12-15 Thread Brett Wilson
On Mon, Dec 15, 2008 at 12:14 PM, Aaron Boodman a...@chromium.org wrote: It would be better if we could consult Google for spelling recommendations. It seems like I frequently misspell a word, get the red squiggly, get no recommendations from Chromium, then go to Google and it gets it exactly

[chromium-dev] Re: Inline spell checking.

2008-12-15 Thread Evan Martin
On Mon, Dec 15, 2008 at 12:14 PM, Aaron Boodman a...@chromium.org wrote: It would be better if we could consult Google for spelling recommendations. It seems like I frequently misspell a word, get the red squiggly, get no recommendations from Chromium, then go to Google and it gets it exactly

[chromium-dev] Re: Inline spell checking.

2008-12-15 Thread Peter Kasting
On Mon, Dec 15, 2008 at 1:27 PM, Evan Martin e...@chromium.org wrote: The problem isn't technical, it's that to do that spell correction it'd involve sending all text form data up to a Google server. Only misspelled words, right? PK --~--~-~--~~~---~--~~ You

[chromium-dev] Re: Inline spell checking.

2008-12-15 Thread Ian Fette
We actually looked into this earlier. One thing that stopped us from doing so is that the corrections are not based on proper spelling, but based rather on searches and results. The masses are not always right, and we thought it might be strange for your dictionary to be offering you spelling

[chromium-dev] Re: Inline spell checking.

2008-12-15 Thread Aaron Boodman
On Mon, Dec 15, 2008 at 1:52 PM, Ian Fette i...@chromium.org wrote: We actually looked into this earlier. One thing that stopped us from doing so is that the corrections are not based on proper spelling, but based rather on searches and results. The masses are not always right, and we thought

[chromium-dev] Re: Inline spell checking.

2008-12-15 Thread Matías
Hi, I think (based on what Aaron Boodman said) that you could put a separator with the google suggestions and list at least the 2 top suggestions (3 will be good). Masses could be wrong, but with the 2 or 3 top suggestions I think that you could provide a more accurate rainbow of alternatives.

[chromium-dev] Trunk build's biggest annoyances?

2008-12-15 Thread Mark Larson (Google)
Google employees: in case you're not paying attention, this thread is public on chromium-dev. I want to do a Dev channel release from the trunk soon. I know there are a lot of issues with the current trunk because it hasn't had the same test exposure or release pressure as the 154 branch. I

[chromium-dev] Re: Trunk build's biggest annoyances?

2008-12-15 Thread Peter Kasting
On Mon, Dec 15, 2008 at 4:50 PM, Mark Larson (Google) m...@chromium.orgwrote: So... what are the 1-3 top issues you think need to get fixed on trunk to make it bearable for everyday use? Maximized mode is pretty awful in XP and Vista non-Aero. PK

[chromium-dev] Re: bookmark menu

2008-12-15 Thread Peter Kasting
On Mon, Dec 15, 2008 at 4:50 PM, Darren Horrocks killallthehum...@gmail.com wrote: and as most people will only use the bookmark bar to access the other bookmarks button, Do you have data to back up this claim? PK --~--~-~--~~~---~--~~ You received this

[chromium-dev] Tree flakyness

2008-12-15 Thread Nicolas Sylvain
Hello, As you all know, our tests are really flaky and are causing the tree to be red too often. I took a quick look at the test logs and compiled the stats about all the flakyness. UI TESTS: In the last 7 days, 188 ui tests failed. 47 of them failed more than 30 times. The biggest

[chromium-dev] Re: Tree flakyness

2008-12-15 Thread Ojan Vafai
I have a fix pending for the CrossSite* ones. On Mon, Dec 15, 2008 at 4:58 PM, Nicolas Sylvain nsylv...@chromium.orgwrote: Hello, As you all know, our tests are really flaky and are causing the tree to be red too often. I took a quick look at the test logs and compiled the stats about

[chromium-dev] Re: Trunk build's biggest annoyances?

2008-12-15 Thread Patrick Johnson
I think http://crbug.com/5118 is one of my biggest annoyances. I'm a fan of tab dragging, and it's been fairly broken recently (at least in maximized mode). Patrick On Mon, Dec 15, 2008 at 4:50 PM, Mark Larson (Google) m...@chromium.org wrote: Google employees: in case you're not paying

[chromium-dev] Re: bookmark menu

2008-12-15 Thread Bizzeh
no, nothing i can give as a spreadsheet, hard fact, just what i have heard from people. to keep me from the effort of starting an argument that i wont win, because whoever's mind it is that decides this has already been made up, and this has less chance of getting in than the logo has of being

[chromium-dev] Re: bookmark menu

2008-12-15 Thread Pam Greene
On Mon, Dec 15, 2008 at 5:02 PM, Bizzeh killallthehum...@gmail.com wrote: no, nothing i can give as a spreadsheet, hard fact, just what i have heard from people. to keep me from the effort of starting an argument that i wont win, because whoever's mind it is that decides this has already

[chromium-dev] Re: bookmark menu

2008-12-15 Thread Adam Barth
I wonder if it would make sense to reuse the existing star button for something like this. The behavior could be similar to the back button in that clicking is different from clicking-and-holding / clicking-and-dragging. Adam On Mon, Dec 15, 2008 at 4:50 PM, Darren Horrocks

[chromium-dev] Re: bookmark menu

2008-12-15 Thread Ben Goodger (Google)
I am generally supportive of allowing users to put UI elements where they want, but I think the right context for this work is in allowing our toolbars to be customizable, as is possible in other software, rather than special casing this one particular issue. The end result for you, and others

[chromium-dev] Re: bookmark menu

2008-12-15 Thread Mohamed Mansour
Hi, I finally figured out what your trying to do, a place to quickly access your bookmarks. Which is really needed since it would be nice to have some sort of utility to quickly access your saved bookmarks. I think another icon would be needed since a UI with two same icons is not that great. So

[chromium-dev] Re: bookmark menu

2008-12-15 Thread Bizzeh
this has totally missed the issue, the issue is not about user customisation, its about user experiance. nowhere did i mention anything about customising the toolbar, and nowhere did i limit it. what i did do, was reduce the amount of time needed to navigate bookmarks, and make it obvious that

[chromium-dev] Re: bookmark menu

2008-12-15 Thread Ben Goodger (Google)
Thanks for taking the time to send us your thoughts. Chrome functions as a project at scale by maintaining a set of development principles (some of which are outlined here: http://dev.chromium.org/developers/contributing-code ). One of these principles is encouraging communication with each

[chromium-dev] Re: bookmark menu

2008-12-15 Thread Bizzeh
this views do intersect with my own, however i do not feel that i was fairly treated. i feel as if i was treated as the kid that nobody wants around at school because everybody is fine as they are. what i have tried to introduce today is a feature that is a staple part of a browser, fast

[chromium-dev] PSA: clobber build needed for windows

2008-12-15 Thread Ojan Vafai
Landed a webkit merge today that requires a clobber build for windows. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Chromium-dev group. To post to this group, send email to chromium-dev@googlegroups.com To

[chromium-dev] Feature: Extra field to store tags for each bookmark item

2008-12-15 Thread Mohamed Mansour
Just a feature which is pretty useful. Currently, a bookmark is defined by the following: 1) Name 2) Url 3) Folder Would be nice to add another field such as Tag (or Label), where we could tag our own bookmarks. Personally, I have around 100+ websites bookmarked, some websites title don't

[chromium-dev] Re: Feature: Extra field to store tags for each bookmark item

2008-12-15 Thread Peter Kasting
On Mon, Dec 15, 2008 at 8:19 PM, Mohamed Mansour m0.interact...@gmail.comwrote: Would be nice to add another field such as Tag (or Label), where we could tag our own bookmarks. I think we've generally agreed internally that this has at least some utility, but we haven't been as sure how to

[chromium-dev] porting views to linux/posix

2008-12-15 Thread joshthecoder
Currently the test_shell uses GTK to create a basic rendering for Chromium. What are the plans so far on how to port the Views UI layout layer to linux? Will a widget toolkit such as GTK be used? Or maybe just use a more direct approach such as XLib. Using XLib to directly communicate with X

[chromium-dev] Re: porting views to linux/posix

2008-12-15 Thread Mohamed Mansour
I would like to see the plans on how would we approach the porting,many views use direct Win32 API calls for mouse events, keyboard, painting, etc. What would the proper way doing this, create a class with a bunch if if-defs and just calling that. If there are plans on what to do, I could spend

[chromium-dev] Re: Trunk build's biggest annoyances?

2008-12-15 Thread Adam Barth
I'm not sure what the policy is for making up labels on the bug tracker, but I labeled these bugs SuperAnnoying. I filed and labeled another bug (space bar doesn't scroll window). Either my bug search skills suck or not that many people are dogfooding trunk. How can it be that no one noticed