[chromium-dev] Re: Network stack roadmap

2009-03-19 Thread PhistucK
*One more thing, is issue 2010http://code.google.com/p/chromium/issues/detail?id=2010, which discusses the option not to show the interstitial for for specific domains for a limited time (or forever, preferred).** *☆PhistucK On Mon, Mar 16, 2009 at 23:26, Wan-Teh Chang w...@google.com wrote:

[chromium-dev] Re: Visual Studio Conversion to 2008 not converting couple of projects 4 errors?

2009-03-19 Thread Mohamed Mansour
Hi, I did what you said, and now getting other files which failed: ..\googleurl\build\googleurl.vcproj ..\v8\tools\visual_studio\v8.vcproj ..\v8\tools\visual_studio\v8_base.vcproj ..\v8\tools\visual_studio\v8_mksnapshot.vcproj ..\v8\tools\visual_studio\v8_shell_sample.vcproj

[chromium-dev] Re: Network stack roadmap

2009-03-19 Thread Adam Barth
PhistucK, Thanks for your input, but the interstitial is handled at a different layer in the browser than the new network stack (chrome/browser versus net/http). Adam 2009/3/18 PhistucK phist...@gmail.com: One more thing, is issue 2010, which discusses the option not to show the

[chromium-dev] Re: sheriffs: please keep the purify bots green

2009-03-19 Thread Erik Kay
+yurys Thanks for tracking this one down, Alpha. Yury, I think the remaining error is yours (from http://codereview.chromium.org/42233 at r11855). Erik On Wed, Mar 18, 2009 at 2:29 PM, Alpha (Hin-Chung) Lam hc...@google.com wrote: Found the root in

[chromium-dev] ResourceMessageFilter::OnGet(Root)WindowRect and NULL windows

2009-03-19 Thread Avi Drissman
We've been seeing calls to ResourceMessageFilter::OnGet(Root)WindowRect for NULL windows. agl put in a fix for GTK with http://codereview.chromium.org/42356 and I'm seeing the same problem on the Mac. 1. Why isn't Windows seeing this? What happens when you pass a null HWND into ::GetAncestor and

[chromium-dev] Re: Visual Studio Conversion to 2008 not converting couple of projects 4 errors?

2009-03-19 Thread Marc-Antoine Ruel
+Brad Caused by the switch to GYP. On Thu, Mar 19, 2009 at 2:11 AM, Mohamed Mansour m0.interact...@gmail.com wrote: Hi, I did what you said, and now getting other files which failed: ..\googleurl\build\googleurl.vcproj ..\v8\tools\visual_studio\v8.vcproj

[chromium-dev] Re: Visual Studio Conversion to 2008 not converting couple of projects 4 errors?

2009-03-19 Thread Bradley Nelson
Very mysterious. These are gyp related: ..\base\base.vcproj ..\base\base_gfx.vcproj ..\base\base_unittests.vcproj ..\third_party\bzip2\bzip2.vcproj ..\net\crash_cache.vcproj ..\base\debug_message.vcproj But these are not: ..\googleurl\build\googleurl.vcproj ..\v8\tools\visual_studio\v8.vcproj

[chromium-dev] clobber build required on windows :-(

2009-03-19 Thread Darin Fisher
Turns out that VS doesn't know to re-generate precompiled headers when a define changes, so you will need to clobber your output directory. Or, if you want to save time, you can just delete the following output directories: {Debug,Release}/ obj/ renderer/ worker/ unit_tests/ -Darin

[chromium-dev] Re: ResourceMessageFilter::OnGet(Root)WindowRect and NULL windows

2009-03-19 Thread Craig Schlenter
Hi OK, that's interesting, thank you. Does GetAncestor return something valid when passed that null HWND or does it pass null through to GetwindowRect? It would also be interesting to know what rect it returns please. Maybe it doesn't matter ... I haven't looked at the renderer code that

[chromium-dev] Re: ResourceMessageFilter::OnGet(Root)WindowRect and NULL windows

2009-03-19 Thread Lei Zhang
#include stdio.h #include windows.h int main() { HWND hwnd = GetAncestor(NULL, GA_PARENT); printf(%p\n, hwnd); hwnd = GetAncestor(NULL, GA_ROOT); printf(%p\n, hwnd); hwnd = GetAncestor(NULL, GA_ROOTOWNER); printf(%p\n, hwnd); hwnd = GetAncestor(NULL, 0); printf(%p\n, hwnd);

[chromium-dev] Omnibox q around Mac+Chromium best-practices.

2009-03-19 Thread Scott Hess
I'm refactoring my Omnibox code towards something I'm willing to put up for review, and am realizing that I need to find a way to rule on whether I should have thick Objective-C helpers or thin ones.  Say for instance that I have an NSTableView, I'll need a data source for that, which needs to be

[chromium-dev] Re: Omnibox q around Mac+Chromium best-practices.

2009-03-19 Thread Brett Wilson
I would do the thin Objective C mode, partially since all Chrome developers know C++. I could debug that code or make changes to it if I was doing something that affected it, but I would have a much harder time with Objective-C. Brett On Thu, Mar 19, 2009 at 4:00 PM, Scott Hess

[chromium-dev] useless error messages

2009-03-19 Thread Dumitru Daniliuc
hi, i'm trying to add some code to the chromium code base and when i try to compile it i get these errors: 3MyFile.cpp 3C:\Program Files\Microsoft Visual Studio 8\VC\include\cstddef(18) : error C2039: 'ptrdiff_t' : is not a member of '`global namespace'' 3C:\Program Files\Microsoft Visual Studio

[chromium-dev] Re: Visual Studio Conversion to 2008 not converting couple of projects 4 errors?

2009-03-19 Thread Bradley Nelson
We are not using 2.6? Not at the moment. Thanks, at a loss to explain it. Let me know if this happens again. Has anyone else seen this sort of thing? -BradN On Thu, Mar 19, 2009 at 1:42 PM, Bradley Nelson bradnel...@google.com wrote: Very mysterious. These are gyp related:

[chromium-dev] [extensions] toolstrip default CSS

2009-03-19 Thread Aaron Boodman
I have a CL that implements default CSS for toolstrips to make 'em pretty (well, relatively pretty). But it doesn't work because the gradient crashes in webkit for some reason. Anyway, this isn't a huge need at this moment, so I'll probably abandon the change for now. But if anyone later wants