[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some browser helper process

2009-04-29 Thread David Levin
On Wed, Apr 29, 2009 at 7:02 AM, Peter Kasting pkast...@chromium.orgwrote: On Tue, Apr 28, 2009 at 6:38 PM, Jeremy Orlow jor...@chromium.org wrote: Darin was there on that lunch and was actually the one who first suggested running parts of WebCore in the browser to me during a 1:1. :-)

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some browser helper process

2009-04-29 Thread Jeremy Orlow
On Wed, Apr 29, 2009 at 7:43 AM, David Levin le...@google.com wrote: On Wed, Apr 29, 2009 at 7:02 AM, Peter Kasting pkast...@chromium.orgwrote: On Tue, Apr 28, 2009 at 6:38 PM, Jeremy Orlow jor...@chromium.orgwrote: Darin was there on that lunch and was actually the one who first

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some browser helper process

2009-04-29 Thread Dimitri Glazkov
I think it's a great idea and the only drawback I can see is the WTF dependency and the security implications, which shouldn't be anything we couldn't overcome. The biggest challenges IMHO would be: 1) clearly identifying what backend and frontend mean and where the separation occurs. I worry

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some browser helper process

2009-04-29 Thread Michael Nordman
Yup, I'm looking to work thru things in a similar fashion with anders (original appcache author). On Wed, Apr 29, 2009 at 11:53 AM, David Levin le...@google.com wrote: I think how to split/refactor depends on the feature, understanding the current code, and working with the appropriate webkit

[chromium-dev] Re: Changes to FilePath?

2009-04-29 Thread Mark Mentovai
Greg Spencer wrote: So there's currently no right way to do the conversion, but I still think that the FilePath constructor is probably in the best position to inspect LC_ALL, etc. and do as close to the right thing as possible.  I doubt most Linux developers even think about this, and so the

[chromium-dev] Re: [extensions] API sprucing

2009-04-29 Thread Ben Goodger (Google)
I'll raise this again: your js object that methods hang off should be called chrome not chromium... we use chrome in all of our other API points (chrome-ui:// and chrome-extensions:// protocol schemes, the user agent string etc). FYI - Chromium is the name of the project, not the product, and

[chromium-dev] Re: [extensions] API sprucing

2009-04-29 Thread Aaron Boodman
That's fine. As I said before, As it appears that nobody else does either, I'll make this a TODO to sweep through and fix. - a On Wed, Apr 29, 2009 at 1:51 PM, Ben Goodger (Google) b...@chromium.org wrote: I'll raise this again: your js object that methods hang off should be called chrome

[chromium-dev] Re: [extensions] API sprucing

2009-04-29 Thread Evan Martin
On Wed, Apr 29, 2009 at 1:51 PM, Ben Goodger (Google) b...@chromium.org wrote: I'll raise this again: your js object that methods hang off should be called chrome not chromium... we use chrome in all of our other API points (chrome-ui:// and chrome-extensions:// protocol schemes, the user

[chromium-dev] Today we run zero LayoutTests in chrome

2009-04-29 Thread Mike Belshe
We're still using the test-shell to run the LayoutTests.I just fixed a bug, wrote a layout test, and then realized how dumb I was because the code I was testing was only in Chrome, and not in the test_shell. I think we're accumulating a lot of code that is chrome specific, but which could

[chromium-dev] Re: Today we run zero LayoutTests in chrome

2009-04-29 Thread Mark Larson (Google)
On Wed, Apr 29, 2009 at 14:05, Mike Belshe mbel...@google.com wrote: We're still using the test-shell to run the LayoutTests.I just fixed a bug, wrote a layout test, and then realized how dumb I was because the code I was testing was only in Chrome, and not in the test_shell. I think

[chromium-dev] Re: [extensions] API sprucing

2009-04-29 Thread Ben Goodger (Google)
I said this back when we set up the Chromium project before launching the public beta. We deliberately decided not to change any of the code (see all our include lines that start with CHROME_ or chrome/ etc.) There should be no difficulty or careful judgment to be made here. It's very simple. In

[chromium-dev] Re: Today we run zero LayoutTests in chrome

2009-04-29 Thread Mike Belshe
The more I think about this, the more trouble we might be in :-) Page cyclers are also misleading as they test Test Shell, not Chrome. To illustrate I ran a few tests with the moz page cycler: Test-shell: 29.41 Chrome default: 37.43 Chrome w/ Extensions and Web Workers

[chromium-dev] Re: Today we run zero LayoutTests in chrome

2009-04-29 Thread Mike Belshe
Whoops - I was wrong on this. page cycler tests on the bbots do run chrome now. Bug on making v8::extensions less costly is http://crbug.com/11189 Mike On Wed, Apr 29, 2009 at 3:02 PM, Mike Belshe mbel...@google.com wrote: The more I think about this, the more trouble we might be in :-)

[chromium-dev] Re: Changes to FilePath?

2009-04-29 Thread Greg Spencer
On Wed, Apr 29, 2009 at 12:22 PM, Mark Mentovai m...@chromium.org wrote: I understand your problem. You're saying I have user-supplied data that I want to build a filename from, and I have this pathname that I want to display back to the user. I agree that it would be good to have a way to

[chromium-dev] Some help with Layout Test regressions

2009-04-29 Thread Jeremy Moskovich
Hi, Today's WebKit merge (42932:42994 - http://trac.webkit.org/changeset?new=42...@trunkold=42...@trunk) has brought in some new regressions. If anyone has any spare cycles I'd really appreciate it if you might be able to look at these - http://crbug.com/11178: xss stuff:

[chromium-dev] Re: Some help with Layout Test regressions

2009-04-29 Thread Dimitri Glazkov
There's a change to DOMWindow.idl, which pretty much always warrants a clobber on Win builds. I just clobbered WebKit builder, let's see what happens. :DG On Wed, Apr 29, 2009 at 4:11 PM, Jeremy Moskovich jer...@chromium.org wrote: Hi, Today's WebKit merge (42932:42994 -

[chromium-dev] Improving build time on Linux

2009-04-29 Thread Scott Violet
I was greatly disheartened when I set up a build environment on my Linux box and realized it takes 36 seconds for scons to figure out nothing has changed. After talking with Stephen he suggested the following command line: hammer --implicit-conversion app LOAD=app,browser This dropped the time

[chromium-dev] Tech talk videos

2009-04-29 Thread Jeremy Orlow
Just wanted to let everyone know that we posted videos of 5 tech talks related to Chromium. There's a blog post on the Chromium Blog ( http://blog.chromium.org/2009/04/chromium-tech-talks.html), but here are some direct links: Darin Fisher http://www.youtube.com/watch?v=A0Z0ybTCHKs talking about

[chromium-dev] Re: depricating CppBindingClass

2009-04-29 Thread Marshall Greenblatt
Hi All, I'm excited about using v8::Extension instead of CppBoundClass but the JavaScript side of v8::Extension (via the |source| argument) seems a bit magical to me. Is there a document that explains the usage and capabilities of v8::Extension in greater detail? I have the following questions