[chromium-dev] Re: Print Settings Mockup

2009-06-03 Thread Ian Fette
I notice you did not include page size, yet all the MSFT ones have it. I personally find this useful (my printer has both 8.5x11 and A4 loaded, and I use them both -- mostly 8.5x11, but a4 when I'm printing certain PDFs (magazine articles, forms, etc from anywhere other than the US). Maybe I'm

[chromium-dev] Re: Print Settings Mockup

2009-06-03 Thread Scott Hess
Aha, perfect setup to a point I neglected to make: Lets make simple things simple, and hard things possible, here. I feel for Ian, but only a little. The reason I threw out an idea around headers and footers is not because I use them a lot, it's because I have no idea at all what my current

[chromium-dev] Where is the code to pop up dialog

2009-06-03 Thread Daniel Dreiberg
Hi, I am looking for pointers tor the code which pop up dialog in chromium? e.g. JavaScript alert dialog or confirm dialog? I am specifically looking how that is done on MacOS. Thank you. --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] Re: Print Settings Mockup

2009-06-03 Thread Marc-Antoine Ruel
Yes it's still the goal but in the mean time it'd be nice to have something to be able to configure the basic settings. On Wed, Jun 3, 2009 at 4:16 AM, Ben Goodger (Google) b...@chromium.orgwrote: I don't like these dialog boxes... I thought we had a more ambitious goal once upon a time to do

[chromium-dev] Re: Does anyone have objections to adding a GetSwitchValues() accessor to CommandLine?

2009-06-03 Thread Thomas Van Lenten
On Wed, Jun 3, 2009 at 12:06 AM, Book'em Dano daniel.c...@gmail.com wrote: Does anyone have objections to including such a function? It would just return a copy of std::mapstd::string, StringType switches_; I'd like to add such a function so that I can iterate over the command line args

[chromium-dev] Re: setup.exe doesn't run work for me

2009-06-03 Thread nakro
Sverir, thank you very much for your reply, i posted this as a possible bug plus ideas on how to fix this http://code.google.com/p/chromium/issues/detail?id=13239 i am still not sure why it only happens on my machine, as i am sure all of you have no issues but i am no manifest expert in any

[chromium-dev] Re: Where is the code to pop up dialog

2009-06-03 Thread Mike Pinkerton
chrome/browser/app_modal_dialog_mac.mm Once we figure out the right way to do these as per-tab sheets, they'll no longer be app-modal. I found this with a quick spotlight search for NSAlert. On Wed, Jun 3, 2009 at 3:05 AM, Daniel Dreiberg daniel.dreiber...@gmail.com wrote: Hi, I am looking

[chromium-dev] Re: Print Settings Mockup

2009-06-03 Thread Mohamed Mansour
Then you could directly see the effect of the settings you were changing on the printed output. So similar what Scott suggestion regarding inline editing? So something like this, or even more real-time ... NOTE: I just drew this at work with mspaint with paint brush and transform ;x

[chromium-dev] Re: Where is the code to pop up dialog

2009-06-03 Thread Mohamed Mansour
There is a RunJavaScriptAlert in chrome/renderer/render_view.cc where you can just do: RunJavaScriptAlert(frame, l10n_util::GetString(IDS_HELLO_TITLE)); -- Mohamed Mansour On Wed, Jun 3, 2009 at 8:24 AM, Mike Pinkerton pinker...@chromium.orgwrote: chrome/browser/app_modal_dialog_mac.mm

[chromium-dev] Re: Print Settings Mockup

2009-06-03 Thread Marc-Antoine Ruel
That's an idea of what it'll looks like when embedded in a tab but it's dependent on Sverrir's (and future) work. M-A On Wed, Jun 3, 2009 at 9:56 AM, Mohamed Mansour m0.interact...@gmail.comwrote: Then you could directly see the effect of the settings you were changing on the printed output.

[chromium-dev] Re: setup.exe doesn't run work for me

2009-06-03 Thread Sverrir Á . Berg
No problem. Are you using Visual Studio 2008? Since the official builders are on VS2005 I suspect there are some incompatibilities between the toolchains on those two. Sverrir On Wed, Jun 3, 2009 at 8:06 AM, nakro yoav.zilberb...@gmail.com wrote: Sverir, thank you very much for your reply,

[chromium-dev] Re: recursive directory watcher on linux.

2009-06-03 Thread Paweł Hajdan Jr .
Looks like it's not that simple. Nobody responded. :-/ I analyzed inotify-tools source and they do everything on paths. Of course that means a lot of careful updating etc, but should work in lack of more elegant solution. Paweł On Sun, May 24, 2009 at 20:47, j.din...@gmail.com

[chromium-dev] Re: Does anyone have objections to adding a GetSwitchValues() accessor to CommandLine?

2009-06-03 Thread Book'em Dano
For Chromium that may be the case, but there are other projects that are also using the CommandLine class that may/do have other reqs. On Jun 3, 5:02 am, Thomas Van Lenten thoma...@chromium.org wrote: On Wed, Jun 3, 2009 at 12:06 AM, Book'em Dano daniel.c...@gmail.com wrote: Does anyone have

[chromium-dev] Re: DLLs missing and DCHECKs in recent builds

2009-06-03 Thread Glen Murphy
To add to this - someone else running into this mentioned that they needed to also build chrome_resources to get theme_dll to build. You'll also need to manually build crash_service if you're building any of the tests. On Tue, Jun 2, 2009 at 9:19 PM, Glen Murphyg...@chromium.org wrote: I

[chromium-dev] Fwd: Chromium code coverage dashboard is up

2009-06-03 Thread Randall Spangler
The Chromium code coverage dashboard is now live! View it here: http://build.chromium.org/buildbot/coverage/ ...or click on the 'coverage' link at the top of the main http://build.chromium.org waterfall, right next to the 'perf' link. This dashboard reports code coverage statistics on Chromium

[chromium-dev] Re: DLLs missing and DCHECKs in recent builds

2009-06-03 Thread Erik Kay
I haven't seen anyone else mention this, but I also had to manually rebuild tcmalloc for my build to succeed, otherwise I'd get: LINK : fatal error LNK1181: cannot open input file 'E:\src\cr\src\chrome\Debug\obj\tcmalloc\libcmt.lib' Erik On Wed, Jun 3, 2009 at 10:23 AM, Glen Murphy

[chromium-dev] Re: recursive directory watcher on linux.

2009-06-03 Thread Stefan Nuxoll
inotify is a piece of crap, you can only monitor a directory, from that you have to reread the listing and see what's changed for yourself. 2009/6/3 Paweł Hajdan Jr. phajdan...@chromium.org: Looks like it's not that simple. Nobody responded. :-/ I analyzed inotify-tools source and they do

[chromium-dev] Re: recursive directory watcher on linux.

2009-06-03 Thread Stefan Nuxoll
Since we're using GTK for the Linux port would there be any reason not to use FAM (File Alteration Monitor) which supports things like this? Yet another dependency for users of other DE's, but most of them probably won't use chromium due to GTK anyway. 2009/6/3 Dan Kegel

[chromium-dev] Re: recursive directory watcher on linux.

2009-06-03 Thread Stefan Nuxoll
There is a rewrite (or cleaned up version, I'm not sure) maintained by GNOME called gamin. 2009/6/3 Dan Kegel daniel.r.ke...@gmail.com: FAM is pretty old, and didn't have a sterling reputation for scalability. inotify would probably be better. (The FAM mailing list at SGI appears to be

[chromium-dev] Re: recursive directory watcher on linux.

2009-06-03 Thread Dan Kegel
FAM is pretty old, and didn't have a sterling reputation for scalability. inotify would probably be better. (The FAM mailing list at SGI appears to be dead...?) On Wed, Jun 3, 2009 at 10:56 AM, Stefan Nuxoll ste...@nuxoll.eu.org wrote: Since we're using GTK for the Linux port would there be any

[chromium-dev] Re: recursive directory watcher on linux.

2009-06-03 Thread Dan Kegel
gamin is probably closer to usable, but I'm a bit nervous about depending on it. It looks like the JDS guys found a performance bug last year http://mail.opensolaris.org/pipermail/jds-review/2008-March/002295.html but no new release of gamin has appeared in

[chromium-dev] Re: recursive directory watcher on linux.

2009-06-03 Thread Stefan Nuxoll
Mmm, the last commit was at 2008-10-20. So it does unfortunately look like using inotify would be for the best. 2009/6/3 Dan Kegel daniel.r.ke...@gmail.com gamin is probably closer to usable, but I'm a bit nervous about depending on it. It looks like the JDS guys found a performance bug

[chromium-dev] [extensions] Gleam API proposal

2009-06-03 Thread Aaron Boodman
[I actually created this awhile ago, but never sent it 'round] It is really common for extensions to want to offer additional contextual options for content elements. For example Download this movie, edit this image, call this phone number, etc. You can use content scripts for this, but since

[chromium-dev] Re: Fwd: Chromium code coverage dashboard is up

2009-06-03 Thread Dean McNamee
Seems there are some bugs relating to which files count. For example: http://build.chromium.org/buildbot/coverage/linux-debug/17471/CHROMIUM/base/index.html It counts files like wmi_util, which is Windows specific and not compiled on Linux. On Wed, Jun 3, 2009 at 9:12 PM, Paweł Hajdan

[chromium-dev] Re: [extensions] Gleam API proposal

2009-06-03 Thread Brett Wilson
On Wed, Jun 3, 2009 at 1:00 PM, Aaron Boodman a...@chromium.org wrote: [I actually created this awhile ago, but never sent it 'round] It is really common for extensions to want to offer additional contextual options for content elements. For example Download this movie, edit this image,

[chromium-dev] Re: [extensions] Gleam API proposal

2009-06-03 Thread Aaron Boodman
On Wed, Jun 3, 2009 at 1:33 PM, Brett Wilson bre...@chromium.org wrote: Say I have an extension that allows me to open images in Photoshop. Does that mean all images would have these things highlighting them? That seems like it would be annoying. Yeah, we'd have to experiment with the

[chromium-dev] Re: [linux] nested messageloop patch landed

2009-06-03 Thread Evan Martin
This patch, aside from fixing Antoine's problem and those other two bugs, seems to have significantly improved our startup time: http://build.chromium.org/buildbot/perf/linux-release/startup/report.html?history=150 (The second drop is due to running on new hardware.) I kinda suspect we're

[chromium-dev] Re: Fwd: Chromium code coverage dashboard is up

2009-06-03 Thread Randall Spangler
Hi Pawel, - Green = executable line of code which was actually run by the tests. - Yellow = executable line of code which was compiled into a test (and thus seen by the coverage instrumentation tools), but not run by the test. For example, a function not called as part of the test, or

[chromium-dev] Re: [linux] nested messageloop patch landed

2009-06-03 Thread Nicolas Sylvain
On Wed, Jun 3, 2009 at 3:25 PM, Lei Zhang thes...@chromium.org wrote: Aren't the bots in virtual machines? Since we're in the middle of some hardware upgrades, perhaps the new host machine isn't as loaded. Would that affect the performance numbers? The first time the blue line dropped it

[chromium-dev] Processing Nominations on Thursdays

2009-06-03 Thread Jon
I am batching up the requests for provisional and full committer access and processing them on Thursdays. If people are speedy about getting back to me as I ask them to create their accounts then I can usually complete them all within the day. If there is a real emergency I'll certainly make an

[chromium-dev] Re: Fwd: Chromium code coverage dashboard is up

2009-06-03 Thread Antoine Labour
2009/6/3 Randall Spangler rspang...@google.com: Hi Dean, Croc (the coverage utility) currently takes an expansive view of which files need to be covered.  That's to catch cases where a new source file is added, but not compiled into any tests. The rules which Croc uses on linux are a

[chromium-dev] V8DOMMap

2009-06-03 Thread Adam Barth
Who's a good contact for V8DOMMap? It's probably going to need some surgery to support isolated user scripts, and I want to make sure I'm not screwing it up. Thanks, Adam --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View

[chromium-dev] Re: V8DOMMap

2009-06-03 Thread Dimitri Glazkov
/me raises hand sheepishly. Whatcha need? :) :DG On Wed, Jun 3, 2009 at 5:37 PM, Adam Barth aba...@chromium.org wrote: Who's a good contact for V8DOMMap?  It's probably going to need some surgery to support isolated user scripts, and I want to make sure I'm not screwing it up. Thanks,

[chromium-dev] Re: Gleam API proposal

2009-06-03 Thread Andrew Charlton
Could a gleam maybe be a popup toolstrip rather than a single icon - I think that would open up lots of possibilities. You could have something like chrome.gleam.getSelected to return the selection. On Jun 4, 8:00 am, Aaron Boodman a...@chromium.org wrote: [I actually created this awhile ago,

[chromium-dev] RE : chrome's testing

2009-06-03 Thread sitan2006
BTW: I have reviewed all For developer docs on dev.chromium.org. But I don't think I started to know about chrome's test. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe:

[chromium-dev] Re: RE : chrome's testing

2009-06-03 Thread Pam Greene
If you've been through all those links, you've already seen these: http://dev.chromium.org/developers/testing http://dev.chromium.org/developers/testing/chromium-build-infrastructure/tour-of-the-chromium-buildbot Can you be more specific about what additional information you are looking for? -

[chromium-dev] Re: Print Settings Mockup

2009-06-03 Thread Ben Goodger (Google)
I think we should do a page. This work is not otherwise on our immediate term plan so it may as well get done the right way. I think the page is more of a print preview than a print settings. -Ben On Wed, Jun 3, 2009 at 8:14 PM, Mohamed Mansour m0.interact...@gmail.com wrote: So what is the

[chromium-dev] Re: DLLs missing and DCHECKs in recent builds

2009-06-03 Thread Mohamed Mansour
Yup, I can confirm. I had to manually build theme_dll or it hits crazy dchecks across the src. -- Mohamed Mansour On Wed, Jun 3, 2009 at 1:43 PM, Erik Kay erik...@chromium.org wrote: I haven't seen anyone else mention this, but I also had to manually rebuild tcmalloc for my build to succeed,

[chromium-dev] Re: Gleam API proposal

2009-06-03 Thread Aaron Boodman
I think the UI should be a single icon initially to conserve space, but when the user selects the icon, the extension could choose to display a floating toolstrip (we have some ideas about the implementation of those too but I haven't written them down yet). - a On Wed, Jun 3, 2009 at 1:58 PM,

[chromium-dev] Re: V8DOMMap

2009-06-03 Thread Mike Belshe
I may be able to help too. I'm very worried about adding more dependencies on it. void* casting is not good! Mike On Wed, Jun 3, 2009 at 5:53 PM, Dimitri Glazkov dglaz...@chromium.orgwrote: /me raises hand sheepishly. Whatcha need? :) :DG On Wed, Jun 3, 2009 at 5:37 PM, Adam Barth

[chromium-dev] Re: Question about chromium architecture

2009-06-03 Thread Meryl Silverburgh
On Tue, Jun 2, 2009 at 5:00 PM, Brett Wilson bre...@chromium.org wrote: On Tue, Jun 2, 2009 at 4:57 PM, Meryl Silverburgh silverburgh.me...@gmail.com wrote: I am reading this document http://dev.chromium.org/developers/how-tos/getting-around-the-chrome-source-code; about chromium source