Last week I updated our DEPS to pull in a newer version of Skia. I
was stumped at a few cases where the checked in PNG looked completely
wrong, but yet it was passing on the buildbots. There was no way that
image could have been the output.
It just dawned on me today, but I haven't verified
Hi,
I am getting error while compiling on ubuntu 9.04 (64bit)
/home/ibrar/Google/chromium/src/third_party/WebKit/WebCore/css/CSSParser.cpp:
In function 'int WebCore::cssValueKeywordID(const
WebCore::CSSParserString)':
While we're wishing, I'll add that verifying this should be added to
the presubmit script (if you touched any layout tests).
On Mon, Jun 22, 2009 at 3:20 AM, Dean McNameede...@chromium.org wrote:
Last week I updated our DEPS to pull in a newer version of Skia. I
was stumped at a few cases
2009/6/21 PhistucK phist...@gmail.com
Really? the statistics show that many people are using the app mode?Or did
you mean web apps, as in web application websites?
I mean web applications like gmail, hotmail, zoho, shopping carts, etc etc.
But it's an unsubstantiated claim.
Mike
Can we put this in a bug for easier trackage?
:DG
On Mon, Jun 22, 2009 at 5:58 AM, Evan Martine...@chromium.org wrote:
While we're wishing, I'll add that verifying this should be added to
the presubmit script (if you touched any layout tests).
On Mon, Jun 22, 2009 at 3:20 AM, Dean
On 21-Jun-09, at 10:22 AM, Mike Belshe wrote:
Second, the author is basically right. Since he's running on Vista,
its a bit hard to tell whether his stats included shared memory or
not; using the default memory statistic (Memory (Private Working
Set)) is actually a pretty good measure
Did clean build (whole solution), got DCHECK on extension_prefs.cc(54),
added --enable-extensions to startup and now it works.
On Fri, Jun 19, 2009 at 1:48 PM, Nebojša Ćirić c...@chromium.org wrote:
I am on Vista (win build).
On Fri, Jun 19, 2009 at 1:46 PM, Nebojša Ćirić c...@chromium.org
I built a web based application in php to upload dvd vob files to a
server via the browser. The only browser that makes this project a non
failure is chrome. Forget trying to upload 4+ gigs with Internet
Explorer. It can not handle the memory addressing. Firefox fails 90%
of the time. However
I am on Vista (win build).
On Fri, Jun 19, 2009 at 1:46 PM, Nebojša Ćirić c...@chromium.org wrote:
For last 2 days when I start chrome I get FATAL:tab_renderer.cc(123) Check
failed: waiting_animation_frames-width() %
waiting_animation_frames-height() == 0.
I am synced to HEAD, rebuild whole
For last 2 days when I start chrome I get FATAL:tab_renderer.cc(123) Check
failed: waiting_animation_frames-width() %
waiting_animation_frames-height() == 0.
I am synced to HEAD, rebuild whole solution (debug mode). Did anybody else
stumble on this problem?
Also, building chrome project doesn't
Definitely a question for chromium-dev...
-- Forwarded message --
From: Dinge Raphael raphael.di...@gmail.com
Date: Mon, Jun 22, 2009 at 5:45 AM
Subject: [chromium-discuss] Integrating Chromium to my project
To: chromium-disc...@googlegroups.com
Hi,
(I'm not sure if this
On Jun 21, 3:37 am, n179911 n179...@gmail.com wrote:
Hi,
There is a test which compares memory usage among rendering
engineshttp://dotnetperls.com/chrome-memory
From the site, it shows the maximum memory usage of Chrome is more
than Safari is 2 times.
Since both of them are Webkit base,
FYI from the webkit mailing list.
We'll probably want to prepare a similar CL for our binding generating code
and whoever is doing the merges should look out for this change being
landed.
J
On Sun, Jun 21, 2009 at 10:46 PM, Darin Adler da...@apple.com wrote:
The IDL file format we use to
On Mon, Jun 22, 2009 at 9:29 AM, Mike Beltzner beltz...@mozilla.com wrote:
On 21-Jun-09, at 10:22 AM, Mike Belshe wrote:
Second, the author is basically right. Since he's running on Vista, its a
bit hard to tell whether his stats included shared memory or not; using the
default memory
Since I'm waiting for a build I sat down to implement this.
But our image checksums are not checksums of the image files :(, but
rather checksums of the pixels stored in the image.
And Tony points out that our image checksumming is completely insane:
=
// Fix the alpha. The expected PNGs
You need to give more info. What revision of the source code are you
at? Did you make any local changes?
FWIW, we have a Jaunty build bot on the experimental waterfall and it built ok.
http://build.chromium.org/buildbot/waterfall.fyi/builders/Chromium%20Linux%20(Jaunty)/builds/1981
On Mon, Jun
If our binding code is already upstream by then, Darin may be able to
keep Chromium building throughout the process.
https://bugs.webkit.org/show_bug.cgi?id=26567
On Mon, Jun 22, 2009 at 9:53 AM, Jeremy Orlowjor...@chromium.org wrote:
FYI from the webkit mailing list.
We'll probably want to
I noticed this too. LayoutTests/fast/transforms/matrix-02.html has
been marked fail for a while on Linux because the checksum is
different from Windows, even though the output pngs are identical.
On Mon, Jun 22, 2009 at 10:24 AM, Evan Martine...@chromium.org wrote:
Since I'm waiting for a
I'm not so sure [1]but we can ask.
J
[1] http://lists.macosforge.org/pipermail/webkit-dev/2009-May/007960.html
http://lists.macosforge.org/pipermail/webkit-dev/2009-May/007960.html1)
We weren't super enthusiastic about the master WebKit tree trying
to support two different JavaScript
Just so I'm not all negative, my suggestions after consulting with Tony:
1) Make Linux behavior match Windows, ignoring the recommendation in
the comments below.
2) Rebaseline everything on Linux. :(
3) Now converting from a PNG file to expected output is easy on all
three platforms:
convert
I'm still not enthused about WebKit having 2 different JavaScript
engines. ;) But that's a discussion for another time...
-eric
On Mon, Jun 22, 2009 at 10:54 AM, Jeremy Orlowjor...@chromium.org wrote:
I'm not so sure [1]but we can ask.
J
[1]
This isn't the best, but it would be easy to add a flag to run-webkit-tests
that told it to always do the pixel comparison even if the checksums
matched.
Ojan
On Mon, Jun 22, 2009 at 10:55 AM, Evan Martin e...@chromium.org wrote:
Just so I'm not all negative, my suggestions after consulting
How about just running the pixel comparison only when the checksums don't
match? Still not ideal, of course.
-Greg.
On Mon, Jun 22, 2009 at 11:30 AM, Ojan Vafai o...@chromium.org wrote:
This isn't the best, but it would be easy to add a flag to run-webkit-tests
that told it to always do the
That's what we do now. It sounds like someone checked in new checksums
without their corresponding new images, though, so the tests pass even
though the nominally expected PNGs are wrong.
- Pam
On Mon, Jun 22, 2009 at 11:40 AM, Greg Spencer gspen...@google.com wrote:
How about just running
Amen.
I am working on it :) First step -- teach our code generator to
understand IDL in the same way JSC does.
:DG
On Mon, Jun 22, 2009 at 12:02 PM, Aaron Boodmana...@chromium.org wrote:
One thing I'd really like to see is a reduction in the amount of
custom bindings code. I am terrified by
I agree. I was thinking about looking into this (once LocalStorage is
working).
Besides the fact that we have more custom code than we should have, a good
portion of the .dll is just generated code. It seems like we should be able
to strike a better balance of doing things dynamically vs
Hi, I think there're two ways to start GTest test cases: writing a main by
myself or linking a gtest_main.lib.
But I find something weird in the chromiun's GTest projects, they neither
write a main nor link a gtest_main.lib.
How do they start GTest?
On Mon, Jun 22, 2009 at 7:55 PM, Jickae Davisjick...@gmail.com wrote:
But I find something weird in the chromiun's GTest projects, they neither
write a main nor link a gtest_main.lib.
How do they start GTest?
Well, you can always set a breakpoint at main and see where you end
up. For
nbsp;I've changed the .gclient, and downloaded the layout tests.But I can't
run it, it just always give me a msg back:
nbsp;
###
## Layout test system dependencies check failed.
## Some layout tests may fail due to unexpected theme.
##
Porting bits of UI like dialog boxes by creating a
platform-independent base class and subclassing for each platform is
now no longer allowed.
In C++, inheritance is something to be used carefully. You should
create a subclass only when the derived class is a logical
specialization. That one
On Mon, Jun 22, 2009 at 10:22 PM, Ben Goodger (Google) b...@chromium.orgwrote:
If you are creating UI on another platform and want to reuse common
code, please move the common code into a separate object that the
platform specific UI owns.
Note that this is a specific application of a
31 matches
Mail list logo
