[chromium-dev] Major tab cold regression on mac around r24415

2009-08-26 Thread Mike Pinkerton
If you look at http://build.chromium.org/buildbot/perf/mac-release-10.5/new-tab-ui-cold/report.html?history=150 You'll see a pretty big spike in new tab performance between r24415 and r24419

[chromium-dev] Re: Major tab cold regression on mac around r24415

2009-08-26 Thread Evan Martin
PS Every time I want to call it the EPIC CHANGE. On Wed, Aug 26, 2009 at 9:27 AM, Evan Martine...@chromium.org wrote: Here's a guess: the history file is restored each time the test runs, and Brett's epoch change means that we need to re-migrate the history file every time we start. (I

[chromium-dev] Chromium Engineering Snippets for 8/17 - 8/23

2009-08-26 Thread Glen Murphy
Chromium Engineering Snippets 8/17 - 8/23 - Chromium builder on webkit.org going up this week. - Notifications[1] work starting to land - Global Script Context[2] engineering starting - O3D on track to be in Chrome dev channel by EOQ - Epoch change landing for Mac/Linux history databases - 3.0

[chromium-dev] Re: Major tab cold regression on mac around r24415

2009-08-26 Thread Thomas Van Lenten
On Wed, Aug 26, 2009 at 12:32 PM, Thomas Van Lenten thoma...@chromium.orgwrote: On Wed, Aug 26, 2009 at 12:28 PM, Evan Martin e...@chromium.org wrote: PS Every time I want to call it the EPIC CHANGE. On Wed, Aug 26, 2009 at 9:27 AM, Evan Martine...@chromium.org wrote: Here's a guess:

[chromium-dev] Re: Major tab cold regression on mac around r24415

2009-08-26 Thread Dean McNamee
Looking at the graphs this would seem to make sense. All of the tests except the one using 'typical_history' have regressed. That's because Brett checked in the upgraded database for typical_history, but not for the other themes. We should just upgrade those and check them in. On Wed, Aug 26,

[chromium-dev] Re: Major tab cold regression on mac around r24415

2009-08-26 Thread Mike Pinkerton
I don't think that's it, because it's just one test that's affected. If it were the epoch change, I'd expect more tests to show similar bumps. On Wed, Aug 26, 2009 at 9:28 AM, Evan Martine...@chromium.org wrote: PS Every time I want to call it the EPIC CHANGE. On Wed, Aug 26, 2009 at 9:27 AM,

[chromium-dev] Re: Major tab cold regression on mac around r24415

2009-08-26 Thread Evan Martin
Here's a guess: the history file is restored each time the test runs, and Brett's epoch change means that we need to re-migrate the history file every time we start. (I don't recall how this test works, but it seems logical to test NTP performance you'd want some data that the NTP would make use

[chromium-dev] Copying of profiles across systems

2009-08-26 Thread Avi Drissman
I've heard people proclaim the principle of being able to copy a profile across systems as being a deciding factor for certain changes (e.g. the history epoch change). However, it doesn't seem to be universally held or obeyed, and I'm not sure to the extent to which it can be obeyed. So some

[chromium-dev] Re: Major tab cold regression on mac around r24415

2009-08-26 Thread Thomas Van Lenten
On Wed, Aug 26, 2009 at 12:28 PM, Evan Martin e...@chromium.org wrote: PS Every time I want to call it the EPIC CHANGE. On Wed, Aug 26, 2009 at 9:27 AM, Evan Martine...@chromium.org wrote: Here's a guess: the history file is restored each time the test runs, and Brett's epoch change means

[chromium-dev] Re: Copying of profiles across systems

2009-08-26 Thread Brett Wilson
On Wed, Aug 26, 2009 at 10:23 AM, Avi Drissmana...@google.com wrote: I've heard people proclaim the principle of being able to copy a profile across systems as being a deciding factor for certain changes (e.g. the history epoch change). However, it doesn't seem to be universally held or

[chromium-dev] Re: Copying of profiles across systems

2009-08-26 Thread John Abd-El-Malek
I think this is one of those things that aren't worth the effort. Brett's change was also to fix other bugs, so it wasn't just for this. I'd be surprised if people spend time to fix bugs solely for this. On Wed, Aug 26, 2009 at 10:23 AM, Avi Drissman a...@google.com wrote: I've heard people

[chromium-dev] Re: Copying of profiles across systems

2009-08-26 Thread Darin Fisher
On Wed, Aug 26, 2009 at 10:23 AM, Avi Drissman a...@google.com wrote: I've heard people proclaim the principle of being able to copy a profile across systems as being a deciding factor for certain changes (e.g. the history epoch change). However, it doesn't seem to be universally held or

[chromium-dev] Re: Copying of profiles across systems

2009-08-26 Thread Dan Kegel
On Wed, Aug 26, 2009 at 12:28 PM, Darin Fisherda...@chromium.org wrote: I've heard people proclaim the principle of being able to copy a profile across systems as being a deciding factor for certain changes (e.g. the history epoch change). However, it doesn't seem to be universally held or

[chromium-dev] Re: Copying of profiles across systems

2009-08-26 Thread Stuart Morgan
On Wed, Aug 26, 2009 at 10:23 AM, Avi Drissmana...@google.com wrote: - Is profile platform independence a guiding principle? [...] - Is it worth rewriting today's code that doesn't conform It didn't seem to be when I asked about password storage a while back. Passwords aren't even portable

[chromium-dev] Re: Copying of profiles across systems

2009-08-26 Thread Avi Drissman
Then password management would also fall under the category of can't be made portable and that's fine. It's just that I've heard profile platform independence tossed around as being a guiding principle and I was surprised that some people treated it as so. Avi /who wonders how it fits into

[chromium-dev] Re: Copying of profiles across systems

2009-08-26 Thread Darin Fisher
On Wed, Aug 26, 2009 at 12:16 PM, Brett Wilson bre...@chromium.org wrote: On Wed, Aug 26, 2009 at 10:23 AM, Avi Drissmana...@google.com wrote: I've heard people proclaim the principle of being able to copy a profile across systems as being a deciding factor for certain changes (e.g. the

[chromium-dev] Re: Copying of profiles across systems

2009-08-26 Thread Dan Kegel
On Wed, Aug 26, 2009 at 12:59 PM, Jeremy Orlowjor...@chromium.org wrote: I really like the idea of being able to move people between operating systems and just bringing the profile along without having to export and import... (seems to me there are online services that offer that

[chromium-dev] Re: Copying of profiles across systems

2009-08-26 Thread John Abd-El-Malek
On Wed, Aug 26, 2009 at 12:41 PM, Darin Fisher da...@chromium.org wrote: On Wed, Aug 26, 2009 at 12:16 PM, Brett Wilson bre...@chromium.orgwrote: On Wed, Aug 26, 2009 at 10:23 AM, Avi Drissmana...@google.com wrote: I've heard people proclaim the principle of being able to copy a profile

[chromium-dev] Re: Copying of profiles across systems

2009-08-26 Thread Jeremy Orlow
On Wed, Aug 26, 2009 at 12:48 PM, Dan Kegel d...@kegel.com wrote: On Wed, Aug 26, 2009 at 12:28 PM, Darin Fisherda...@chromium.org wrote: I've heard people proclaim the principle of being able to copy a profile across systems as being a deciding factor for certain changes (e.g. the

[chromium-dev] Re: Copying of profiles across systems

2009-08-26 Thread Michael Nordman
Is the OS in the user-agent string? Mozilla/5.0 (*Windows*; U; Windows NT 6.0; en-US) AppleWebKit/532.0 (KHTML, like Gecko) Chrome/3.0.195.6 Safari/532.0 There's a chance that http resource caches will contain data tweeked per OS. Maybe for cosmetic purposes... to make it look more OSX'y or

[chromium-dev] Re: Copying of profiles across systems

2009-08-26 Thread Ben Goodger (Google)
BTW we have two separate prefs files, Preferences and Local State to support this sort of thing in the pref system at least. Whether or not people put the right settings in the right data stores is another question. -Ben On Wed, Aug 26, 2009 at 10:23 AM, Avi Drissmana...@google.com wrote:

[chromium-dev] Re: Copying of profiles across systems

2009-08-26 Thread Tony Chang
FWIW, I think this distinction is confusing without good use cases backed by tests to enforce the two separate files. I think we should just merge them for now (which would simplify the code and be one less file to read on startup) and re-split once we know what the use cases are. You could

[chromium-dev] Re: Formatting substrings in a views::Label

2009-08-26 Thread Aaron Boodman
Argh. Forgot attachment. On Wed, Aug 26, 2009 at 2:15 PM, Aaron Boodmana...@chromium.org wrote: I'm playing with different ideas for the extension install dialog, and would like to do something like the attacked mock. I can see that there is no support for this in Label presently and I'm

[chromium-dev] Re: Copying of profiles across systems

2009-08-26 Thread Avi Drissman
On Wed, Aug 26, 2009 at 2:31 PM, Ben Goodger (Google) b...@chromium.orgwrote: Note that even upgrading Windows OS from XP to Vista involves changing paths: c:\Documents and Settings - c:\Users Do we ever write paths such as this? Yes. From my Preferences file on Windows: id:

[chromium-dev] Re: Copying of profiles across systems

2009-08-26 Thread John Abd-El-Malek
On Wed, Aug 26, 2009 at 1:20 PM, Dan Kegel d...@kegel.com wrote: On Wed, Aug 26, 2009 at 12:59 PM, Jeremy Orlowjor...@chromium.org wrote: I really like the idea of being able to move people between operating systems and just bringing the profile along without having to export and

[chromium-dev] Re: Copying of profiles across systems

2009-08-26 Thread Peter Kasting
On Wed, Aug 26, 2009 at 2:37 PM, Avi Drissman a...@google.com wrote: On Wed, Aug 26, 2009 at 2:31 PM, Ben Goodger (Google) b...@chromium.orgwrote: Note that even upgrading Windows OS from XP to Vista involves changing paths: c:\Documents and Settings - c:\Users Do we ever write paths

[chromium-dev] Formatting substrings in a views::Label

2009-08-26 Thread Aaron Boodman
I'm playing with different ideas for the extension install dialog, and would like to do something like the attacked mock. I can see that there is no support for this in Label presently and I'm told by Dean that the APIs for doing this are different across platforms. Is it worth adding an

[chromium-dev] Re: Copying of profiles across systems

2009-08-26 Thread Michael Nordman
+ chromium-dev (this time, sorry for the resend) Is the OS in the user-agent string? Mozilla/5.0 (*Windows*; U; Windows NT 6.0; en-US) AppleWebKit/532.0 (KHTML, like Gecko) Chrome/3.0.195.6 Safari/532.0 There's a chance that http resource caches will contain data tweeked per OS. Maybe for

[chromium-dev] Copy/Paste suddenly not working?

2009-08-26 Thread Andrew Herrgott
Hello. I'm using Chrome on Ubuntu Hardy. Yesterday, my copy/paste functionality seemed to disappear from Chrome. I can copy/paste to and from other applications. I can also select text and drag it from Chrome to textpad. However, ctrl x / ctrl c / ctrl v and the right click menu cut/copy/

[chromium-dev] newbie question on ubuntu 8.04 : checking my directory and gclient sync is setup properly

2009-08-26 Thread TC
I am a newbie Chromium developer on ubuntu 8.04. This is the first time I execute the gclient sync command. Please check whether my directory and gclient sync is setup properly. Thanks. $ echo $CHROMIUM_ROOT /home/tcma/chromium $ gclient sync ... U

[chromium-dev] Re: Copy/Paste suddenly not working?

2009-08-26 Thread Peter Kasting
On Mon, Aug 24, 2009 at 4:48 PM, Andrew Herrgott aherrg...@gmail.comwrote: I'm using Chrome on Ubuntu Hardy. Yesterday, my copy/paste functionality seemed to disappear from Chrome. I can copy/paste to and from other applications. I can also select text and drag it from Chrome to textpad.

[chromium-dev] Re: Copying of profiles across systems

2009-08-26 Thread Ben Goodger (Google)
Note that even upgrading Windows OS from XP to Vista involves changing paths: c:\Documents and Settings - c:\Users Do we ever write paths such as this? Local state should be data that can be thrown away without much loss of user experience. Generally these things include window positions, file

[chromium-dev] Re: Formatting substrings in a views::Label

2009-08-26 Thread Brett Wilson
+finnur who did this for the about box. Brett On Wed, Aug 26, 2009 at 2:15 PM, Aaron Boodmana...@chromium.org wrote: Argh. Forgot attachment. On Wed, Aug 26, 2009 at 2:15 PM, Aaron Boodmana...@chromium.org wrote: I'm playing with different ideas for the extension install dialog, and

[chromium-dev] Re: Subversion tags for stable/beta/dev?

2009-08-26 Thread Aaron Boodman
Checking up on this. I don't see the tags in src.chromium.org yet. Can we get this going for the next dev release? - a On Tue, Aug 11, 2009 at 1:30 PM, Aaron Boodmana...@chromium.org wrote: Hooray, thanks Mark. - a On Tue, Aug 11, 2009 at 1:22 PM, Mark Larson (Google)m...@chromium.org

[chromium-dev] Creating a SkBitmap filled with one color

2009-08-26 Thread Paweł Hajdan Jr .
How do I create a SkBitmap of arbitrary size, filled with color of my choice (on Linux)? I'd need that for Linux extension shelf, and the Windows code for that seems not easily portable to Linux. --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] Re: Creating a SkBitmap filled with one color

2009-08-26 Thread Evan Stade
Use cairo instead of Skia if you can avoid it in gtk code. -- Evan Stade On Wed, Aug 26, 2009 at 4:12 PM, Paweł Hajdan Jr.phajdan...@chromium.org wrote: How do I create a SkBitmap of arbitrary size, filled with color of my choice (on Linux)? I'd need that for Linux extension shelf, and the

[chromium-dev] Re: Creating a SkBitmap filled with one color

2009-08-26 Thread Nico Weber
When I talked with Aaron, he said porting the shelf to OS X isn't something I should tackle unless I'm _really_ running out of things to do, since they're not even sure they're going to keep it. Has this changed, or is the situation different on linux for some reason? Nico On Wed, Aug 26, 2009

[chromium-dev] Re: Creating a SkBitmap filled with one color

2009-08-26 Thread Dean McNamee
To answer the technical (non-political) part of this question. Create a SkBitmap which backs to some pixels. Create a SkCanvas on top of it. Call drawPaint or more directly drawColor. On Wed, Aug 26, 2009 at 4:17 PM, Nico Weber tha...@chromium.org wrote: When I talked with Aaron, he said

[chromium-dev] Re: Subversion tags for stable/beta/dev?

2009-08-26 Thread Paweł Hajdan Jr .
Seconded. Tags would make my work on packaging for Gentoo much easier. On Wed, Aug 26, 2009 at 15:51, Aaron Boodman a...@chromium.org wrote: Checking up on this. I don't see the tags in src.chromium.org yet. Can we get this going for the next dev release? - a On Tue, Aug 11, 2009 at 1:30

[chromium-dev] Re: Creating a SkBitmap filled with one color

2009-08-26 Thread Erik Kay
On Wed, Aug 26, 2009 at 4:17 PM, Nico Webertha...@chromium.org wrote: When I talked with Aaron, he said porting the shelf to OS X isn't something I should tackle unless I'm _really_ running out of things to do, since they're not even sure they're going to keep it. Has this changed, or is the

[chromium-dev] Re: Creating a SkBitmap filled with one color

2009-08-26 Thread Paweł Hajdan Jr .
Thanks for all the answers, especially the first one from erg. I'm going to use Skia, because another method (SetBackground in RWHV) requires that. On Wed, Aug 26, 2009 at 16:33, Tony Chang t...@chromium.org wrote: There's an example of how to do this with skia in src/app/resource_bundle.cc

[chromium-dev] Re: Creating a SkBitmap filled with one color

2009-08-26 Thread Adam Langley
On Wed, Aug 26, 2009 at 4:12 PM, Paweł Hajdan Jr.phajdan...@chromium.org wrote: How do I create a SkBitmap of arbitrary size, filled with color of my choice (on Linux)? Without any testing at all, it would look a little like SkBitmap bitmap; bitmap.setConfig(SkBitmap::kARGB__Config,

[chromium-dev] Re: Creating a SkBitmap filled with one color

2009-08-26 Thread Elliot Glaysher (Chromium)
See what I do in GtkThemeProvider::LoadThemeBitmap: SkBitmap* bitmap = new SkBitmap; bitmap-setConfig(SkBitmap::kARGB__Config, kToolbarImageWidth, kToolbarImageHeight); bitmap-allocPixels(); bitmap-eraseRGB(color-red 8, color-green 8, color-blue 8);

[chromium-dev] Re: Creating a SkBitmap filled with one color

2009-08-26 Thread Dean McNamee
On Wed, Aug 26, 2009 at 4:14 PM, Elliot Glaysher (Chromium) e...@chromium.org wrote: See what I do in GtkThemeProvider::LoadThemeBitmap:    SkBitmap* bitmap = new SkBitmap;    bitmap-setConfig(SkBitmap::kARGB__Config,                      kToolbarImageWidth, kToolbarImageHeight);    

[chromium-dev] Re: Creating a SkBitmap filled with one color

2009-08-26 Thread Tony Chang
There's an example of how to do this with skia in src/app/resource_bundle.cc around line 146. That said, you should use cairo to paint in GTK. On Wed, Aug 26, 2009 at 4:27 PM, Dean McNamee de...@chromium.org wrote: To answer the technical (non-political) part of this question. Create a

[chromium-dev] Re: layout test dashboard

2009-08-26 Thread Ojan Vafai
One final update. 1. The bogus results on windows are gone. 2. BUG*** now actually links to the bug. 3. Hides WONTFIX tests by default, with a checkbox to show them. 4. Linux release bot is now listed (debug coming soon) 5. The dashboard now shows (highlights in blue) all cases

[chromium-dev] Re: Creating a SkBitmap filled with one color

2009-08-26 Thread Nico Weber
This code is incorrect, you should divide by 257, not 256.  See the GDK_COLOR_RGB macro. That's not true. GDK_COLOR_RGB multiplies by 257 (= 0x10001) to distribute the bits evenly ( http://www.mindcontrol.org/~hplus/graphics/expand-bits.html ). To get back, you can just shift (or, formulated

[chromium-dev] Re: Creating a SkBitmap filled with one color

2009-08-26 Thread Dean McNamee
Yes, this can be reformulated easier as i * 257 = i * 256 + i and i / 256 will always be zero for i 256. Anyway, I suppose it doesn't matter. The question is what to do for mapping 16-bit back to 8-bit, when it wasn't necessarily originally produced from 8-bit. I suppose that dividing by

[chromium-dev] Re: Tab-modal dialog/sheet UI design document (long)

2009-08-26 Thread Nick Baum
Making these dialogs tab-modal is a great improvement, and very Chrome-y! Thanks for helping with that. Let me take a stab at answering your questions. Ben and Glen, chime in if you disagree. -Nick On Fri, Aug 21, 2009 at 10:03 AM, Viet-Trung Luu viettrung...@gmail.comwrote: Having played with

[chromium-dev] Re: layout test dashboard

2009-08-26 Thread Peter Kasting
On Wed, Aug 26, 2009 at 5:12 PM, Ojan Vafai o...@chromium.org wrote: The only work I still plan to do on it is to make it perform a bit better. Please file bugs if there are other additions that would be useful to you. This is super-minor, but it might be nice to indicate, for the flakiness

[chromium-dev] Re: Formatting substrings in a views::Label

2009-08-26 Thread Finnur Thorarinsson
Yes, the views class Link is a specialization of the class Label, and it is responsible for handling hyperlinks. On Wed, Aug 26, 2009 at 15:32, Brett Wilson bre...@chromium.org wrote: +finnur who did this for the about box. Brett On Wed, Aug 26, 2009 at 2:15 PM, Aaron

[chromium-dev] Re: Copying of profiles across systems

2009-08-26 Thread PhistucK
Bearing the upcoming Chrome OS in mind, this should be taken into account quite strongly.Regular programs will probably not move cleanly and nicely from Windows to Chrome OS, but, at least, Google products should migrate seamlessly, without any data loss (and passwords are a very important part,

[chromium-dev] Loading problems chromium on mac os x

2009-08-26 Thread n179911
Hi, I have download the source of chromium and compile it on mac osx. After I build it, I load sites like 'www.cnn.com', 'www.nytimes.com', it starts loading but it never finishes. I eventually get this 'The following pages have become unresponsive. You can wait for them to become responsive or

[chromium-dev] Re: Loading problems chromium on mac os x

2009-08-26 Thread Amanda Walker
If you are running Chromium from inside Xcode, make sure that you turn off the Stop on Debugger()/DebugStr() option in the Run menu. The Flash plugin makes a call to Debugger() when it starts up--normally this is harmless, but if you are running from Xcode instead of the Finder, it will cause

[chromium-dev] Git woes

2009-08-26 Thread Nico Weber
Trying to pull: thakis-macbookpro:~/src/chrome-git/src thakis$ git pull remote: Counting objects: 1859, done. remote: Compressing objects: 100% (1267/1267), done. remote: Total 1393 (delta 1087), reused 195 (delta 107) Receiving objects: 100% (1393/1393), 2.57 MiB | 781 KiB/s, done. fatal:

[chromium-dev] Re: Git woes

2009-08-26 Thread Jeremy Moskovich
Git is comprised of billions of tiny orthogonal binaries. When this happened to me the cause was some old git binaries in the path that where being called by others, the version mismatch was silent and caused this error. Have you upgraded to a new version of git recently that might cause such a